diff options
| author | Jake Potrebic <[email protected]> | 2024-11-04 09:43:26 -0800 |
|---|---|---|
| committer | GitHub <[email protected]> | 2024-11-04 18:43:26 +0100 |
| commit | 93b435dbab92d071bd685c6d8dda9fd32c4c2990 (patch) | |
| tree | adb574362fcffaf35320516ab424cb386a3cbcd4 | |
| parent | c6aa61ee18f0b3db83a4ef4bb25dc6b1761f2e3b (diff) | |
| download | Paper-93b435dbab92d071bd685c6d8dda9fd32c4c2990.tar.gz Paper-93b435dbab92d071bd685c6d8dda9fd32c4c2990.zip | |
[ci skip] better instructions for patch apply conflict (#11568)
| -rw-r--r-- | CONTRIBUTING.md | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index be94ba56a9..32be536ebc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -185,6 +185,8 @@ These steps assume the `origin` remote is your fork of this repository and `upst 1. Checkout feature/fix branch and rebase on master: `git checkout patch-branch && git rebase master`. 1. Apply updated patches: `./gradlew applyPatches`. 1. If there are conflicts, fix them. + * If there are conflicts within `Paper-API`, after fixing them run `./gradlew rebuildApiPatches` before re-running `./gradlew applyPatches`. + * The API patches are applied first, so if there are conflicts in the API patches, the server patches will not be applied. 1. If your PR creates new patches instead of modifying existing ones, in both the `Paper-Server` and `Paper-API` directories, ensure your newly-created patch is the last commit by either: * Renaming the patch file with a large 4-digit number in front (e.g. 9999-Patch-to-add-some-new-stuff.patch), and re-applying patches. * Running `git rebase --interactive base` and moving the commits to the end. |