Use internals for getting block/entity countstimings/use-internals

For a long time I've been meaning to move some of this logic internally
as this would allow us to avoid hitting systems like block state snapshots
which can create issues as many of the spigot implementations of this
stuff are increasingly broken, leading to unexpected crashes during ticking,
even if the API cannot properly interact with these such states/items,
it's generally more preferable to not crash the server in the course,
and just let those interactions fail more gracefully.

1 files changed, 63 insertions, 0 deletions

diff --git a/patches/api/0311-Get-entity-default-attributes.patch b/patches/api/0311-Get-entity-default-attributes.patch
new file mode 100644
index 0000000000..4a094264ca
--- /dev/null
+++ b/patches/api/0311-Get-entity-default-attributes.patch
@@ -0,0 +1,63 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Jake Potrebic <[email protected]>
+Date: Fri, 20 Aug 2021 13:03:55 -0700
+Subject: [PATCH] Get entity default attributes
+
+
+diff --git a/src/main/java/org/bukkit/UnsafeValues.java b/src/main/java/org/bukkit/UnsafeValues.java
+index 0a8a9e6fbead467737530ce6c84560dcbb803282..5028340475d3742ea407dfb70e0d2b2a3492dda3 100644
+--- a/src/main/java/org/bukkit/UnsafeValues.java
++++ b/src/main/java/org/bukkit/UnsafeValues.java
+@@ -187,5 +187,22 @@ public interface UnsafeValues {
+      * @return true if valid repair, false if not
+      */
+     public boolean isValidRepairItemStack(@org.jetbrains.annotations.NotNull ItemStack itemToBeRepaired, @org.jetbrains.annotations.NotNull ItemStack repairMaterial);
++
++    /**
++     * Checks if the entity represented by the namespaced key has default attributes.
++     *
++     * @param entityKey the entity's key
++     * @return true if it has default attributes
++     */
++    boolean hasDefaultEntityAttributes(@org.jetbrains.annotations.NotNull NamespacedKey entityKey);
++
++    /**
++     * Gets the default attributes for the entity represented by the namespaced key.
++     *
++     * @param entityKey the entity's key
++     * @return an unmodifiable instance of Attributable for reading default attributes.
++     * @throws IllegalArgumentException if the entity does not exist of have default attributes (use {@link #hasDefaultEntityAttributes(NamespacedKey)} first)
++     */
++    @org.jetbrains.annotations.NotNull org.bukkit.attribute.Attributable getDefaultEntityAttributes(@org.jetbrains.annotations.NotNull NamespacedKey entityKey);
+     // Paper end
+ }
+diff --git a/src/main/java/org/bukkit/entity/EntityType.java b/src/main/java/org/bukkit/entity/EntityType.java
+index b7a454ca11d484209d08d0003d4c19a431456687..1d1315262737d99bf9f5aabc0ae66eee4645cc65 100644
+--- a/src/main/java/org/bukkit/entity/EntityType.java
++++ b/src/main/java/org/bukkit/entity/EntityType.java
+@@ -453,6 +453,25 @@ public enum EntityType implements Keyed, Translatable, net.kyori.adventure.trans
+         Preconditions.checkArgument(this != UNKNOWN, "UNKNOWN entities do not have translation keys");
+         return org.bukkit.Bukkit.getUnsafe().getTranslationKey(this);
+     }
++
++    /**
++     * Checks if the entity has default attributes.
++     *
++     * @return true if it has default attributes
++     */
++    public boolean hasDefaultAttributes() {
++        return org.bukkit.Bukkit.getUnsafe().hasDefaultEntityAttributes(this.key);
++    }
++
++    /**
++     * Gets the default attributes for the entity.
++     *
++     * @return an unmodifiable instance of Attributable for reading default attributes.
++     * @throws IllegalArgumentException if the entity does not exist of have default attributes (use {@link #hasDefaultAttributes()} first)
++     */
++    public @NotNull org.bukkit.attribute.Attributable getDefaultAttributes() {
++        return org.bukkit.Bukkit.getUnsafe().getDefaultEntityAttributes(this.key);
++    }
+     // Paper end
+ 
+     /**