Use internals for getting block/entity countstimings/use-internals

For a long time I've been meaning to move some of this logic internally
as this would allow us to avoid hitting systems like block state snapshots
which can create issues as many of the spigot implementations of this
stuff are increasingly broken, leading to unexpected crashes during ticking,
even if the API cannot properly interact with these such states/items,
it's generally more preferable to not crash the server in the course,
and just let those interactions fail more gracefully.

1 files changed, 0 insertions, 52 deletions

diff --git a/patches/api/0431-Add-titleOverride-to-InventoryOpenEvent.patch b/patches/api/0431-Add-titleOverride-to-InventoryOpenEvent.patch
deleted file mode 100644
index 68e755f010..0000000000
--- a/patches/api/0431-Add-titleOverride-to-InventoryOpenEvent.patch
+++ /dev/null
@@ -1,52 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Jake Potrebic <[email protected]>
-Date: Fri, 4 Mar 2022 12:45:21 -0800
-Subject: [PATCH] Add titleOverride to InventoryOpenEvent
-
-
-diff --git a/src/main/java/org/bukkit/event/inventory/InventoryOpenEvent.java b/src/main/java/org/bukkit/event/inventory/InventoryOpenEvent.java
-index ceae092eb782698803c6c3df41267dde20ba62b2..8e2afeab4c62724148e8bb0c83fb7eec569c7a0c 100644
---- a/src/main/java/org/bukkit/event/inventory/InventoryOpenEvent.java
-+++ b/src/main/java/org/bukkit/event/inventory/InventoryOpenEvent.java
-@@ -12,6 +12,7 @@ import org.jetbrains.annotations.NotNull;
- public class InventoryOpenEvent extends InventoryEvent implements Cancellable {
-     private static final HandlerList handlers = new HandlerList();
-     private boolean cancelled;
-+    private net.kyori.adventure.text.Component titleOverride; // Paper
- 
-     public InventoryOpenEvent(@NotNull InventoryView transaction) {
-         super(transaction);
-@@ -56,6 +57,33 @@ public class InventoryOpenEvent extends InventoryEvent implements Cancellable {
-         cancelled = cancel;
-     }
- 
-+    // Paper start
-+    /**
-+     * Gets the title override set by another event or null
-+     * if not set.
-+     *
-+     * @return the title override or null
-+     */
-+    public [email protected] Component titleOverride() {
-+        return this.titleOverride;
-+    }
-+
-+    /**
-+     * Sets the title override or clears the override.
-+     * <p>
-+     * This is only the title sent to the client in the open packet, this doesn't change
-+     * the title returned by {@link InventoryView#title()}, hence "override".
-+     * <p>
-+     * <b>NOTE:</b> Horse inventories are a special case where setting this will
-+     * have no effect. Horse inventory titles are set by the horse display name.
-+     *
-+     * @param titleOverride the title override or null
-+     */
-+    public void titleOverride([email protected] Component titleOverride) {
-+        this.titleOverride = titleOverride;
-+    }
-+    // Paper end
-+
-     @NotNull
-     @Override
-     public HandlerList getHandlers() {