Use internals for getting block/entity countstimings/use-internals

For a long time I've been meaning to move some of this logic internally
as this would allow us to avoid hitting systems like block state snapshots
which can create issues as many of the spigot implementations of this
stuff are increasingly broken, leading to unexpected crashes during ticking,
even if the API cannot properly interact with these such states/items,
it's generally more preferable to not crash the server in the course,
and just let those interactions fail more gracefully.

1 files changed, 45 insertions, 0 deletions

diff --git a/patches/api/0438-Expand-LingeringPotion-API.patch b/patches/api/0438-Expand-LingeringPotion-API.patch
new file mode 100644
index 0000000000..40b5a5f547
--- /dev/null
+++ b/patches/api/0438-Expand-LingeringPotion-API.patch
@@ -0,0 +1,45 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Tamion <[email protected]>
+Date: Sat, 4 Nov 2023 23:56:23 +0100
+Subject: [PATCH] Expand LingeringPotion API
+
+
+diff --git a/src/main/java/org/bukkit/event/entity/LingeringPotionSplashEvent.java b/src/main/java/org/bukkit/event/entity/LingeringPotionSplashEvent.java
+index 1584c6c41c3ca51b8ab7f48efb140b0fe31f535b..34efe59493729449fe1316ab8f2f7211acf679be 100644
+--- a/src/main/java/org/bukkit/event/entity/LingeringPotionSplashEvent.java
++++ b/src/main/java/org/bukkit/event/entity/LingeringPotionSplashEvent.java
+@@ -17,6 +17,7 @@ public class LingeringPotionSplashEvent extends ProjectileHitEvent implements Ca
+     private static final HandlerList handlers = new HandlerList();
+     private boolean cancelled;
+     private final AreaEffectCloud entity;
++    private boolean allowEmptyAreaEffectCreation; // Paper
+ 
+     @Deprecated
+     public LingeringPotionSplashEvent(@NotNull final ThrownPotion potion, @NotNull final AreaEffectCloud entity) {
+@@ -44,6 +45,26 @@ public class LingeringPotionSplashEvent extends ProjectileHitEvent implements Ca
+         return entity;
+     }
+ 
++    // Paper start
++    /**
++     * Sets if an Empty AreaEffectCloud may be created
++     *
++     * @param allowEmptyAreaEffectCreation If an Empty AreaEffectCloud may be created
++     */
++    public void allowsEmptyCreation(boolean allowEmptyAreaEffectCreation) {
++        this.allowEmptyAreaEffectCreation = allowEmptyAreaEffectCreation;
++    }
++
++    /**
++     * Gets if an empty AreaEffectCloud may be created
++     *
++     * @return if an empty AreaEffectCloud may be created
++     */
++    public boolean allowsEmptyCreation() {
++        return allowEmptyAreaEffectCreation;
++    }
++    // Paper end
++
+     @Override
+     public boolean isCancelled() {
+         return cancelled;