Use internals for getting block/entity countstimings/use-internals

For a long time I've been meaning to move some of this logic internally
as this would allow us to avoid hitting systems like block state snapshots
which can create issues as many of the spigot implementations of this
stuff are increasingly broken, leading to unexpected crashes during ticking,
even if the API cannot properly interact with these such states/items,
it's generally more preferable to not crash the server in the course,
and just let those interactions fail more gracefully.

1 files changed, 24 insertions, 0 deletions

diff --git a/patches/api/0450-Add-BlockStateMeta-clearBlockState.patch b/patches/api/0450-Add-BlockStateMeta-clearBlockState.patch
new file mode 100644
index 0000000000..7e8c47a8e2
--- /dev/null
+++ b/patches/api/0450-Add-BlockStateMeta-clearBlockState.patch
@@ -0,0 +1,24 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Jake Potrebic <[email protected]>
+Date: Thu, 11 Jan 2024 12:41:54 -0800
+Subject: [PATCH] Add BlockStateMeta#clearBlockState
+
+
+diff --git a/src/main/java/org/bukkit/inventory/meta/BlockStateMeta.java b/src/main/java/org/bukkit/inventory/meta/BlockStateMeta.java
+index c7d3041221742f6655155f19ef2addcaf2401015..dedb33e3d7f99e12fddba438af0874e6973d9372 100644
+--- a/src/main/java/org/bukkit/inventory/meta/BlockStateMeta.java
++++ b/src/main/java/org/bukkit/inventory/meta/BlockStateMeta.java
+@@ -14,6 +14,13 @@ public interface BlockStateMeta extends ItemMeta {
+      */
+     boolean hasBlockState();
+ 
++    // Paper start - add method to clear block state
++    /**
++     * Clears the block state currently attached to this item.
++     */
++    void clearBlockState();
++    // Paper end - add method to clear block state
++
+     /**
+      * Returns the currently attached block state for this
+      * item or creates a new one if one doesn't exist.