aboutsummaryrefslogtreecommitdiffhomepage
path: root/patches/server/0059-Add-exception-reporting-event.patch
diff options
context:
space:
mode:
authorNassim Jahnke <[email protected]>2022-12-07 19:32:25 +0100
committerNassim Jahnke <[email protected]>2022-12-07 19:32:25 +0100
commit0edb5458e51e6a9f5be1fdb7016030409eaa6236 (patch)
tree81d1eaa3e715737ab488220e59b6f91276cd587f /patches/server/0059-Add-exception-reporting-event.patch
parent4d6f28bab37881356eb1f667344b1a5fee842718 (diff)
downloadPaper-0edb5458e51e6a9f5be1fdb7016030409eaa6236.tar.gz
Paper-0edb5458e51e6a9f5be1fdb7016030409eaa6236.zip
Patching patches
Diffstat (limited to 'patches/server/0059-Add-exception-reporting-event.patch')
-rw-r--r--patches/server/0059-Add-exception-reporting-event.patch225
1 files changed, 225 insertions, 0 deletions
diff --git a/patches/server/0059-Add-exception-reporting-event.patch b/patches/server/0059-Add-exception-reporting-event.patch
new file mode 100644
index 0000000000..935dd3e71d
--- /dev/null
+++ b/patches/server/0059-Add-exception-reporting-event.patch
@@ -0,0 +1,225 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Joseph Hirschfeld <[email protected]>
+Date: Thu, 3 Mar 2016 03:15:41 -0600
+Subject: [PATCH] Add exception reporting event
+
+
+diff --git a/src/main/java/com/destroystokyo/paper/ServerSchedulerReportingWrapper.java b/src/main/java/com/destroystokyo/paper/ServerSchedulerReportingWrapper.java
+new file mode 100644
+index 0000000000000000000000000000000000000000..f699ce18ca044f813e194ef2786b7ea853ea86e7
+--- /dev/null
++++ b/src/main/java/com/destroystokyo/paper/ServerSchedulerReportingWrapper.java
+@@ -0,0 +1,38 @@
++package com.destroystokyo.paper;
++
++import com.google.common.base.Preconditions;
++import org.bukkit.craftbukkit.scheduler.CraftTask;
++import com.destroystokyo.paper.event.server.ServerExceptionEvent;
++import com.destroystokyo.paper.exception.ServerSchedulerException;
++
++/**
++ * Reporting wrapper to catch exceptions not natively
++ */
++public class ServerSchedulerReportingWrapper implements Runnable {
++
++ private final CraftTask internalTask;
++
++ public ServerSchedulerReportingWrapper(CraftTask internalTask) {
++ this.internalTask = Preconditions.checkNotNull(internalTask, "internalTask");
++ }
++
++ @Override
++ public void run() {
++ try {
++ internalTask.run();
++ } catch (RuntimeException e) {
++ internalTask.getOwner().getServer().getPluginManager().callEvent(
++ new ServerExceptionEvent(new ServerSchedulerException(e, internalTask))
++ );
++ throw e;
++ } catch (Throwable t) {
++ internalTask.getOwner().getServer().getPluginManager().callEvent(
++ new ServerExceptionEvent(new ServerSchedulerException(t, internalTask))
++ ); //Do not rethrow, since it is not permitted with Runnable#run
++ }
++ }
++
++ public CraftTask getInternalTask() {
++ return internalTask;
++ }
++}
+diff --git a/src/main/java/net/minecraft/server/players/OldUsersConverter.java b/src/main/java/net/minecraft/server/players/OldUsersConverter.java
+index 439ff01be1521c283d60cacb110fcb4993933057..da98f074ccd5a40c635824112c97fd174c393cb1 100644
+--- a/src/main/java/net/minecraft/server/players/OldUsersConverter.java
++++ b/src/main/java/net/minecraft/server/players/OldUsersConverter.java
+@@ -1,5 +1,6 @@
+ package net.minecraft.server.players;
+
++import com.destroystokyo.paper.exception.ServerInternalException;
+ import com.google.common.collect.Lists;
+ import com.google.common.collect.Maps;
+ import com.google.common.io.Files;
+@@ -363,6 +364,7 @@ public class OldUsersConverter {
+ root = NbtIo.readCompressed(new java.io.FileInputStream(file5));
+ } catch (Exception exception) {
+ exception.printStackTrace();
++ ServerInternalException.reportInternalException(exception); // Paper
+ }
+
+ if (root != null) {
+@@ -376,6 +378,7 @@ public class OldUsersConverter {
+ NbtIo.writeCompressed(root, new java.io.FileOutputStream(file2));
+ } catch (Exception exception) {
+ exception.printStackTrace();
++ ServerInternalException.reportInternalException(exception); // Paper
+ }
+ }
+ // CraftBukkit end
+diff --git a/src/main/java/net/minecraft/world/entity/ai/village/VillageSiege.java b/src/main/java/net/minecraft/world/entity/ai/village/VillageSiege.java
+index c6fb4c33d7ea52b88d8fc0d90748cbab7387c565..fed09b886f4fa0006d160e5f2abb00dfee45434d 100644
+--- a/src/main/java/net/minecraft/world/entity/ai/village/VillageSiege.java
++++ b/src/main/java/net/minecraft/world/entity/ai/village/VillageSiege.java
+@@ -118,6 +118,7 @@ public class VillageSiege implements CustomSpawner {
+ entityzombie.finalizeSpawn(world, world.getCurrentDifficultyAt(entityzombie.blockPosition()), MobSpawnType.EVENT, (SpawnGroupData) null, (CompoundTag) null);
+ } catch (Exception exception) {
+ VillageSiege.LOGGER.warn("Failed to create zombie for village siege at {}", vec3d, exception);
++ com.destroystokyo.paper.exception.ServerInternalException.reportInternalException(exception); // Paper
+ return;
+ }
+
+diff --git a/src/main/java/net/minecraft/world/level/Level.java b/src/main/java/net/minecraft/world/level/Level.java
+index a36da18ac1ea613f1a77ce2fbb70d5cb05563714..86fc83f6ea7bbf445edf097b6ab501a09ec18e2b 100644
+--- a/src/main/java/net/minecraft/world/level/Level.java
++++ b/src/main/java/net/minecraft/world/level/Level.java
+@@ -1,5 +1,10 @@
+ package net.minecraft.world.level;
+
++import co.aikar.timings.Timing;
++import co.aikar.timings.Timings;
++import com.destroystokyo.paper.event.server.ServerExceptionEvent;
++import com.destroystokyo.paper.exception.ServerInternalException;
++import com.google.common.base.MoreObjects;
+ import com.google.common.collect.Lists;
+ import com.mojang.serialization.Codec;
+ import java.io.IOException;
+@@ -730,6 +735,7 @@ public abstract class Level implements LevelAccessor, AutoCloseable {
+ // Paper start - Prevent tile entity and entity crashes
+ final String msg = String.format("Entity threw exception at %s:%s,%s,%s", entity.level.getWorld().getName(), entity.getX(), entity.getY(), entity.getZ());
+ MinecraftServer.LOGGER.error(msg, throwable);
++ getCraftServer().getPluginManager().callEvent(new ServerExceptionEvent(new ServerInternalException(msg, throwable)));
+ entity.discard();
+ // Paper end
+ }
+diff --git a/src/main/java/net/minecraft/world/level/NaturalSpawner.java b/src/main/java/net/minecraft/world/level/NaturalSpawner.java
+index 0e4f6893a2fce69782c4246c52e03926fe2df26f..5c58031279c0b74d2061c802e60b7bed50f27156 100644
+--- a/src/main/java/net/minecraft/world/level/NaturalSpawner.java
++++ b/src/main/java/net/minecraft/world/level/NaturalSpawner.java
+@@ -291,6 +291,7 @@ public final class NaturalSpawner {
+ NaturalSpawner.LOGGER.warn("Can't spawn entity of type: {}", BuiltInRegistries.ENTITY_TYPE.getKey(type));
+ } catch (Exception exception) {
+ NaturalSpawner.LOGGER.warn("Failed to create mob", exception);
++ com.destroystokyo.paper.exception.ServerInternalException.reportInternalException(exception); // Paper
+ }
+
+ return null;
+@@ -404,6 +405,7 @@ public final class NaturalSpawner {
+ entity = biomesettingsmobs_c.type.create(world.getLevel());
+ } catch (Exception exception) {
+ NaturalSpawner.LOGGER.warn("Failed to create mob", exception);
++ com.destroystokyo.paper.exception.ServerInternalException.reportInternalException(exception); // Paper
+ continue;
+ }
+
+diff --git a/src/main/java/net/minecraft/world/level/chunk/LevelChunk.java b/src/main/java/net/minecraft/world/level/chunk/LevelChunk.java
+index d11a715dccaaf2a2faeef8af9ff6e5f1914416cb..b78e89eed44a06bb8c7a8a62e561574d4dc4b2de 100644
+--- a/src/main/java/net/minecraft/world/level/chunk/LevelChunk.java
++++ b/src/main/java/net/minecraft/world/level/chunk/LevelChunk.java
+@@ -1,6 +1,7 @@
+ package net.minecraft.world.level.chunk;
+
+ import com.google.common.collect.ImmutableList;
++import com.destroystokyo.paper.exception.ServerInternalException;
+ import com.google.common.collect.Maps;
+ import com.google.common.collect.UnmodifiableIterator;
+ import com.mojang.logging.LogUtils;
+@@ -605,10 +606,16 @@ public class LevelChunk extends ChunkAccess {
+
+ // CraftBukkit start
+ } else {
+- System.out.println("Attempted to place a tile entity (" + blockEntity + ") at " + blockEntity.getBlockPos().getX() + "," + blockEntity.getBlockPos().getY() + "," + blockEntity.getBlockPos().getZ()
+- + " (" + this.getBlockState(blockposition) + ") where there was no entity tile!");
+- System.out.println("Chunk coordinates: " + (this.chunkPos.x * 16) + "," + (this.chunkPos.z * 16));
+- new Exception().printStackTrace();
++ // Paper start
++ ServerInternalException e = new ServerInternalException(
++ "Attempted to place a tile entity (" + blockEntity + ") at " + blockEntity.getBlockPos().getX() + ","
++ + blockEntity.getBlockPos().getY() + "," + blockEntity.getBlockPos().getZ()
++ + " (" + getBlockState(blockposition) + ") where there was no entity tile!\n" +
++ "Chunk coordinates: " + (this.chunkPos.x * 16) + "," + (this.chunkPos.z * 16) +
++ "\nWorld: " + level.getLevel().dimension().location());
++ e.printStackTrace();
++ ServerInternalException.reportInternalException(e);
++ // Paper end
+ // CraftBukkit end
+ }
+ }
+@@ -1187,6 +1194,7 @@ public class LevelChunk extends ChunkAccess {
+ // Paper start - Prevent tile entity and entity crashes
+ final String msg = String.format("BlockEntity threw exception at %s:%s,%s,%s", LevelChunk.this.getLevel().getWorld().getName(), this.getPos().getX(), this.getPos().getY(), this.getPos().getZ());
+ net.minecraft.server.MinecraftServer.LOGGER.error(msg, throwable);
++ net.minecraft.world.level.chunk.LevelChunk.this.level.getCraftServer().getPluginManager().callEvent(new com.destroystokyo.paper.event.server.ServerExceptionEvent(new ServerInternalException(msg, throwable)));
+ LevelChunk.this.removeBlockEntity(this.getPos());
+ // Paper end
+ // Spigot start
+diff --git a/src/main/java/net/minecraft/world/level/chunk/storage/RegionFile.java b/src/main/java/net/minecraft/world/level/chunk/storage/RegionFile.java
+index e68205fe7169c7c5b7c6fdada2ee97d86107ca97..aa8972fd1a1fade05d60ab69efb8ff24f344508a 100644
+--- a/src/main/java/net/minecraft/world/level/chunk/storage/RegionFile.java
++++ b/src/main/java/net/minecraft/world/level/chunk/storage/RegionFile.java
+@@ -275,6 +275,7 @@ public class RegionFile implements AutoCloseable {
+ return true;
+ }
+ } catch (IOException ioexception) {
++ com.destroystokyo.paper.exception.ServerInternalException.reportInternalException(ioexception); // Paper
+ return false;
+ }
+ }
+@@ -356,6 +357,7 @@ public class RegionFile implements AutoCloseable {
+ ((java.nio.Buffer) buf).position(5); // CraftBukkit - decompile error
+ filechannel.write(buf);
+ } catch (Throwable throwable) {
++ com.destroystokyo.paper.exception.ServerInternalException.reportInternalException(throwable); // Paper
+ if (filechannel != null) {
+ try {
+ filechannel.close();
+diff --git a/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java b/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java
+index 07c4d9cd5081378e1b903518f7174fca959cd9e3..dfc2789009fcaa08baa8054bdac915590b8701d6 100644
+--- a/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java
++++ b/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java
+@@ -17,6 +17,9 @@ import java.util.concurrent.atomic.AtomicReference;
+ import java.util.function.Consumer;
+ import java.util.function.IntUnaryOperator;
+ import java.util.logging.Level;
++import com.destroystokyo.paper.ServerSchedulerReportingWrapper;
++import com.destroystokyo.paper.event.server.ServerExceptionEvent;
++import com.destroystokyo.paper.exception.ServerSchedulerException;
+ import org.apache.commons.lang.Validate;
+ import org.bukkit.plugin.IllegalPluginAccessException;
+ import org.bukkit.plugin.Plugin;
+@@ -434,6 +437,8 @@ public class CraftScheduler implements BukkitScheduler {
+ msg,
+ throwable);
+ }
++ org.bukkit.Bukkit.getServer().getPluginManager().callEvent(
++ new ServerExceptionEvent(new ServerSchedulerException(msg, throwable, task)));
+ // Paper end
+ } finally {
+ this.currentTask = null;
+@@ -441,7 +446,7 @@ public class CraftScheduler implements BukkitScheduler {
+ this.parsePending();
+ } else {
+ this.debugTail = this.debugTail.setNext(new CraftAsyncDebugger(currentTick + CraftScheduler.RECENT_TICKS, task.getOwner(), task.getTaskClass()));
+- this.executor.execute(task);
++ this.executor.execute(new ServerSchedulerReportingWrapper(task)); // Paper
+ // We don't need to parse pending
+ // (async tasks must live with race-conditions if they attempt to cancel between these few lines of code)
+ }