aboutsummaryrefslogtreecommitdiffhomepage
path: root/patches/server/0154-handle-ServerboundKeepAlivePacket-async.patch
diff options
context:
space:
mode:
authorRiley Park <[email protected]>2024-05-15 17:06:59 -0700
committerGitHub <[email protected]>2024-05-15 17:06:59 -0700
commitf17519338bc589c045e0b32bfc37e048b23544d5 (patch)
treee50182ec698b4a9de8f366f485ee089b1901bbd9 /patches/server/0154-handle-ServerboundKeepAlivePacket-async.patch
parent3fc93581bb876e8149b2ca423375a98f5ca12d27 (diff)
downloadPaper-f17519338bc589c045e0b32bfc37e048b23544d5.tar.gz
Paper-f17519338bc589c045e0b32bfc37e048b23544d5.zip
Expose server build information (#10729)
* Expose server build information * squash patches * final tweaks --------- Co-authored-by: Jake Potrebic <[email protected]> Co-authored-by: masmc05 <[email protected]>
Diffstat (limited to 'patches/server/0154-handle-ServerboundKeepAlivePacket-async.patch')
-rw-r--r--patches/server/0154-handle-ServerboundKeepAlivePacket-async.patch41
1 files changed, 41 insertions, 0 deletions
diff --git a/patches/server/0154-handle-ServerboundKeepAlivePacket-async.patch b/patches/server/0154-handle-ServerboundKeepAlivePacket-async.patch
new file mode 100644
index 0000000000..b7fa733d4a
--- /dev/null
+++ b/patches/server/0154-handle-ServerboundKeepAlivePacket-async.patch
@@ -0,0 +1,41 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Shane Freeder <[email protected]>
+Date: Thu, 5 Oct 2017 01:54:07 +0100
+Subject: [PATCH] handle ServerboundKeepAlivePacket async
+
+In 1.12.2, Mojang moved the processing of ServerboundKeepAlivePacket off the main
+thread, while entirely correct for the server, this causes issues with
+plugins which are expecting the PlayerQuitEvent on the main thread.
+
+In order to counteract some bad behavior, we will post handling of the
+disconnection to the main thread, but leave the actual processing of the packet
+off the main thread.
+
+also adding some additional logging in order to help work out what is causing
+random disconnections for clients.
+
+diff --git a/src/main/java/net/minecraft/server/network/ServerCommonPacketListenerImpl.java b/src/main/java/net/minecraft/server/network/ServerCommonPacketListenerImpl.java
+index fc2fd0842e25fbe5c46ae07200c4b1a5950ae29a..8cc454ad3f6b865253bdd4902fbf19fc4a3e4a7f 100644
+--- a/src/main/java/net/minecraft/server/network/ServerCommonPacketListenerImpl.java
++++ b/src/main/java/net/minecraft/server/network/ServerCommonPacketListenerImpl.java
+@@ -116,14 +116,18 @@ public abstract class ServerCommonPacketListenerImpl implements ServerCommonPack
+
+ @Override
+ public void handleKeepAlive(ServerboundKeepAlivePacket packet) {
+- PacketUtils.ensureRunningOnSameThread(packet, this, this.player.serverLevel()); // CraftBukkit
++ //PacketUtils.ensureRunningOnSameThread(packet, this, this.player.serverLevel()); // CraftBukkit // Paper - handle ServerboundKeepAlivePacket async
+ if (this.keepAlivePending && packet.getId() == this.keepAliveChallenge) {
+ int i = (int) (Util.getMillis() - this.keepAliveTime);
+
+ this.latency = (this.latency * 3 + i) / 4;
+ this.keepAlivePending = false;
+ } else if (!this.isSingleplayerOwner()) {
+- this.disconnect(ServerCommonPacketListenerImpl.TIMEOUT_DISCONNECTION_MESSAGE);
++ // Paper start - This needs to be handled on the main thread for plugins
++ server.submit(() -> {
++ this.disconnect(ServerCommonPacketListenerImpl.TIMEOUT_DISCONNECTION_MESSAGE);
++ });
++ // Paper end - This needs to be handled on the main thread for plugins
+ }
+
+ }