aboutsummaryrefslogtreecommitdiffhomepage
path: root/patches/server/0675-Fix-cancelling-ProjectileHitEvent-for-piercing-arrow.patch
diff options
context:
space:
mode:
authorNewwind <[email protected]>2024-08-31 19:29:50 +0100
committerGitHub <[email protected]>2024-08-31 20:29:50 +0200
commit509ea2fd17fa03ce04f86046098607733b8767ba (patch)
tree3f7c9a29481fafbb6ad9f846839ec8f4863d2363 /patches/server/0675-Fix-cancelling-ProjectileHitEvent-for-piercing-arrow.patch
parente01ddf46279fbb68d157749a906b7a2ecc60da1a (diff)
downloadPaper-509ea2fd17fa03ce04f86046098607733b8767ba.tar.gz
Paper-509ea2fd17fa03ce04f86046098607733b8767ba.zip
Fix horse armor desync (#11341)
Diffstat (limited to 'patches/server/0675-Fix-cancelling-ProjectileHitEvent-for-piercing-arrow.patch')
-rw-r--r--patches/server/0675-Fix-cancelling-ProjectileHitEvent-for-piercing-arrow.patch40
1 files changed, 40 insertions, 0 deletions
diff --git a/patches/server/0675-Fix-cancelling-ProjectileHitEvent-for-piercing-arrow.patch b/patches/server/0675-Fix-cancelling-ProjectileHitEvent-for-piercing-arrow.patch
new file mode 100644
index 0000000000..4698298019
--- /dev/null
+++ b/patches/server/0675-Fix-cancelling-ProjectileHitEvent-for-piercing-arrow.patch
@@ -0,0 +1,40 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Jake Potrebic <[email protected]>
+Date: Sat, 19 Feb 2022 19:05:59 -0800
+Subject: [PATCH] Fix cancelling ProjectileHitEvent for piercing arrows
+
+Piercing arrows search for multiple entities inside a while
+loop that is checking the projectile entity's removed state.
+If the hit event is cancelled on the first entity, the event will
+be called over and over again inside that while loop until the event
+is not cancelled. The solution here, is to make use of an
+already-existing field on AbstractArrow for tracking entities hit by
+piercing arrows to avoid duplicate damage being applied.
+
+== AT ==
+protected net.minecraft.world.entity.projectile.Projectile hitCancelled
+
+diff --git a/src/main/java/net/minecraft/world/entity/projectile/AbstractArrow.java b/src/main/java/net/minecraft/world/entity/projectile/AbstractArrow.java
+index 57ebb96707748e90810dc07471f9769f1317df9d..10d30304c8c89b1f2a55be8529035311d1424e44 100644
+--- a/src/main/java/net/minecraft/world/entity/projectile/AbstractArrow.java
++++ b/src/main/java/net/minecraft/world/entity/projectile/AbstractArrow.java
+@@ -329,6 +329,19 @@ public abstract class AbstractArrow extends Projectile {
+ }
+ }
+
++ // Paper start - Fix cancelling ProjectileHitEvent for piercing arrows
++ @Override
++ public ProjectileDeflection preHitTargetOrDeflectSelf(HitResult hitResult) {
++ if (hitResult instanceof EntityHitResult entityHitResult && this.hitCancelled && this.getPierceLevel() > 0) {
++ if (this.piercingIgnoreEntityIds == null) {
++ this.piercingIgnoreEntityIds = new IntOpenHashSet(5);
++ }
++ this.piercingIgnoreEntityIds.add(entityHitResult.getEntity().getId());
++ }
++ return super.preHitTargetOrDeflectSelf(hitResult);
++ }
++ // Paper end - Fix cancelling ProjectileHitEvent for piercing arrows
++
+ @Override
+ protected double getDefaultGravity() {
+ return 0.05D;