aboutsummaryrefslogtreecommitdiffhomepage
path: root/patches/server/0909-Fix-several-issues-with-EntityBreedEvent.patch
diff options
context:
space:
mode:
authorSpottedleaf <[email protected]>2024-07-17 10:24:53 -0700
committerSpottedleaf <[email protected]>2024-07-17 10:28:32 -0700
commit00b949f1bbbf444e2b5e7b8de7c9b14fbd2133c6 (patch)
tree82639515bc5e9ae00c1e639e72137ed51e1ac688 /patches/server/0909-Fix-several-issues-with-EntityBreedEvent.patch
parent967f98aa81da851740aeb429778e46159fd188df (diff)
downloadPaper-00b949f1bbbf444e2b5e7b8de7c9b14fbd2133c6.tar.gz
Paper-00b949f1bbbf444e2b5e7b8de7c9b14fbd2133c6.zip
Remove Moonrise utils to MCUtils, remove duplicated/unused utils
Diffstat (limited to 'patches/server/0909-Fix-several-issues-with-EntityBreedEvent.patch')
-rw-r--r--patches/server/0909-Fix-several-issues-with-EntityBreedEvent.patch133
1 files changed, 133 insertions, 0 deletions
diff --git a/patches/server/0909-Fix-several-issues-with-EntityBreedEvent.patch b/patches/server/0909-Fix-several-issues-with-EntityBreedEvent.patch
new file mode 100644
index 0000000000..6a97d9fb9e
--- /dev/null
+++ b/patches/server/0909-Fix-several-issues-with-EntityBreedEvent.patch
@@ -0,0 +1,133 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Jake Potrebic <[email protected]>
+Date: Thu, 15 Dec 2022 00:14:44 -0800
+Subject: [PATCH] Fix several issues with EntityBreedEvent
+
+Upstream did not account for different hands when storing
+the breed item for later use in the event. Also they only
+stored a reference to the stack, not a copy so if the stack
+changed after love mode was started, the breed item in the event
+also changed. Also in several places, the breed item was stored after
+it was decreased by one to consume the item.
+
+diff --git a/src/main/java/net/minecraft/world/entity/animal/Animal.java b/src/main/java/net/minecraft/world/entity/animal/Animal.java
+index b46352b328178df2a48d1c9e895bed3fabd2c292..1808e1b01afa3041a54c9c9a7586d4d61960527a 100644
+--- a/src/main/java/net/minecraft/world/entity/animal/Animal.java
++++ b/src/main/java/net/minecraft/world/entity/animal/Animal.java
+@@ -148,8 +148,9 @@ public abstract class Animal extends AgeableMob {
+ int i = this.getAge();
+
+ if (!this.level().isClientSide && i == 0 && this.canFallInLove()) {
++ final ItemStack breedCopy = itemstack.copy(); // Paper - Fix EntityBreedEvent copying
+ this.usePlayerItem(player, hand, itemstack);
+- this.setInLove(player);
++ this.setInLove(player, breedCopy); // Paper - Fix EntityBreedEvent copying
+ return InteractionResult.SUCCESS;
+ }
+
+@@ -175,10 +176,18 @@ public abstract class Animal extends AgeableMob {
+ return this.inLove <= 0;
+ }
+
++ @Deprecated @io.papermc.paper.annotation.DoNotUse // Paper - Fix EntityBreedEvent copying
+ public void setInLove(@Nullable Player player) {
++ // Paper start - Fix EntityBreedEvent copying
++ this.setInLove(player, null);
++ }
++ public void setInLove(@Nullable Player player, @Nullable ItemStack breedItemCopy) {
++ if (breedItemCopy != null) this.breedItem = breedItemCopy;
++ // Paper end - Fix EntityBreedEvent copying
+ // CraftBukkit start
+ EntityEnterLoveModeEvent entityEnterLoveModeEvent = CraftEventFactory.callEntityEnterLoveModeEvent(player, this, 600);
+ if (entityEnterLoveModeEvent.isCancelled()) {
++ this.breedItem = null; // Paper - Fix EntityBreedEvent copying; clear if cancelled
+ return;
+ }
+ this.inLove = entityEnterLoveModeEvent.getTicksInLove();
+@@ -186,7 +195,7 @@ public abstract class Animal extends AgeableMob {
+ if (player != null) {
+ this.loveCause = player.getUUID();
+ }
+- this.breedItem = player.getInventory().getSelected(); // CraftBukkit
++ // Paper - Fix EntityBreedEvent copying; set breed item in better place
+
+ this.level().broadcastEntityEvent(this, (byte) 18);
+ }
+diff --git a/src/main/java/net/minecraft/world/entity/animal/Panda.java b/src/main/java/net/minecraft/world/entity/animal/Panda.java
+index 293d6891948e99ac9bd741008f7dcbc5fc1a2e3d..e108f876d3f129c6287f13d68427aed2a6f0c5b1 100644
+--- a/src/main/java/net/minecraft/world/entity/animal/Panda.java
++++ b/src/main/java/net/minecraft/world/entity/animal/Panda.java
+@@ -673,8 +673,9 @@ public class Panda extends Animal {
+ this.usePlayerItem(player, hand, itemstack);
+ this.ageUp((int) ((float) (-this.getAge() / 20) * 0.1F), true);
+ } else if (!this.level().isClientSide && this.getAge() == 0 && this.canFallInLove()) {
++ final ItemStack breedCopy = itemstack.copy(); // Paper - Fix EntityBreedEvent copying
+ this.usePlayerItem(player, hand, itemstack);
+- this.setInLove(player);
++ this.setInLove(player, breedCopy); // Paper - Fix EntityBreedEvent copying
+ } else {
+ if (this.level().isClientSide || this.isSitting() || this.isInWater()) {
+ return InteractionResult.PASS;
+diff --git a/src/main/java/net/minecraft/world/entity/animal/armadillo/Armadillo.java b/src/main/java/net/minecraft/world/entity/animal/armadillo/Armadillo.java
+index 4eb305bc77767531efb6f9d299216248d4ee39d2..729fd2d52dd48e25ee7a077a3ffafc80ecef7c9f 100644
+--- a/src/main/java/net/minecraft/world/entity/animal/armadillo/Armadillo.java
++++ b/src/main/java/net/minecraft/world/entity/animal/armadillo/Armadillo.java
+@@ -352,8 +352,8 @@ public class Armadillo extends Animal {
+ }
+
+ @Override
+- public void setInLove(@Nullable Player player) {
+- super.setInLove(player);
++ public void setInLove(@Nullable Player player, @Nullable ItemStack breedItemCopy) { // Paper
++ super.setInLove(player, breedItemCopy); // Paper
+ this.makeSound(SoundEvents.ARMADILLO_EAT);
+ }
+
+diff --git a/src/main/java/net/minecraft/world/entity/animal/camel/Camel.java b/src/main/java/net/minecraft/world/entity/animal/camel/Camel.java
+index 0388b09e1c4f03958384680ed487792a54007463..8941752e4600ccd11b3fa1147b2e414785589eed 100644
+--- a/src/main/java/net/minecraft/world/entity/animal/camel/Camel.java
++++ b/src/main/java/net/minecraft/world/entity/animal/camel/Camel.java
+@@ -393,7 +393,7 @@ public class Camel extends AbstractHorse implements PlayerRideableJumping, Saddl
+ boolean flag1 = this.isTamed() && this.getAge() == 0 && this.canFallInLove();
+
+ if (flag1) {
+- this.setInLove(player);
++ this.setInLove(player, item.copy()); // Paper - Fix EntityBreedEvent copying
+ }
+
+ boolean flag2 = this.isBaby();
+diff --git a/src/main/java/net/minecraft/world/entity/animal/horse/AbstractHorse.java b/src/main/java/net/minecraft/world/entity/animal/horse/AbstractHorse.java
+index f1e43254936feedfe0ffbf77071505f3a65e5053..1f5ed236fb7c0c1b0181675747d25d233f534284 100644
+--- a/src/main/java/net/minecraft/world/entity/animal/horse/AbstractHorse.java
++++ b/src/main/java/net/minecraft/world/entity/animal/horse/AbstractHorse.java
+@@ -572,7 +572,7 @@ public abstract class AbstractHorse extends Animal implements ContainerListener,
+ b0 = 5;
+ if (!this.level().isClientSide && this.isTamed() && this.getAge() == 0 && !this.isInLove()) {
+ flag = true;
+- this.setInLove(player);
++ this.setInLove(player, item.copy()); // Paper - Fix EntityBreedEvent copying
+ }
+ } else if (item.is(Items.GOLDEN_APPLE) || item.is(Items.ENCHANTED_GOLDEN_APPLE)) {
+ f = 10.0F;
+@@ -580,7 +580,7 @@ public abstract class AbstractHorse extends Animal implements ContainerListener,
+ b0 = 10;
+ if (!this.level().isClientSide && this.isTamed() && this.getAge() == 0 && !this.isInLove()) {
+ flag = true;
+- this.setInLove(player);
++ this.setInLove(player, item.copy()); // Paper - Fix EntityBreedEvent copying
+ }
+ }
+
+diff --git a/src/main/java/net/minecraft/world/entity/animal/horse/Llama.java b/src/main/java/net/minecraft/world/entity/animal/horse/Llama.java
+index 82c57124433cc033c99e609e8ad71e03d340bc5e..cf6a3a63b6f2b96943c0f399e8c82d293fee31ba 100644
+--- a/src/main/java/net/minecraft/world/entity/animal/horse/Llama.java
++++ b/src/main/java/net/minecraft/world/entity/animal/horse/Llama.java
+@@ -179,7 +179,7 @@ public class Llama extends AbstractChestedHorse implements VariantHolder<Llama.V
+ f = 10.0F;
+ if (this.isTamed() && this.getAge() == 0 && this.canFallInLove()) {
+ flag = true;
+- this.setInLove(player);
++ this.setInLove(player, item.copy()); // Paper - Fix EntityBreedEvent copying
+ }
+ }
+