aboutsummaryrefslogtreecommitdiffhomepage
path: root/patches/server/0071-Default-loading-permissions.yml-before-plugins.patch
diff options
context:
space:
mode:
Diffstat (limited to 'patches/server/0071-Default-loading-permissions.yml-before-plugins.patch')
-rw-r--r--patches/server/0071-Default-loading-permissions.yml-before-plugins.patch38
1 files changed, 38 insertions, 0 deletions
diff --git a/patches/server/0071-Default-loading-permissions.yml-before-plugins.patch b/patches/server/0071-Default-loading-permissions.yml-before-plugins.patch
new file mode 100644
index 0000000000..339b9641c0
--- /dev/null
+++ b/patches/server/0071-Default-loading-permissions.yml-before-plugins.patch
@@ -0,0 +1,38 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Aikar <[email protected]>
+Date: Fri, 18 Mar 2016 13:17:38 -0400
+Subject: [PATCH] Default loading permissions.yml before plugins
+
+Under previous behavior, plugins were not able to check if a player had a permission
+if it was defined in permissions.yml. there is no clean way for a plugin to fix that either.
+
+This will change the order so that by default, permissions.yml loads BEFORE plugins instead of after.
+
+This gives plugins expected permission checks.
+
+It also helps improve the expected logic, as servers should set the initial defaults, and then let plugins
+modify that. Under the previous logic, plugins were unable (cleanly) override permissions.yml.
+
+A config option has been added for those who depend on the previous behavior, but I don't expect that.
+
+diff --git a/src/main/java/org/bukkit/craftbukkit/CraftServer.java b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
+index 8461eb0ad3531cab7aa50226008a960937830fce..c9476989d21798713c65b4f0a580bde0a4457c21 100644
+--- a/src/main/java/org/bukkit/craftbukkit/CraftServer.java
++++ b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
+@@ -458,6 +458,7 @@ public final class CraftServer implements Server {
+ if (type == PluginLoadOrder.STARTUP) {
+ this.helpMap.clear();
+ this.helpMap.initializeGeneralTopics();
++ if (io.papermc.paper.configuration.GlobalConfiguration.get().misc.loadPermissionsYmlBeforePlugins) loadCustomPermissions(); // Paper
+ }
+
+ Plugin[] plugins = this.pluginManager.getPlugins();
+@@ -477,7 +478,7 @@ public final class CraftServer implements Server {
+ this.commandMap.registerServerAliases();
+ DefaultPermissions.registerCorePermissions();
+ CraftDefaultPermissions.registerCorePermissions();
+- this.loadCustomPermissions();
++ if (!io.papermc.paper.configuration.GlobalConfiguration.get().misc.loadPermissionsYmlBeforePlugins) this.loadCustomPermissions(); // Paper
+ this.helpMap.initializeCommands();
+ this.syncCommands();
+ }