aboutsummaryrefslogtreecommitdiffhomepage
path: root/patches/server/0102-Avoid-blocking-on-Network-Manager-creation.patch
diff options
context:
space:
mode:
Diffstat (limited to 'patches/server/0102-Avoid-blocking-on-Network-Manager-creation.patch')
-rw-r--r--patches/server/0102-Avoid-blocking-on-Network-Manager-creation.patch45
1 files changed, 45 insertions, 0 deletions
diff --git a/patches/server/0102-Avoid-blocking-on-Network-Manager-creation.patch b/patches/server/0102-Avoid-blocking-on-Network-Manager-creation.patch
new file mode 100644
index 0000000000..1c6ee84de8
--- /dev/null
+++ b/patches/server/0102-Avoid-blocking-on-Network-Manager-creation.patch
@@ -0,0 +1,45 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Aikar <[email protected]>
+Date: Mon, 16 May 2016 23:19:16 -0400
+Subject: [PATCH] Avoid blocking on Network Manager creation
+
+Per Paper issue 294
+
+diff --git a/src/main/java/net/minecraft/server/network/ServerConnectionListener.java b/src/main/java/net/minecraft/server/network/ServerConnectionListener.java
+index 2cf3e79ec5e8706b71d27ebad4668773f0b91195..64119f2188f8958b8a5913fec82ac5bba1b74b2a 100644
+--- a/src/main/java/net/minecraft/server/network/ServerConnectionListener.java
++++ b/src/main/java/net/minecraft/server/network/ServerConnectionListener.java
+@@ -61,6 +61,15 @@ public class ServerConnectionListener {
+ public volatile boolean running;
+ private final List<ChannelFuture> channels = Collections.synchronizedList(Lists.newArrayList());
+ final List<Connection> connections = Collections.synchronizedList(Lists.newArrayList());
++ // Paper start - prevent blocking on adding a new connection while the server is ticking
++ private final java.util.Queue<Connection> pending = new java.util.concurrent.ConcurrentLinkedQueue<>();
++ private final void addPending() {
++ Connection connection;
++ while ((connection = pending.poll()) != null) {
++ connections.add(connection);
++ }
++ }
++ // Paper end - prevent blocking on adding a new connection while the server is ticking
+
+ public ServerConnectionListener(MinecraftServer server) {
+ this.server = server;
+@@ -102,7 +111,8 @@ public class ServerConnectionListener {
+ int j = ServerConnectionListener.this.server.getRateLimitPacketsPerSecond();
+ Connection object = j > 0 ? new RateKickingConnection(j) : new Connection(PacketFlow.SERVERBOUND); // CraftBukkit - decompile error
+
+- ServerConnectionListener.this.connections.add(object);
++ //ServerConnectionListener.this.connections.add(object); // Paper
++ pending.add(object); // Paper - prevent blocking on adding a new connection while the server is ticking
+ ((Connection) object).configurePacketHandler(channelpipeline);
+ ((Connection) object).setListenerForServerboundHandshake(new ServerHandshakePacketListenerImpl(ServerConnectionListener.this.server, (Connection) object));
+ }
+@@ -164,6 +174,7 @@ public class ServerConnectionListener {
+
+ synchronized (this.connections) {
+ // Spigot Start
++ this.addPending(); // Paper - prevent blocking on adding a new connection while the server is ticking
+ // This prevents players from 'gaming' the server, and strategically relogging to increase their position in the tick order
+ if ( org.spigotmc.SpigotConfig.playerShuffle > 0 && MinecraftServer.currentTick % org.spigotmc.SpigotConfig.playerShuffle == 0 )
+ {