aboutsummaryrefslogtreecommitdiffhomepage
path: root/patches/server/0127-Remove-CraftScheduler-Async-Task-Debugger.patch
diff options
context:
space:
mode:
Diffstat (limited to 'patches/server/0127-Remove-CraftScheduler-Async-Task-Debugger.patch')
-rw-r--r--patches/server/0127-Remove-CraftScheduler-Async-Task-Debugger.patch48
1 files changed, 48 insertions, 0 deletions
diff --git a/patches/server/0127-Remove-CraftScheduler-Async-Task-Debugger.patch b/patches/server/0127-Remove-CraftScheduler-Async-Task-Debugger.patch
new file mode 100644
index 0000000000..721f748db6
--- /dev/null
+++ b/patches/server/0127-Remove-CraftScheduler-Async-Task-Debugger.patch
@@ -0,0 +1,48 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Aikar <[email protected]>
+Date: Sun, 5 Feb 2017 00:04:04 -0500
+Subject: [PATCH] Remove CraftScheduler Async Task Debugger
+
+I have not once ever seen this system help debug a crash.
+One report of a suspected memory leak with the system.
+
+This adds additional overhead to asynchronous task dispatching
+
+diff --git a/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java b/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java
+index dc7872afbdd06eb976bee6aee56a40b44084c24a..af3997e47aff9c43dc5019f1b0267effe1df5205 100644
+--- a/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java
++++ b/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java
+@@ -444,7 +444,7 @@ public class CraftScheduler implements BukkitScheduler {
+ }
+ this.parsePending();
+ } else {
+- this.debugTail = this.debugTail.setNext(new CraftAsyncDebugger(currentTick + CraftScheduler.RECENT_TICKS, task.getOwner(), task.getTaskClass()));
++ // this.debugTail = this.debugTail.setNext(new CraftAsyncDebugger(currentTick + CraftScheduler.RECENT_TICKS, task.getOwner(), task.getTaskClass())); // Paper
+ this.executor.execute(new com.destroystokyo.paper.ServerSchedulerReportingWrapper(task)); // Paper
+ // We don't need to parse pending
+ // (async tasks must live with race-conditions if they attempt to cancel between these few lines of code)
+@@ -461,7 +461,7 @@ public class CraftScheduler implements BukkitScheduler {
+ this.pending.addAll(temp);
+ temp.clear();
+ MinecraftTimings.bukkitSchedulerFinishTimer.stopTiming(); // Paper
+- this.debugHead = this.debugHead.getNextHead(currentTick);
++ //this.debugHead = this.debugHead.getNextHead(currentTick); // Paper
+ }
+
+ private void addTask(final CraftTask task) {
+@@ -525,10 +525,15 @@ public class CraftScheduler implements BukkitScheduler {
+
+ @Override
+ public String toString() {
++ // Paper start
++ return "";
++ /*
+ int debugTick = this.currentTick;
+ StringBuilder string = new StringBuilder("Recent tasks from ").append(debugTick - CraftScheduler.RECENT_TICKS).append('-').append(debugTick).append('{');
+ this.debugHead.debugTo(string);
+ return string.append('}').toString();
++ */
++ // Paper end
+ }
+
+ @Deprecated