aboutsummaryrefslogtreecommitdiffhomepage
path: root/patches/server/0206-InventoryCloseEvent-Reason-API.patch
diff options
context:
space:
mode:
Diffstat (limited to 'patches/server/0206-InventoryCloseEvent-Reason-API.patch')
-rw-r--r--patches/server/0206-InventoryCloseEvent-Reason-API.patch212
1 files changed, 212 insertions, 0 deletions
diff --git a/patches/server/0206-InventoryCloseEvent-Reason-API.patch b/patches/server/0206-InventoryCloseEvent-Reason-API.patch
new file mode 100644
index 0000000000..39b8f269e4
--- /dev/null
+++ b/patches/server/0206-InventoryCloseEvent-Reason-API.patch
@@ -0,0 +1,212 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Aikar <[email protected]>
+Date: Tue, 3 Jul 2018 21:56:23 -0400
+Subject: [PATCH] InventoryCloseEvent Reason API
+
+Allows you to determine why an inventory was closed, enabling plugin developers
+to "confirm" things based on if it was player triggered close or not.
+
+diff --git a/src/main/java/net/minecraft/server/level/ServerLevel.java b/src/main/java/net/minecraft/server/level/ServerLevel.java
+index 74f7467caf7d86011f0b8aea7a8c1f5c644f690a..99db41834d7e8fb8fbbe83bd70a4b8d7c016c3e2 100644
+--- a/src/main/java/net/minecraft/server/level/ServerLevel.java
++++ b/src/main/java/net/minecraft/server/level/ServerLevel.java
+@@ -1210,7 +1210,7 @@ public class ServerLevel extends Level implements ServerEntityGetter, WorldGenLe
+ for (net.minecraft.world.level.block.entity.BlockEntity tileentity : chunk.getBlockEntities().values()) {
+ if (tileentity instanceof net.minecraft.world.Container) {
+ for (org.bukkit.entity.HumanEntity h : Lists.newArrayList(((net.minecraft.world.Container) tileentity).getViewers())) {
+- h.closeInventory();
++ h.closeInventory(org.bukkit.event.inventory.InventoryCloseEvent.Reason.UNLOADED); // Paper - Inventory close reason
+ }
+ }
+ }
+@@ -2260,7 +2260,7 @@ public class ServerLevel extends Level implements ServerEntityGetter, WorldGenLe
+ // Spigot Start
+ if (entity.getBukkitEntity() instanceof org.bukkit.inventory.InventoryHolder && (!(entity instanceof ServerPlayer) || entity.getRemovalReason() != Entity.RemovalReason.KILLED)) { // SPIGOT-6876: closeInventory clears death message
+ for (org.bukkit.entity.HumanEntity h : Lists.newArrayList(((org.bukkit.inventory.InventoryHolder) entity.getBukkitEntity()).getInventory().getViewers())) {
+- h.closeInventory();
++ h.closeInventory(org.bukkit.event.inventory.InventoryCloseEvent.Reason.UNLOADED); // Paper - Inventory close reason
+ }
+ }
+ // Spigot End
+diff --git a/src/main/java/net/minecraft/server/level/ServerPlayer.java b/src/main/java/net/minecraft/server/level/ServerPlayer.java
+index 1ebd8d20e510b7af2cdf461fff9eb949a0017ae6..0a5aeb9b50dfec3b791040348f6a9e929ef8e59c 100644
+--- a/src/main/java/net/minecraft/server/level/ServerPlayer.java
++++ b/src/main/java/net/minecraft/server/level/ServerPlayer.java
+@@ -930,7 +930,7 @@ public class ServerPlayer extends net.minecraft.world.entity.player.Player {
+ }
+ // Paper end - Configurable container update tick rate
+ if (!this.containerMenu.stillValid(this)) {
+- this.closeContainer();
++ this.closeContainer(org.bukkit.event.inventory.InventoryCloseEvent.Reason.CANT_USE); // Paper - Inventory close reason
+ this.containerMenu = this.inventoryMenu;
+ }
+
+@@ -1182,7 +1182,7 @@ public class ServerPlayer extends net.minecraft.world.entity.player.Player {
+
+ // SPIGOT-943 - only call if they have an inventory open
+ if (this.containerMenu != this.inventoryMenu) {
+- this.closeContainer();
++ this.closeContainer(org.bukkit.event.inventory.InventoryCloseEvent.Reason.DEATH); // Paper - Inventory close reason
+ }
+
+ net.kyori.adventure.text.Component deathMessage = event.deathMessage() != null ? event.deathMessage() : net.kyori.adventure.text.Component.empty(); // Paper - Adventure
+@@ -1842,7 +1842,7 @@ public class ServerPlayer extends net.minecraft.world.entity.player.Player {
+ }
+ // CraftBukkit end
+ if (this.containerMenu != this.inventoryMenu) {
+- this.closeContainer();
++ this.closeContainer(org.bukkit.event.inventory.InventoryCloseEvent.Reason.OPEN_NEW); // Paper - Inventory close reason
+ }
+
+ // this.nextContainerCounter(); // CraftBukkit - moved up
+@@ -1872,7 +1872,13 @@ public class ServerPlayer extends net.minecraft.world.entity.player.Player {
+
+ @Override
+ public void closeContainer() {
+- CraftEventFactory.handleInventoryCloseEvent(this); // CraftBukkit
++ // Paper start - Inventory close reason
++ this.closeContainer(org.bukkit.event.inventory.InventoryCloseEvent.Reason.UNKNOWN);
++ }
++ @Override
++ public void closeContainer(org.bukkit.event.inventory.InventoryCloseEvent.Reason reason) {
++ CraftEventFactory.handleInventoryCloseEvent(this, reason); // CraftBukkit
++ // Paper end - Inventory close reason
+ this.connection.send(new ClientboundContainerClosePacket(this.containerMenu.containerId));
+ this.doCloseContainer();
+ }
+diff --git a/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java b/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
+index f2b6162562a2f35c8f610c9386172984ae30bf17..b4edc64f3eacdbfb6187106989d190303b0541ac 100644
+--- a/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
++++ b/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
+@@ -2714,10 +2714,15 @@ public class ServerGamePacketListenerImpl extends ServerCommonPacketListenerImpl
+
+ @Override
+ public void handleContainerClose(ServerboundContainerClosePacket packet) {
++ // Paper start - Inventory close reason
++ this.handleContainerClose(packet, org.bukkit.event.inventory.InventoryCloseEvent.Reason.PLAYER);
++ }
++ public void handleContainerClose(ServerboundContainerClosePacket packet, org.bukkit.event.inventory.InventoryCloseEvent.Reason reason) {
++ // Paper end - Inventory close reason
+ PacketUtils.ensureRunningOnSameThread(packet, this, this.player.serverLevel());
+
+ if (this.player.isImmobile()) return; // CraftBukkit
+- CraftEventFactory.handleInventoryCloseEvent(this.player); // CraftBukkit
++ CraftEventFactory.handleInventoryCloseEvent(this.player, reason); // CraftBukkit // Paper
+
+ this.player.doCloseContainer();
+ }
+diff --git a/src/main/java/net/minecraft/server/players/PlayerList.java b/src/main/java/net/minecraft/server/players/PlayerList.java
+index ac5607fb1ac771f16b14d71e08a8d4183a39a002..06338f5fa552a390db05a90b5cc796a70104ada0 100644
+--- a/src/main/java/net/minecraft/server/players/PlayerList.java
++++ b/src/main/java/net/minecraft/server/players/PlayerList.java
+@@ -468,7 +468,7 @@ public abstract class PlayerList {
+ // CraftBukkit start - Quitting must be before we do final save of data, in case plugins need to modify it
+ // See SPIGOT-5799, SPIGOT-6145
+ if (entityplayer.containerMenu != entityplayer.inventoryMenu) {
+- entityplayer.closeContainer();
++ entityplayer.closeContainer(org.bukkit.event.inventory.InventoryCloseEvent.Reason.DISCONNECT); // Paper - Inventory close reason
+ }
+
+ PlayerQuitEvent playerQuitEvent = new PlayerQuitEvent(entityplayer.getBukkitEntity(), net.kyori.adventure.text.Component.translatable("multiplayer.player.left", net.kyori.adventure.text.format.NamedTextColor.YELLOW, io.papermc.paper.configuration.GlobalConfiguration.get().messages.useDisplayNameInQuitMessage ? entityplayer.getBukkitEntity().displayName() : io.papermc.paper.adventure.PaperAdventure.asAdventure(entityplayer.getDisplayName()))); // Paper - Adventure
+diff --git a/src/main/java/net/minecraft/world/entity/player/Player.java b/src/main/java/net/minecraft/world/entity/player/Player.java
+index 02d8ada43669134695e7edcf33fdac4599969f9d..833e2b338671b81401409fc390ab1515f3520442 100644
+--- a/src/main/java/net/minecraft/world/entity/player/Player.java
++++ b/src/main/java/net/minecraft/world/entity/player/Player.java
+@@ -282,7 +282,7 @@ public abstract class Player extends LivingEntity {
+ this.updateIsUnderwater();
+ super.tick();
+ if (!this.level().isClientSide && this.containerMenu != null && !this.containerMenu.stillValid(this)) {
+- this.closeContainer();
++ this.closeContainer(org.bukkit.event.inventory.InventoryCloseEvent.Reason.CANT_USE); // Paper - Inventory close reason
+ this.containerMenu = this.inventoryMenu;
+ }
+
+@@ -534,6 +534,13 @@ public abstract class Player extends LivingEntity {
+
+ }
+
++ // Paper start - Inventory close reason; unused code, but to keep signatures aligned
++ public void closeContainer(org.bukkit.event.inventory.InventoryCloseEvent.Reason reason) {
++ closeContainer();
++ this.containerMenu = this.inventoryMenu;
++ }
++ // Paper end - Inventory close reason
++
+ public void closeContainer() {
+ this.containerMenu = this.inventoryMenu;
+ }
+diff --git a/src/main/java/org/bukkit/craftbukkit/entity/CraftHumanEntity.java b/src/main/java/org/bukkit/craftbukkit/entity/CraftHumanEntity.java
+index 6d4e0a90c70f7a66450cbb18ebec1d7bf9200af2..5ff159be1a6dfb4b1a5b9aa1e435d294f205215e 100644
+--- a/src/main/java/org/bukkit/craftbukkit/entity/CraftHumanEntity.java
++++ b/src/main/java/org/bukkit/craftbukkit/entity/CraftHumanEntity.java
+@@ -387,7 +387,7 @@ public class CraftHumanEntity extends CraftLivingEntity implements HumanEntity {
+ if (((ServerPlayer) this.getHandle()).connection == null) return;
+ if (this.getHandle().containerMenu != this.getHandle().inventoryMenu) {
+ // fire INVENTORY_CLOSE if one already open
+- ((ServerPlayer) this.getHandle()).connection.handleContainerClose(new ServerboundContainerClosePacket(this.getHandle().containerMenu.containerId));
++ ((ServerPlayer) this.getHandle()).connection.handleContainerClose(new ServerboundContainerClosePacket(this.getHandle().containerMenu.containerId), org.bukkit.event.inventory.InventoryCloseEvent.Reason.OPEN_NEW); // Paper - Inventory close reason
+ }
+ ServerPlayer player = (ServerPlayer) this.getHandle();
+ AbstractContainerMenu container;
+@@ -457,8 +457,14 @@ public class CraftHumanEntity extends CraftLivingEntity implements HumanEntity {
+
+ @Override
+ public void closeInventory() {
+- this.getHandle().closeContainer();
++ // Paper start - Inventory close reason
++ this.getHandle().closeContainer(org.bukkit.event.inventory.InventoryCloseEvent.Reason.PLUGIN);
+ }
++ @Override
++ public void closeInventory(org.bukkit.event.inventory.InventoryCloseEvent.Reason reason) {
++ getHandle().closeContainer(reason);
++ }
++ // Paper end - Inventory close reason
+
+ @Override
+ public boolean isBlocking() {
+diff --git a/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java b/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
+index 6538a3ee384b36774480bc49c702102e5d0b7762..c76f5d21d6bc5c25b43503ebb0cbdd9f8f984743 100644
+--- a/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
++++ b/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
+@@ -1278,7 +1278,7 @@ public class CraftPlayer extends CraftHumanEntity implements Player {
+
+ // Close any foreign inventory
+ if (this.getHandle().containerMenu != this.getHandle().inventoryMenu) {
+- this.getHandle().closeContainer();
++ this.getHandle().closeContainer(org.bukkit.event.inventory.InventoryCloseEvent.Reason.TELEPORT); // Paper - Inventory close reason
+ }
+
+ // Check if the fromWorld and toWorld are the same.
+diff --git a/src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java b/src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java
+index 60a16ac62a27a92b763bf90e72fab4ed01aeb592..41c6a7260317ed575a3320ac36b0f2be22c120aa 100644
+--- a/src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java
++++ b/src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java
+@@ -1281,7 +1281,7 @@ public class CraftEventFactory {
+
+ public static AbstractContainerMenu callInventoryOpenEvent(ServerPlayer player, AbstractContainerMenu container, boolean cancelled) {
+ if (player.containerMenu != player.inventoryMenu) { // fire INVENTORY_CLOSE if one already open
+- player.connection.handleContainerClose(new ServerboundContainerClosePacket(player.containerMenu.containerId));
++ player.connection.handleContainerClose(new ServerboundContainerClosePacket(player.containerMenu.containerId), InventoryCloseEvent.Reason.OPEN_NEW); // Paper - Inventory close reason
+ }
+
+ CraftServer server = player.level().getCraftServer();
+@@ -1477,8 +1477,18 @@ public class CraftEventFactory {
+ return event;
+ }
+
++ // Paper start
++ /**
++ * Incase plugins hooked into this or Spigot adds a new inventory close event. Prefer to pass a reason
++ * @param human
++ */
++ @Deprecated
+ public static void handleInventoryCloseEvent(net.minecraft.world.entity.player.Player human) {
+- InventoryCloseEvent event = new InventoryCloseEvent(human.containerMenu.getBukkitView());
++ handleInventoryCloseEvent(human, org.bukkit.event.inventory.InventoryCloseEvent.Reason.UNKNOWN);
++ }
++ public static void handleInventoryCloseEvent(net.minecraft.world.entity.player.Player human, org.bukkit.event.inventory.InventoryCloseEvent.Reason reason) {
++ // Paper end
++ InventoryCloseEvent event = new InventoryCloseEvent(human.containerMenu.getBukkitView(), reason); // Paper
+ human.level().getCraftServer().getPluginManager().callEvent(event);
+ human.containerMenu.transferTo(human.inventoryMenu, human.getBukkitEntity());
+ }