aboutsummaryrefslogtreecommitdiffhomepage
path: root/patches/server/0338-Remote-Connections-shouldn-t-hold-up-shutdown.patch
diff options
context:
space:
mode:
Diffstat (limited to 'patches/server/0338-Remote-Connections-shouldn-t-hold-up-shutdown.patch')
-rw-r--r--patches/server/0338-Remote-Connections-shouldn-t-hold-up-shutdown.patch44
1 files changed, 44 insertions, 0 deletions
diff --git a/patches/server/0338-Remote-Connections-shouldn-t-hold-up-shutdown.patch b/patches/server/0338-Remote-Connections-shouldn-t-hold-up-shutdown.patch
new file mode 100644
index 0000000000..d5833fa44c
--- /dev/null
+++ b/patches/server/0338-Remote-Connections-shouldn-t-hold-up-shutdown.patch
@@ -0,0 +1,44 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Aikar <[email protected]>
+Date: Tue, 31 Mar 2020 03:50:42 -0400
+Subject: [PATCH] Remote Connections shouldn't hold up shutdown
+
+Bugs in the connection logic appears to leave stale connections even, preventing shutdown
+
+diff --git a/src/main/java/net/minecraft/server/dedicated/DedicatedServer.java b/src/main/java/net/minecraft/server/dedicated/DedicatedServer.java
+index bce5fc7337d4e29c3353600a35c999caaed1428e..3d33504eac6af17c8833de11226968d52f96232f 100644
+--- a/src/main/java/net/minecraft/server/dedicated/DedicatedServer.java
++++ b/src/main/java/net/minecraft/server/dedicated/DedicatedServer.java
+@@ -412,11 +412,11 @@ public class DedicatedServer extends MinecraftServer implements ServerInterface
+ }
+
+ if (this.rconThread != null) {
+- this.rconThread.stop();
++ this.rconThread.stopNonBlocking(); // Paper - don't wait for remote connections
+ }
+
+ if (this.queryThreadGs4 != null) {
+- this.queryThreadGs4.stop();
++ // this.remoteStatusListener.stop(); // Paper - don't wait for remote connections
+ }
+
+ System.exit(0); // CraftBukkit
+diff --git a/src/main/java/net/minecraft/server/rcon/thread/RconThread.java b/src/main/java/net/minecraft/server/rcon/thread/RconThread.java
+index 594fbb033b63b8c9fb8752b1fcc78f8e9f7a2a83..c12d7db2b048a327c0e8f398848cd3a9bce0ebce 100644
+--- a/src/main/java/net/minecraft/server/rcon/thread/RconThread.java
++++ b/src/main/java/net/minecraft/server/rcon/thread/RconThread.java
+@@ -104,6 +104,14 @@ public class RconThread extends GenericThread {
+
+ this.clients.clear();
+ }
++ // Paper start - don't wait for remote connections
++ public void stopNonBlocking() {
++ this.running = false;
++ for (RconClient client : this.clients) {
++ client.running = false;
++ }
++ }
++ // Paper end - don't wait for remote connections
+
+ private void closeSocket(ServerSocket socket) {
+ LOGGER.debug("closeSocket: {}", socket);