summaryrefslogtreecommitdiffhomepage
path: root/patches/server/0403-Validate-PickItem-Packet-and-kick-for-invalid.patch
diff options
context:
space:
mode:
Diffstat (limited to 'patches/server/0403-Validate-PickItem-Packet-and-kick-for-invalid.patch')
-rw-r--r--patches/server/0403-Validate-PickItem-Packet-and-kick-for-invalid.patch26
1 files changed, 26 insertions, 0 deletions
diff --git a/patches/server/0403-Validate-PickItem-Packet-and-kick-for-invalid.patch b/patches/server/0403-Validate-PickItem-Packet-and-kick-for-invalid.patch
new file mode 100644
index 0000000000..7a5ea4882c
--- /dev/null
+++ b/patches/server/0403-Validate-PickItem-Packet-and-kick-for-invalid.patch
@@ -0,0 +1,26 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Aikar <[email protected]>
+Date: Sat, 2 May 2020 03:09:46 -0400
+Subject: [PATCH] Validate PickItem Packet and kick for invalid
+
+
+diff --git a/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java b/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
+index bb870abae77d8fbf107bc9596637d4fac204c501..569a8b6889e7085e3e408ebd47a71e8b5af8ca5e 100644
+--- a/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
++++ b/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
+@@ -960,7 +960,14 @@ public class ServerGamePacketListenerImpl implements ServerPlayerConnection, Tic
+ @Override
+ public void handlePickItem(ServerboundPickItemPacket packet) {
+ PacketUtils.ensureRunningOnSameThread(packet, this, this.player.getLevel());
+- this.player.getInventory().pickSlot(packet.getSlot());
++ // Paper start - validate pick item position
++ if (!(packet.getSlot() >= 0 && packet.getSlot() < this.player.getInventory().items.size())) {
++ ServerGamePacketListenerImpl.LOGGER.warn("{} tried to set an invalid carried item", this.player.getName().getString());
++ this.disconnect("Invalid hotbar selection (Hacking?)");
++ return;
++ }
++ this.player.getInventory().pickSlot(packet.getSlot()); // Paper - Diff above if changed
++ // Paper end
+ this.player.connection.send(new ClientboundContainerSetSlotPacket(-2, 0, this.player.getInventory().selected, this.player.getInventory().getItem(this.player.getInventory().selected)));
+ this.player.connection.send(new ClientboundContainerSetSlotPacket(-2, 0, packet.getSlot(), this.player.getInventory().getItem(packet.getSlot())));
+ this.player.connection.send(new ClientboundSetCarriedItemPacket(this.player.getInventory().selected));