aboutsummaryrefslogtreecommitdiffhomepage
path: root/patches/server/0710-Prevent-entity-loading-causing-async-lookups.patch
diff options
context:
space:
mode:
Diffstat (limited to 'patches/server/0710-Prevent-entity-loading-causing-async-lookups.patch')
-rw-r--r--patches/server/0710-Prevent-entity-loading-causing-async-lookups.patch81
1 files changed, 81 insertions, 0 deletions
diff --git a/patches/server/0710-Prevent-entity-loading-causing-async-lookups.patch b/patches/server/0710-Prevent-entity-loading-causing-async-lookups.patch
new file mode 100644
index 0000000000..666fd8ab2f
--- /dev/null
+++ b/patches/server/0710-Prevent-entity-loading-causing-async-lookups.patch
@@ -0,0 +1,81 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Owen1212055 <[email protected]>
+Date: Sun, 6 Mar 2022 11:09:09 -0500
+Subject: [PATCH] Prevent entity loading causing async lookups
+
+
+diff --git a/src/main/java/net/minecraft/world/entity/Entity.java b/src/main/java/net/minecraft/world/entity/Entity.java
+index b0c9c22c983344119925d76ee3180df9f411d8f5..0b273d6249c212994b23aeaac382e532edfd563f 100644
+--- a/src/main/java/net/minecraft/world/entity/Entity.java
++++ b/src/main/java/net/minecraft/world/entity/Entity.java
+@@ -715,6 +715,7 @@ public abstract class Entity implements SyncedDataHolder, Nameable, EntityAccess
+
+ public void baseTick() {
+ this.level().getProfiler().push("entityBaseTick");
++ if (firstTick && this instanceof net.minecraft.world.entity.NeutralMob neutralMob) neutralMob.tickInitialPersistentAnger(level); // Paper - Prevent entity loading causing async lookups
+ this.inBlockState = null;
+ if (this.isPassenger() && this.getVehicle().isRemoved()) {
+ this.stopRiding();
+diff --git a/src/main/java/net/minecraft/world/entity/NeutralMob.java b/src/main/java/net/minecraft/world/entity/NeutralMob.java
+index 3b08905ddc3c2506779ce0eac1a53a4d89442ddc..b55633bf4e26dc00e27ab28c7739c274e48b74c3 100644
+--- a/src/main/java/net/minecraft/world/entity/NeutralMob.java
++++ b/src/main/java/net/minecraft/world/entity/NeutralMob.java
+@@ -45,24 +45,11 @@ public interface NeutralMob {
+ UUID uuid = nbt.getUUID("AngryAt");
+
+ this.setPersistentAngerTarget(uuid);
+- Entity entity = ((ServerLevel) world).getEntity(uuid);
+-
+- if (entity != null) {
+- if (entity instanceof Mob) {
+- Mob entityinsentient = (Mob) entity;
+-
+- this.setTarget(entityinsentient, EntityTargetEvent.TargetReason.UNKNOWN, false); // CraftBukkit
+- this.setLastHurtByMob(entityinsentient);
+- }
+-
+- if (entity instanceof Player) {
+- Player entityhuman = (Player) entity;
+-
+- this.setTarget(entityhuman, EntityTargetEvent.TargetReason.UNKNOWN, false); // CraftBukkit
+- this.setLastHurtByPlayer(entityhuman);
+- }
+-
+- }
++ // Paper - Prevent entity loading causing async lookups; Moved diff to separate method
++ // If this entity already survived its first tick, e.g. is loaded and ticked in sync, actively
++ // tick the initial persistent anger.
++ // If not, let the first tick on the baseTick call the method later down the line.
++ if (this instanceof Entity entity && !entity.firstTick) this.tickInitialPersistentAnger(world);
+ }
+ }
+ }
+@@ -136,4 +123,28 @@ public interface NeutralMob {
+
+ @Nullable
+ LivingEntity getTarget();
++
++ // Paper start - Prevent entity loading causing async lookups
++ // Update last hurt when ticking
++ default void tickInitialPersistentAnger(Level level) {
++ UUID target = getPersistentAngerTarget();
++ if (target == null) {
++ return;
++ }
++
++ Entity entity = ((ServerLevel) level).getEntity(target);
++
++ if (entity != null) {
++ if (entity instanceof Mob mob) {
++ this.setTarget(mob, EntityTargetEvent.TargetReason.UNKNOWN, false); // CraftBukkit
++ this.setLastHurtByMob(mob);
++ }
++
++ if (entity instanceof Player player) {
++ this.setTarget(player, EntityTargetEvent.TargetReason.UNKNOWN, false); // CraftBukkit
++ this.setLastHurtByPlayer(player);
++ }
++ }
++ }
++ // Paper end - Prevent entity loading causing async lookups
+ }