aboutsummaryrefslogtreecommitdiffhomepage
path: root/patches/server/0711-Throw-exception-on-world-create-while-being-ticked.patch
diff options
context:
space:
mode:
Diffstat (limited to 'patches/server/0711-Throw-exception-on-world-create-while-being-ticked.patch')
-rw-r--r--patches/server/0711-Throw-exception-on-world-create-while-being-ticked.patch78
1 files changed, 78 insertions, 0 deletions
diff --git a/patches/server/0711-Throw-exception-on-world-create-while-being-ticked.patch b/patches/server/0711-Throw-exception-on-world-create-while-being-ticked.patch
new file mode 100644
index 0000000000..6d760986bc
--- /dev/null
+++ b/patches/server/0711-Throw-exception-on-world-create-while-being-ticked.patch
@@ -0,0 +1,78 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Jake Potrebic <[email protected]>
+Date: Tue, 22 Mar 2022 12:44:30 -0700
+Subject: [PATCH] Throw exception on world create while being ticked
+
+There are no plans to support creating worlds while worlds are
+being ticked themselvess.
+
+diff --git a/src/main/java/net/minecraft/server/MinecraftServer.java b/src/main/java/net/minecraft/server/MinecraftServer.java
+index 8142e4a238066404f3d1685f9cee1a2b91cdd371..acdba56f025fe729398c5549175baad8e6818f62 100644
+--- a/src/main/java/net/minecraft/server/MinecraftServer.java
++++ b/src/main/java/net/minecraft/server/MinecraftServer.java
+@@ -318,6 +318,7 @@ public abstract class MinecraftServer extends ReentrantBlockableEventLoop<TickTa
+ // Spigot end
+ public final io.papermc.paper.configuration.PaperConfigurations paperConfigurations; // Paper - add paper configuration files
+ public static long currentTickLong = 0L; // Paper - track current tick as a long
++ public boolean isIteratingOverLevels = false; // Paper - Throw exception on world create while being ticked
+
+ public static <S extends MinecraftServer> S spin(Function<Thread, S> serverFactory) {
+ AtomicReference<S> atomicreference = new AtomicReference();
+@@ -1582,7 +1583,7 @@ public abstract class MinecraftServer extends ReentrantBlockableEventLoop<TickTa
+ this.getFunctions().tick();
+ MinecraftTimings.commandFunctionsTimer.stopTiming(); // Spigot // Paper
+ this.profiler.popPush("levels");
+- Iterator iterator = this.getAllLevels().iterator();
++ //Iterator iterator = this.getAllLevels().iterator(); // Paper - Throw exception on world create while being ticked; moved down
+
+ // CraftBukkit start
+ // Run tasks that are waiting on processing
+@@ -1614,6 +1615,8 @@ public abstract class MinecraftServer extends ReentrantBlockableEventLoop<TickTa
+ // Paper end - Perf: Optimize time updates
+ MinecraftTimings.timeUpdateTimer.stopTiming(); // Spigot // Paper
+
++ this.isIteratingOverLevels = true; // Paper - Throw exception on world create while being ticked
++ Iterator iterator = this.getAllLevels().iterator(); // Paper - Throw exception on world create while being ticked; move down
+ while (iterator.hasNext()) {
+ ServerLevel worldserver = (ServerLevel) iterator.next();
+ worldserver.hasPhysicsEvent = org.bukkit.event.block.BlockPhysicsEvent.getHandlerList().getRegisteredListeners().length > 0; // Paper - BlockPhysicsEvent
+@@ -1649,6 +1652,7 @@ public abstract class MinecraftServer extends ReentrantBlockableEventLoop<TickTa
+ this.profiler.pop();
+ worldserver.explosionDensityCache.clear(); // Paper - Optimize explosions
+ }
++ this.isIteratingOverLevels = false; // Paper - Throw exception on world create while being ticked
+
+ this.profiler.popPush("connection");
+ MinecraftTimings.connectionTimer.startTiming(); // Spigot // Paper
+diff --git a/src/main/java/org/bukkit/craftbukkit/CraftServer.java b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
+index 5a56e2b05f993dc1333ffb6e280d7bba97e305d7..986bbc91b82d3062ef1bf1542dd264f4154a7ea1 100644
+--- a/src/main/java/org/bukkit/craftbukkit/CraftServer.java
++++ b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
+@@ -907,6 +907,11 @@ public final class CraftServer implements Server {
+ return new ArrayList<World>(this.worlds.values());
+ }
+
++ @Override
++ public boolean isTickingWorlds() {
++ return console.isIteratingOverLevels;
++ }
++
+ public DedicatedPlayerList getHandle() {
+ return this.playerList;
+ }
+@@ -1169,6 +1174,7 @@ public final class CraftServer implements Server {
+ @Override
+ public World createWorld(WorldCreator creator) {
+ Preconditions.checkState(this.console.getAllLevels().iterator().hasNext(), "Cannot create additional worlds on STARTUP");
++ //Preconditions.checkState(!this.console.isIteratingOverLevels, "Cannot create a world while worlds are being ticked"); // Paper - Cat - Temp disable. We'll see how this goes.
+ Preconditions.checkArgument(creator != null, "WorldCreator cannot be null");
+
+ String name = creator.name();
+@@ -1345,6 +1351,7 @@ public final class CraftServer implements Server {
+
+ @Override
+ public boolean unloadWorld(World world, boolean save) {
++ //Preconditions.checkState(!this.console.isIteratingOverLevels, "Cannot unload a world while worlds are being ticked"); // Paper - Cat - Temp disable. We'll see how this goes.
+ if (world == null) {
+ return false;
+ }