aboutsummaryrefslogtreecommitdiffhomepage
path: root/patches/server/0766-Don-t-use-level-random-in-entity-constructors.patch
diff options
context:
space:
mode:
Diffstat (limited to 'patches/server/0766-Don-t-use-level-random-in-entity-constructors.patch')
-rw-r--r--patches/server/0766-Don-t-use-level-random-in-entity-constructors.patch41
1 files changed, 41 insertions, 0 deletions
diff --git a/patches/server/0766-Don-t-use-level-random-in-entity-constructors.patch b/patches/server/0766-Don-t-use-level-random-in-entity-constructors.patch
new file mode 100644
index 0000000000..ef3475e3a3
--- /dev/null
+++ b/patches/server/0766-Don-t-use-level-random-in-entity-constructors.patch
@@ -0,0 +1,41 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Jake Potrebic <[email protected]>
+Date: Sun, 10 Jul 2022 14:13:22 -0700
+Subject: [PATCH] Don't use level random in entity constructors
+
+Paper makes the entity random thread-safe
+and constructing an entity off the main thread
+should be supported. Some entities (for whatever
+reason) use the level's random in some places.
+
+diff --git a/src/main/java/net/minecraft/world/entity/item/ItemEntity.java b/src/main/java/net/minecraft/world/entity/item/ItemEntity.java
+index 78acc580d66917e52d89632e3f0b7c1e979714d4..d0dac3dc89b9bb645a1d8498802fb8c6bff6a78e 100644
+--- a/src/main/java/net/minecraft/world/entity/item/ItemEntity.java
++++ b/src/main/java/net/minecraft/world/entity/item/ItemEntity.java
+@@ -67,7 +67,12 @@ public class ItemEntity extends Entity implements TraceableEntity {
+ }
+
+ public ItemEntity(Level world, double x, double y, double z, ItemStack stack) {
+- this(world, x, y, z, stack, world.random.nextDouble() * 0.2D - 0.1D, 0.2D, world.random.nextDouble() * 0.2D - 0.1D);
++ // Paper start - Don't use level random in entity constructors (to make them thread-safe)
++ this(EntityType.ITEM, world);
++ this.setPos(x, y, z);
++ this.setDeltaMovement(this.random.nextDouble() * 0.2D - 0.1D, 0.2D, this.random.nextDouble() * 0.2D - 0.1D);
++ this.setItem(stack);
++ // Paper end - Don't use level random in entity constructors
+ }
+
+ public ItemEntity(Level world, double x, double y, double z, ItemStack stack, double velocityX, double velocityY, double velocityZ) {
+diff --git a/src/main/java/net/minecraft/world/entity/item/PrimedTnt.java b/src/main/java/net/minecraft/world/entity/item/PrimedTnt.java
+index 16f9d38687c0fdda18468b5bfb61b09b98254968..e712bd07ea2946167782473a536e0c72fab4bccd 100644
+--- a/src/main/java/net/minecraft/world/entity/item/PrimedTnt.java
++++ b/src/main/java/net/minecraft/world/entity/item/PrimedTnt.java
+@@ -44,7 +44,7 @@ public class PrimedTnt extends Entity implements TraceableEntity {
+ public PrimedTnt(Level world, double x, double y, double z, @Nullable LivingEntity igniter) {
+ this(EntityType.TNT, world);
+ this.setPos(x, y, z);
+- double d3 = world.random.nextDouble() * 6.2831854820251465D;
++ double d3 = this.random.nextDouble() * 6.2831854820251465D; // Paper - Don't use level random in entity constructors
+
+ this.setDeltaMovement(-Math.sin(d3) * 0.02D, 0.20000000298023224D, -Math.cos(d3) * 0.02D);
+ this.setFuse(80);