aboutsummaryrefslogtreecommitdiffhomepage
path: root/patches/server/0811-Prevent-sending-oversized-item-data-in-equipment-and.patch
diff options
context:
space:
mode:
Diffstat (limited to 'patches/server/0811-Prevent-sending-oversized-item-data-in-equipment-and.patch')
-rw-r--r--patches/server/0811-Prevent-sending-oversized-item-data-in-equipment-and.patch86
1 files changed, 86 insertions, 0 deletions
diff --git a/patches/server/0811-Prevent-sending-oversized-item-data-in-equipment-and.patch b/patches/server/0811-Prevent-sending-oversized-item-data-in-equipment-and.patch
new file mode 100644
index 0000000000..e35fbc79b1
--- /dev/null
+++ b/patches/server/0811-Prevent-sending-oversized-item-data-in-equipment-and.patch
@@ -0,0 +1,86 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Nassim Jahnke <[email protected]>
+Date: Wed, 1 Dec 2021 12:36:25 +0100
+Subject: [PATCH] Prevent sending oversized item data in equipment and metadata
+
+
+diff --git a/src/main/java/net/minecraft/network/syncher/EntityDataSerializers.java b/src/main/java/net/minecraft/network/syncher/EntityDataSerializers.java
+index 3eb6bf4258b1de4697f96c2011df493cf7414a0c..bbf4e6b0ca0fe046469c675fc9e0929b64006548 100644
+--- a/src/main/java/net/minecraft/network/syncher/EntityDataSerializers.java
++++ b/src/main/java/net/minecraft/network/syncher/EntityDataSerializers.java
+@@ -127,7 +127,7 @@ public class EntityDataSerializers {
+ public static final EntityDataSerializer<ItemStack> ITEM_STACK = new EntityDataSerializer<ItemStack>() {
+ @Override
+ public void write(FriendlyByteBuf buf, ItemStack value) {
+- buf.writeItem(value);
++ buf.writeItem(net.minecraft.world.entity.LivingEntity.sanitizeItemStack(value, false)); // Paper - prevent oversized data
+ }
+
+ @Override
+diff --git a/src/main/java/net/minecraft/server/level/ServerEntity.java b/src/main/java/net/minecraft/server/level/ServerEntity.java
+index 9760ff4b6ca0e555f01151968cbfe0cdb8960e35..7464336f0c7ee59e59552afbad7bed0afcecef87 100644
+--- a/src/main/java/net/minecraft/server/level/ServerEntity.java
++++ b/src/main/java/net/minecraft/server/level/ServerEntity.java
+@@ -319,7 +319,10 @@ public class ServerEntity {
+ ItemStack itemstack = ((LivingEntity) this.entity).getItemBySlot(enumitemslot);
+
+ if (!itemstack.isEmpty()) {
+- list.add(Pair.of(enumitemslot, itemstack.copy()));
++ // Paper start - prevent oversized data
++ final ItemStack sanitized = LivingEntity.sanitizeItemStack(itemstack.copy(), false);
++ list.add(Pair.of(enumitemslot, sanitized));
++ // Paper end
+ }
+ }
+
+diff --git a/src/main/java/net/minecraft/world/entity/LivingEntity.java b/src/main/java/net/minecraft/world/entity/LivingEntity.java
+index 4240d5bcb550c591706d978ddabffd79104faa37..626e53564d4130b98440982e174fd7c23b7df863 100644
+--- a/src/main/java/net/minecraft/world/entity/LivingEntity.java
++++ b/src/main/java/net/minecraft/world/entity/LivingEntity.java
+@@ -3077,7 +3077,10 @@ public abstract class LivingEntity extends Entity {
+ equipmentChanges.forEach((enumitemslot, itemstack) -> {
+ ItemStack itemstack1 = itemstack.copy();
+
+- list.add(Pair.of(enumitemslot, itemstack1));
++ // Paper start - prevent oversized data
++ ItemStack toSend = sanitizeItemStack(itemstack1, true);
++ list.add(Pair.of(enumitemslot, toSend));
++ // Paper end
+ switch (enumitemslot.getType()) {
+ case HAND:
+ this.setLastHandItem(enumitemslot, itemstack1);
+@@ -3090,6 +3093,34 @@ public abstract class LivingEntity extends Entity {
+ ((ServerLevel) this.level).getChunkSource().broadcast(this, new ClientboundSetEquipmentPacket(this.getId(), list));
+ }
+
++ // Paper start - prevent oversized data
++ public static ItemStack sanitizeItemStack(final ItemStack itemStack, final boolean copyItemStack) {
++ if (itemStack.isEmpty() || !itemStack.hasTag()) {
++ return itemStack;
++ }
++
++ final ItemStack copy = copyItemStack ? itemStack.copy() : itemStack;
++ final CompoundTag tag = copy.getTag();
++ if (copy.is(Items.BUNDLE) && tag.get("Items") instanceof ListTag oldItems && !oldItems.isEmpty()) {
++ // Bundles change their texture based on their fullness.
++ org.bukkit.inventory.meta.BundleMeta bundleMeta = (org.bukkit.inventory.meta.BundleMeta) copy.asBukkitMirror().getItemMeta();
++ int sizeUsed = 0;
++ for (org.bukkit.inventory.ItemStack item : bundleMeta.getItems()) {
++ int scale = 64 / item.getMaxStackSize();
++ sizeUsed += scale * item.getAmount();
++ }
++ // Now we add a single fake item that uses the same amount of slots as all other items.
++ ListTag items = new ListTag();
++ items.add(new ItemStack(Items.PAPER, sizeUsed).save(new CompoundTag()));
++ tag.put("Items", items);
++ }
++ if (tag.get("BlockEntityTag") instanceof CompoundTag blockEntityTag) {
++ blockEntityTag.remove("Items");
++ }
++ return copy;
++ }
++ // Paper end
++
+ private ItemStack getLastArmorItem(EquipmentSlot slot) {
+ return (ItemStack) this.lastArmorItemStacks.get(slot.getIndex());
+ }