aboutsummaryrefslogtreecommitdiffhomepage
path: root/patches/api/0157-Change-the-reserved-channel-check-to-be-sensible.patch
blob: 332cd2a1ac04f019b495eb7d9dac448e6995e37a (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: DoNotSpamPls <7570108+DoNotSpamPls@users.noreply.github.com>
Date: Tue, 23 Oct 2018 19:32:55 +0300
Subject: [PATCH] Change the reserved channel check to be sensible


diff --git a/src/main/java/org/bukkit/plugin/messaging/StandardMessenger.java b/src/main/java/org/bukkit/plugin/messaging/StandardMessenger.java
index ed39f5116bdfba63f14aadfe81173fe2b68af4d7..8e96be6033e94d4f0bebb346ad222abe18d1f274 100644
--- a/src/main/java/org/bukkit/plugin/messaging/StandardMessenger.java
+++ b/src/main/java/org/bukkit/plugin/messaging/StandardMessenger.java
@@ -172,7 +172,7 @@ public class StandardMessenger implements Messenger {
     public boolean isReservedChannel(@NotNull String channel) {
         channel = validateAndCorrectChannel(channel);
 
-        return channel.contains("minecraft") && !channel.equals("minecraft:brand");
+        return channel.equals("minecraft:register") || channel.equals("minecraft:unregister"); // Paper
     }
 
     @Override
diff --git a/src/test/java/org/bukkit/plugin/messaging/StandardMessengerTest.java b/src/test/java/org/bukkit/plugin/messaging/StandardMessengerTest.java
index 144ae2f31badb8142bc4a76a7abab37a57118191..8ffaa33d97c045c0fd6851ec2f189344b4a070d2 100644
--- a/src/test/java/org/bukkit/plugin/messaging/StandardMessengerTest.java
+++ b/src/test/java/org/bukkit/plugin/messaging/StandardMessengerTest.java
@@ -26,8 +26,8 @@ public class StandardMessengerTest {
         assertTrue(messenger.isReservedChannel("minecraft:register"));
         assertFalse(messenger.isReservedChannel("test:register"));
         assertTrue(messenger.isReservedChannel("minecraft:unregister"));
-        assertFalse(messenger.isReservedChannel("test:nregister"));
-        assertTrue(messenger.isReservedChannel("minecraft:something"));
+        assertFalse(messenger.isReservedChannel("test:unregister")); // Paper - fix typo
+        assertFalse(messenger.isReservedChannel("minecraft:something")); // Paper - now less strict
         assertFalse(messenger.isReservedChannel("minecraft:brand"));
     }