From 7307340afa08f681f0c4a8ae8c64954dc4d67056 Mon Sep 17 00:00:00 2001 From: Ajay Ramachandran Date: Sun, 17 Jan 2021 12:53:31 -0500 Subject: Remove empty unsubmitted segments Resolves https://github.com/ajayyy/SponsorBlock/issues/609 --- src/config.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/config.ts b/src/config.ts index 2a40dbf6..c64800e8 100644 --- a/src/config.ts +++ b/src/config.ts @@ -247,10 +247,10 @@ const Config: SBObject = { * * @param data */ -function encodeStoredItem(data: T): T | Array { +function encodeStoredItem(data: T): T | Array<[string, Array]> { // if data is SBMap convert to json for storing if(!(data instanceof SBMap)) return data; - return Array.from(data.entries()); + return Array.from(data.entries()).filter((element) => element[1] === []); // Remove empty entries } /** -- cgit v1.2.3 From 7bb8f446bffbab9ecf6b8ee790653960d1d72928 Mon Sep 17 00:00:00 2001 From: Ajay Ramachandran Date: Sun, 17 Jan 2021 12:56:37 -0500 Subject: Fix type issues --- src/config.ts | 6 +++--- src/types.ts | 46 ++++++++++++++++------------------------------ 2 files changed, 19 insertions(+), 33 deletions(-) diff --git a/src/config.ts b/src/config.ts index c64800e8..4eb3e43d 100644 --- a/src/config.ts +++ b/src/config.ts @@ -1,5 +1,5 @@ import * as CompileConfig from "../config.json"; -import { CategorySelection, CategorySkipOption, PreviewBarOption, SponsorTime, StorageChangesObject } from "./types"; +import { CategorySelection, CategorySkipOption, PreviewBarOption, SponsorTime, StorageChangesObject, UnEncodedSegmentTimes as UnencodedSegmentTimes } from "./types"; import Utils from "./utils"; const utils = new Utils(); @@ -247,7 +247,7 @@ const Config: SBObject = { * * @param data */ -function encodeStoredItem(data: T): T | Array<[string, Array]> { +function encodeStoredItem(data: T): T | UnencodedSegmentTimes { // if data is SBMap convert to json for storing if(!(data instanceof SBMap)) return data; return Array.from(data.entries()).filter((element) => element[1] === []); // Remove empty entries @@ -265,7 +265,7 @@ function decodeStoredItem(id: string, data: T): T | SBMap void, dontShowNoticeAgain: () => void, @@ -22,34 +22,34 @@ interface ContentContainer { } } -interface FetchResponse { +export interface FetchResponse { responseText: string, status: number, ok: boolean } -interface VideoDurationResponse { +export interface VideoDurationResponse { duration: number; } -enum CategorySkipOption { +export enum CategorySkipOption { ShowOverlay, ManualSkip, AutoSkip } -interface CategorySelection { +export interface CategorySelection { name: string; option: CategorySkipOption } -enum SponsorHideType { +export enum SponsorHideType { Visible = undefined, Downvoted = 1, MinimumDuration } -interface SponsorTime { +export interface SponsorTime { segment: number[]; UUID: string; @@ -58,13 +58,13 @@ interface SponsorTime { hidden?: SponsorHideType; } -interface PreviewBarOption { +export interface PreviewBarOption { color: string, opacity: string } -interface Registration { +export interface Registration { message: string, id: string, allFrames: boolean, @@ -73,12 +73,12 @@ interface Registration { matches: string[] } -interface BackgroundScriptContainer { +export interface BackgroundScriptContainer { registerFirefoxContentScript: (opts: Registration) => void, unregisterFirefoxContentScript: (id: string) => void } -interface VideoInfo { +export interface VideoInfo { responseContext: { serviceTrackingParams: Array<{service: string, params: Array<{key: string, value: string}>}>, webResponseContextExtensionData: { @@ -154,22 +154,8 @@ interface VideoInfo { messages: unknown; } -type VideoID = string; - -type StorageChangesObject = { [key: string]: chrome.storage.StorageChange }; - -export { - FetchResponse, - VideoDurationResponse, - ContentContainer, - CategorySelection, - CategorySkipOption, - SponsorTime, - VideoID, - SponsorHideType, - PreviewBarOption, - Registration, - BackgroundScriptContainer, - VideoInfo, - StorageChangesObject, -}; +export type VideoID = string; + +export type StorageChangesObject = { [key: string]: chrome.storage.StorageChange }; + +export type UnEncodedSegmentTimes = [string, SponsorTime[]][]; \ No newline at end of file -- cgit v1.2.3 From 2fcfc989cf739ee3c4756b6bd5bad8fc2f710932 Mon Sep 17 00:00:00 2001 From: Ajay Ramachandran Date: Sun, 17 Jan 2021 13:00:27 -0500 Subject: Remove unsubmitted notification --- manifest/manifest.json | 1 - public/_locales/en/messages.json | 9 --------- public/options/options.html | 17 ----------------- src/background.ts | 10 ---------- src/config.ts | 2 -- src/content.ts | 20 -------------------- 6 files changed, 59 deletions(-) diff --git a/manifest/manifest.json b/manifest/manifest.json index 7f60599f..c25f2275 100644 --- a/manifest/manifest.json +++ b/manifest/manifest.json @@ -46,7 +46,6 @@ ], "permissions": [ "storage", - "notifications", "https://sponsor.ajay.app/*" ], "optional_permissions": [ diff --git a/public/_locales/en/messages.json b/public/_locales/en/messages.json index 5f92d260..0a761cf5 100644 --- a/public/_locales/en/messages.json +++ b/public/_locales/en/messages.json @@ -97,9 +97,6 @@ "wantToSubmit": { "message": "Do you want to submit for video id" }, - "leftTimes": { - "message": "You seem to have left some segments unsubmitted. Go back to that page to submit them (they are not deleted)." - }, "clearTimes": { "message": "Clear Segments" }, @@ -631,12 +628,6 @@ "categoryUpdate2": { "message": "Open the options to skip intros, outros, merch, etc." }, - "unsubmittedWarning": { - "message": "Unsubmitted Segments Notification" - }, - "unsubmittedWarningDescription": { - "message": "Send a notification when you leave a video with segments that are not uploaded" - }, "help": { "message": "Help" } diff --git a/public/options/options.html b/public/options/options.html index 04620a9e..68c28cbd 100644 --- a/public/options/options.html +++ b/public/options/options.html @@ -152,23 +152,6 @@

-
- - -
-
- -
__MSG_unsubmittedWarningDescription__
-
- -
-
-