From 84c25e3042da9736b3b09a94f09eeeecb0da4fe2 Mon Sep 17 00:00:00 2001 From: Michael C Date: Tue, 1 Aug 2023 15:20:24 -0400 Subject: [docs] move building to readme, formatting tweaks - reformatted windows build issues - updated contributing to reflect LGPL-3.0-or-later - replaced Invidio.us with Invidious - replaced API docs link - updated Invidious API link --- CONTRIBUTING.md | 48 +++++++++++++++++++++++++++++++++++++----------- 1 file changed, 37 insertions(+), 11 deletions(-) (limited to 'CONTRIBUTING.md') diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8fd62361..eb5217d6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,15 +1,41 @@ -If you make any contributions to SponsorBlock after this file was created, you are agreeing that any code you have contributed will be licensed under LGPL-3.0. +If you make any contributions to SponsorBlock after this file was created, you are agreeing that any code you have contributed will be licensed under LGPL-3.0 or later. -# All Platforms -Make sure to pull and update all submodules -`git submodule update --init --recursive` +# Building +## Building locally +0. You must have [Node.js 16 or later](https://nodejs.org/) and npm installed. +1. Clone with submodules + ```bash + git clone --recursive https://github.com/ajayyy/SponsorBlock + ``` + Or if you already cloned it, pull submodules with + ```bash + git submodule update --init --recursive + ``` +2. Copy the file `config.json.example` to `config.json` and adjust configuration as desired. + - Comments are invalid in JSON, make sure they are all removed. + - You will need to repeat this step in the future if you get build errors related to `CompileConfig` or `property does not exist on type ConfigClass`. This can happen for example when a new category is added. +3. Run `npm install` in the repository to install dependencies. +4. Run `npm run build:dev` (for Chrome) or `npm run build:dev:firefox` (for Firefox) to generate a development version of the extension with source maps. + - You can also run `npm run build` (for Chrome) or `npm run build:firefox` (for Firefox) to generate a production build. +5. The built extension is now in `dist/`. You can load this folder directly in Chrome as an [unpacked extension](https://developer.chrome.com/docs/extensions/mv3/getstarted/#manifest), or convert it to a zip file to load it as a [temporary extension](https://developer.mozilla.org/docs/Tools/about:debugging#loading_a_temporary_extension) in Firefox. -"? property does not exist on type ConfigClass" -> Make sure to copy `config.json.example` to `config.json` and remove comments - -# Windows +## Windows-specific build issues "Cannot find module "../maze-utils" -- Enable "Developer Mode" in windows for symlinks - `src/maze-utils` will not appear properly and builds will fail since it is is only rendered as a file -- Enable symlink support in git `git config --global core.symlinks true` -- run `git checkout -- src/maze-utils` in order to create a symlink instead of a text file \ No newline at end of file +- Enable "Developer Mode" in Windows (This enables symlink support) +- Enable symlink support in git: + ```pwsh + git config --global core.symlinks true + ``` +- Replace the text file with a symlink: + ```pwsh + git checkout -- src/maze-utils + ``` + +## Developing with a clean profile and hot reloading +Run `npm run dev` (for Chrome) or `npm run dev:firefox` (for Firefox) to run the extension using a clean browser profile with hot reloading. This uses [`web-ext run`](https://extensionworkshop.com/documentation/develop/web-ext-command-reference/#commands). + +Known chromium bug: Extension is not loaded properly on first start. Visit `chrome://extensions/` and reload the extension. + +For Firefox for Android, use `npm run dev:firefox-android -- --adb-device `. See the [Firefox documentation](https://extensionworkshop.com/documentation/develop/developing-extensions-for-firefox-for-android/#debug-your-extension) for more information. + -- cgit v1.2.3 From cc6b65c6c491fc1e8ef768b4a4e89231d34c504b Mon Sep 17 00:00:00 2001 From: Ajay Ramachandran Date: Tue, 1 Aug 2023 15:52:50 -0400 Subject: suggest using Linux --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'CONTRIBUTING.md') diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index eb5217d6..4f94363e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -2,7 +2,7 @@ If you make any contributions to SponsorBlock after this file was created, you a # Building ## Building locally -0. You must have [Node.js 16 or later](https://nodejs.org/) and npm installed. +0. You must have [Node.js 16 or later](https://nodejs.org/) and npm installed. Works best on Linux 1. Clone with submodules ```bash git clone --recursive https://github.com/ajayyy/SponsorBlock -- cgit v1.2.3 From 7c5b7502644ad1dde8b48e7b81979fd57f2d32b9 Mon Sep 17 00:00:00 2001 From: Ajay Ramachandran Date: Tue, 1 Aug 2023 19:57:07 -0400 Subject: use npm ci for consistency --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'CONTRIBUTING.md') diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4f94363e..c337879d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -14,7 +14,7 @@ If you make any contributions to SponsorBlock after this file was created, you a 2. Copy the file `config.json.example` to `config.json` and adjust configuration as desired. - Comments are invalid in JSON, make sure they are all removed. - You will need to repeat this step in the future if you get build errors related to `CompileConfig` or `property does not exist on type ConfigClass`. This can happen for example when a new category is added. -3. Run `npm install` in the repository to install dependencies. +3. Run `npm ci` in the repository to install dependencies. 4. Run `npm run build:dev` (for Chrome) or `npm run build:dev:firefox` (for Firefox) to generate a development version of the extension with source maps. - You can also run `npm run build` (for Chrome) or `npm run build:firefox` (for Firefox) to generate a production build. 5. The built extension is now in `dist/`. You can load this folder directly in Chrome as an [unpacked extension](https://developer.chrome.com/docs/extensions/mv3/getstarted/#manifest), or convert it to a zip file to load it as a [temporary extension](https://developer.mozilla.org/docs/Tools/about:debugging#loading_a_temporary_extension) in Firefox. -- cgit v1.2.3