ci: Use golangci's github action for linting (#3794)

* ci: Use golangci's github action for linting

Signed-off-by: Dave Henderson <[email protected]>

* Fix most of the staticcheck lint errors

Signed-off-by: Dave Henderson <[email protected]>

* Fix the prealloc lint errors

Signed-off-by: Dave Henderson <[email protected]>

* Fix the misspell lint errors

Signed-off-by: Dave Henderson <[email protected]>

* Fix the varcheck lint errors

Signed-off-by: Dave Henderson <[email protected]>

* Fix the errcheck lint errors

Signed-off-by: Dave Henderson <[email protected]>

* Fix the bodyclose lint errors

Signed-off-by: Dave Henderson <[email protected]>

* Fix the deadcode lint errors

Signed-off-by: Dave Henderson <[email protected]>

* Fix the unused lint errors

Signed-off-by: Dave Henderson <[email protected]>

* Fix the gosec lint errors

Signed-off-by: Dave Henderson <[email protected]>

* Fix the gosimple lint errors

Signed-off-by: Dave Henderson <[email protected]>

* Fix the ineffassign lint errors

Signed-off-by: Dave Henderson <[email protected]>

* Fix the staticcheck lint errors

Signed-off-by: Dave Henderson <[email protected]>

* Revert the misspell change, use a neutral English

Signed-off-by: Dave Henderson <[email protected]>

* Remove broken golangci-lint CI job

Signed-off-by: Dave Henderson <[email protected]>

* Re-add errantly-removed weakrand initialization

Signed-off-by: Dave Henderson <[email protected]>

* don't break the loop and return

* Removing extra handling for null rootKey

* unignore RegisterModule/RegisterAdapter

Co-authored-by: Mohammed Al Sahaf <[email protected]>

* single-line log message

Co-authored-by: Matt Holt <[email protected]>

* Fix lint after a1808b0dbf209c615e438a496d257ce5e3acdce2 was merged

Signed-off-by: Dave Henderson <[email protected]>

* Revert ticker change, ignore it instead

Signed-off-by: Dave Henderson <[email protected]>

* Ignore some of the write errors

Signed-off-by: Dave Henderson <[email protected]>

* Remove blank line

Signed-off-by: Dave Henderson <[email protected]>

* Use lifetime

Signed-off-by: Dave Henderson <[email protected]>

* close immediately

Co-authored-by: Matt Holt <[email protected]>

* Preallocate configVals

Signed-off-by: Dave Henderson <[email protected]>

* Update modules/caddytls/distributedstek/distributedstek.go

Co-authored-by: Mohammed Al Sahaf <[email protected]>
Co-authored-by: Matt Holt <[email protected]>

2 files changed, 23 insertions, 14 deletions

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 723336568..476b908f0 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -148,20 +148,6 @@ jobs:
         env:
           SSH_KEY: ${{ secrets.S390X_SSH_KEY }}
 
-  # From https://github.com/reviewdog/action-golangci-lint
-  golangci-lint:
-    name: runner / golangci-lint
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout code into the Go module directory
-        uses: actions/checkout@v2
-
-      - name: Run golangci-lint
-        uses: reviewdog/action-golangci-lint@v1
-        # uses: docker://reviewdog/action-golangci-lint:v1 # pre-build docker image
-        with:
-          github_token: ${{ secrets.github_token }}
-
   goreleaser-check:
     runs-on: ubuntu-latest
     steps:
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
new file mode 100644
index 000000000..ef6915055
--- /dev/null
+++ b/.github/workflows/lint.yml
@@ -0,0 +1,23 @@
+name: Lint
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  # From https://github.com/golangci/golangci-lint-action
+  golangci:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v2
+        with:
+          version: v1.31
+          # Optional: show only new issues if it's a pull request. The default value is `false`.
+          # only-new-issues: true