aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorJens-Uwe Mager <[email protected]>2024-08-21 19:39:20 +0200
committerGitHub <[email protected]>2024-08-21 11:39:20 -0600
commit2bb2ecc5498c99d535f5b8f56fb8a4732e818ad3 (patch)
treecf6662f3a7933f61d7c408e37367826b3d868cd1
parent54a0c8f94821f393edec1a1bc9459f2363c95117 (diff)
downloadcaddy-2bb2ecc5498c99d535f5b8f56fb8a4732e818ad3.tar.gz
caddy-2bb2ecc5498c99d535f5b8f56fb8a4732e818ad3.zip
reverseproxy: Change errors writing the response to warning. (#6532)
Most of the errors that can be seen here are write errors due to clients aborting the request from their side. Often seen ones include: * writing: ... write: broken pipe * writing: ... connection timed out * writing: http2: stream closed * writing: timeout... * writing: h3 error... Most of these errors are beyond of the control of caddy on the client side, probably nothing can be done on the server side. It still warrants researching when these errors occur very often, so a change in level from error to warn is better here to not polute the logs with errors in the normal case.
-rw-r--r--modules/caddyhttp/reverseproxy/reverseproxy.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/modules/caddyhttp/reverseproxy/reverseproxy.go b/modules/caddyhttp/reverseproxy/reverseproxy.go
index 4f97edead..1883ac072 100644
--- a/modules/caddyhttp/reverseproxy/reverseproxy.go
+++ b/modules/caddyhttp/reverseproxy/reverseproxy.go
@@ -979,7 +979,7 @@ func (h *Handler) finalizeResponse(
// we'll just log the error and abort the stream here and panic just as
// the standard lib's proxy to propagate the stream error.
// see issue https://github.com/caddyserver/caddy/issues/5951
- logger.Error("aborting with incomplete response", zap.Error(err))
+ logger.Warn("aborting with incomplete response", zap.Error(err))
// no extra logging from stdlib
panic(http.ErrAbortHandler)
}