diff options
| author | Dave Henderson <[email protected]> | 2020-11-22 16:50:29 -0500 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-11-22 14:50:29 -0700 |
| commit | bd17eb205d6ac464c64eb888a6f4b57445b6c59c (patch) | |
| tree | 5ba6a1284b72f9f3ac5323a0f1fc14795a4b40f8 /admin.go | |
| parent | 1e480b818b56b5c46b88d59f54e0b5e54e7758f8 (diff) | |
| download | caddy-bd17eb205d6ac464c64eb888a6f4b57445b6c59c.tar.gz caddy-bd17eb205d6ac464c64eb888a6f4b57445b6c59c.zip | |
ci: Use golangci's github action for linting (#3794)
* ci: Use golangci's github action for linting
Signed-off-by: Dave Henderson <[email protected]>
* Fix most of the staticcheck lint errors
Signed-off-by: Dave Henderson <[email protected]>
* Fix the prealloc lint errors
Signed-off-by: Dave Henderson <[email protected]>
* Fix the misspell lint errors
Signed-off-by: Dave Henderson <[email protected]>
* Fix the varcheck lint errors
Signed-off-by: Dave Henderson <[email protected]>
* Fix the errcheck lint errors
Signed-off-by: Dave Henderson <[email protected]>
* Fix the bodyclose lint errors
Signed-off-by: Dave Henderson <[email protected]>
* Fix the deadcode lint errors
Signed-off-by: Dave Henderson <[email protected]>
* Fix the unused lint errors
Signed-off-by: Dave Henderson <[email protected]>
* Fix the gosec lint errors
Signed-off-by: Dave Henderson <[email protected]>
* Fix the gosimple lint errors
Signed-off-by: Dave Henderson <[email protected]>
* Fix the ineffassign lint errors
Signed-off-by: Dave Henderson <[email protected]>
* Fix the staticcheck lint errors
Signed-off-by: Dave Henderson <[email protected]>
* Revert the misspell change, use a neutral English
Signed-off-by: Dave Henderson <[email protected]>
* Remove broken golangci-lint CI job
Signed-off-by: Dave Henderson <[email protected]>
* Re-add errantly-removed weakrand initialization
Signed-off-by: Dave Henderson <[email protected]>
* don't break the loop and return
* Removing extra handling for null rootKey
* unignore RegisterModule/RegisterAdapter
Co-authored-by: Mohammed Al Sahaf <[email protected]>
* single-line log message
Co-authored-by: Matt Holt <[email protected]>
* Fix lint after a1808b0dbf209c615e438a496d257ce5e3acdce2 was merged
Signed-off-by: Dave Henderson <[email protected]>
* Revert ticker change, ignore it instead
Signed-off-by: Dave Henderson <[email protected]>
* Ignore some of the write errors
Signed-off-by: Dave Henderson <[email protected]>
* Remove blank line
Signed-off-by: Dave Henderson <[email protected]>
* Use lifetime
Signed-off-by: Dave Henderson <[email protected]>
* close immediately
Co-authored-by: Matt Holt <[email protected]>
* Preallocate configVals
Signed-off-by: Dave Henderson <[email protected]>
* Update modules/caddytls/distributedstek/distributedstek.go
Co-authored-by: Mohammed Al Sahaf <[email protected]>
Co-authored-by: Matt Holt <[email protected]>
Diffstat (limited to 'admin.go')
| -rw-r--r-- | admin.go | 7 |
1 files changed, 5 insertions, 2 deletions
@@ -398,7 +398,10 @@ func (h adminHandler) handleError(w http.ResponseWriter, r *http.Request, err er w.Header().Set("Content-Type", "application/json") w.WriteHeader(apiErr.Code) - json.NewEncoder(w).Encode(apiErr) + encErr := json.NewEncoder(w).Encode(apiErr) + if encErr != nil { + Log().Named("admin.api").Error("failed to encode error response", zap.Error(encErr)) + } } // checkHost returns a handler that wraps next such that @@ -838,7 +841,7 @@ var ( // will get deleted before the process gracefully exits. func PIDFile(filename string) error { pid := []byte(strconv.Itoa(os.Getpid()) + "\n") - err := ioutil.WriteFile(filename, pid, 0644) + err := ioutil.WriteFile(filename, pid, 0600) if err != nil { return err } |