diff options
| author | Francis Lavoie <[email protected]> | 2021-04-22 20:29:04 -0400 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-04-22 18:29:04 -0600 |
| commit | a8d45277ca387ca4769fb4e881d242a5896cca5a (patch) | |
| tree | 35dbfdcb7371df0eb6e42806836f271f25b769b6 /caddyconfig/caddyfile/parse.go | |
| parent | 1e218e1d2e3986b7cc1cd7335b43f11a4f194b6e (diff) | |
| download | caddy-a8d45277ca387ca4769fb4e881d242a5896cca5a.tar.gz caddy-a8d45277ca387ca4769fb4e881d242a5896cca5a.zip | |
caddyfile: Fix `import` replacing unrelated placeholders (#4129)
* caddyfile: Fix `import` replacing unrelated placeholders
See https://caddy.community/t/snippet-issue-works-outside-snippet/12231
So it turns out that `NewReplacer()` gives a replacer with some global defaults (like `{env.*}` and some system and time placeholders), which is not ideal when running `import` because we just want to replace `{args.*}` only, and nothing else.
* caddyfile: Add test
Diffstat (limited to 'caddyconfig/caddyfile/parse.go')
| -rwxr-xr-x | caddyconfig/caddyfile/parse.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/caddyconfig/caddyfile/parse.go b/caddyconfig/caddyfile/parse.go index 52abf4786..96491bb30 100755 --- a/caddyconfig/caddyfile/parse.go +++ b/caddyconfig/caddyfile/parse.go @@ -321,7 +321,7 @@ func (p *parser) doImport() error { args := p.RemainingArgs() // add args to the replacer - repl := caddy.NewReplacer() + repl := caddy.NewEmptyReplacer() for index, arg := range args { repl.Set("args."+strconv.Itoa(index), arg) } |