diff options
| author | ewang <[email protected]> | 2024-02-23 17:46:04 -0800 |
|---|---|---|
| committer | Yuchen Wu <[email protected]> | 2024-03-01 13:47:27 -0800 |
| commit | e8113822247b5f9bb4eab34cb10121b873e73fd1 (patch) | |
| tree | f3086e44651a63a935e99299a56a46740d15d955 /docs/user_guide/phase.md | |
| parent | fa0ee757401c0058cdf0170bc7fe3680c41e872f (diff) | |
| download | pingora-e8113822247b5f9bb4eab34cb10121b873e73fd1.tar.gz pingora-e8113822247b5f9bb4eab34cb10121b873e73fd1.zip | |
Run upstream_response_filter on 304 from upstream cache revalidation
Previously only the response_filter would run on revalidated responses
with no way to process the upstream 304.
Also avoid passing through upstream 304 on revalidate
response_cache_filter errors and instead serve from cache. This
simplifies this edge case because it saves us from needing to check
whether the upstream header filter already ran on the 304 later.
Diffstat (limited to 'docs/user_guide/phase.md')
| -rw-r--r-- | docs/user_guide/phase.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/docs/user_guide/phase.md b/docs/user_guide/phase.md index aa30f3a..5455ed9 100644 --- a/docs/user_guide/phase.md +++ b/docs/user_guide/phase.md @@ -87,7 +87,7 @@ This phase is to modify requests before sending to upstream. ### `upstream_response_filter()/upstream_response_body_filter()` This phase is triggered after an upstream response header/body is received. -This phase is to modify response headers (or body) before sending to downstream. Note that this phase is called _prior_ to HTTP caching and therefore any changes made here will affect the response stored in the HTTP cache. +This phase is to modify or process response headers (or body) before sending to downstream. Note that this phase is called _prior_ to HTTP caching and therefore any changes made here will affect the response stored in the HTTP cache. ### `response_filter()/response_body_filter()/response_trailer_filter()` This phase is triggered after a response header/body/trailer is ready to send to downstream. |