aboutsummaryrefslogtreecommitdiffhomepage
path: root/tinyufo/src/lib.rs
diff options
context:
space:
mode:
authorMatthew Gumport <[email protected]>2024-06-21 15:18:33 -0700
committerEdward Wang <[email protected]>2024-06-28 12:34:25 -0700
commit38a9d556b557a10f7815f50fca6a49de146ab5be (patch)
tree21d45e0595cc9aaab2e717a00cd577f78cd5eddb /tinyufo/src/lib.rs
parenta483902c46fc43736fc5a27a5048b292493536b3 (diff)
downloadpingora-38a9d556b557a10f7815f50fca6a49de146ab5be.tar.gz
pingora-38a9d556b557a10f7815f50fca6a49de146ab5be.zip
make seeded estimator and plumbing for tests
I started fidgeting with another one of the tests breaking because of the estimator not being deterministic, and then decided to do this another way. This adds `seeded` and `seeded_compact` constructors to the estimator which are used in tests to override the LFU. These are hidden behind `cfg(test)`. The `random_status` field of the UFO object is also overridden with the same seeds as used for the seeded LFU. These make the tests pass consistently without requiring further monkeying.
Diffstat (limited to 'tinyufo/src/lib.rs')
-rw-r--r--tinyufo/src/lib.rs52
1 files changed, 38 insertions, 14 deletions
diff --git a/tinyufo/src/lib.rs b/tinyufo/src/lib.rs
index 805373e..eb4cbaf 100644
--- a/tinyufo/src/lib.rs
+++ b/tinyufo/src/lib.rs
@@ -473,7 +473,9 @@ mod tests {
#[test]
fn test_evict_from_small() {
- let cache = TinyUfo::new(5, 5);
+ let mut cache = TinyUfo::new(5, 5);
+ cache.random_status = RandomState::with_seeds(2, 3, 4, 5);
+ cache.queues.estimator = TinyLfu::new_seeded(5);
cache.put(1, 1, 1);
cache.put(2, 2, 2);
@@ -496,7 +498,9 @@ mod tests {
#[test]
fn test_evict_from_small_to_main() {
- let cache = TinyUfo::new(5, 5);
+ let mut cache = TinyUfo::new(5, 5);
+ cache.random_status = RandomState::with_seeds(2, 3, 4, 5);
+ cache.queues.estimator = TinyLfu::new_seeded(5);
cache.put(1, 1, 1);
cache.put(2, 2, 2);
@@ -510,20 +514,30 @@ mod tests {
assert_eq!(cache.peek_queue(2), Some(SMALL));
assert_eq!(cache.peek_queue(3), Some(SMALL));
- let evicted = cache.put(4, 4, 1);
+ let evicted = cache.put(4, 4, 2);
assert_eq!(evicted.len(), 1);
- assert_eq!(evicted[0].data, 2);
+ assert_eq!(evicted[0].weight, 2);
assert_eq!(cache.peek_queue(1), Some(MAIN));
- // 2 is evicted because 1 is in main
- assert_eq!(cache.peek_queue(2), None);
- assert_eq!(cache.peek_queue(3), Some(SMALL));
- assert_eq!(cache.peek_queue(4), Some(SMALL));
+ // either 2, 3, or 4 was evicted. Check evicted for which.
+ let mut remaining = vec![2, 3, 4];
+ remaining.remove(
+ remaining
+ .iter()
+ .position(|x| *x == evicted[0].data)
+ .unwrap(),
+ );
+ assert_eq!(cache.peek_queue(evicted[0].key), None);
+ for k in remaining {
+ assert_eq!(cache.peek_queue(k), Some(SMALL));
+ }
}
#[test]
fn test_evict_reentry() {
- let cache = TinyUfo::new(5, 5);
+ let mut cache = TinyUfo::new(5, 5);
+ cache.random_status = RandomState::with_seeds(2, 3, 4, 5);
+ cache.queues.estimator = TinyLfu::new_seeded(5);
cache.put(1, 1, 1);
cache.put(2, 2, 2);
@@ -555,7 +569,9 @@ mod tests {
#[test]
fn test_evict_entry_denied() {
- let cache = TinyUfo::new(5, 5);
+ let mut cache = TinyUfo::new(5, 5);
+ cache.random_status = RandomState::with_seeds(2, 3, 4, 5);
+ cache.queues.estimator = TinyLfu::new_seeded(5);
cache.put(1, 1, 1);
cache.put(2, 2, 2);
@@ -583,7 +599,9 @@ mod tests {
#[test]
fn test_force_put() {
- let cache = TinyUfo::new(5, 5);
+ let mut cache = TinyUfo::new(5, 5);
+ cache.random_status = RandomState::with_seeds(2, 3, 4, 5);
+ cache.queues.estimator = TinyLfu::new_seeded(5);
cache.put(1, 1, 1);
cache.put(2, 2, 2);
@@ -612,7 +630,9 @@ mod tests {
#[test]
fn test_evict_from_main() {
- let cache = TinyUfo::new(5, 5);
+ let mut cache = TinyUfo::new(5, 5);
+ cache.random_status = RandomState::with_seeds(2, 3, 4, 5);
+ cache.queues.estimator = TinyLfu::new_seeded(5);
cache.put(1, 1, 1);
cache.put(2, 2, 2);
@@ -649,7 +669,9 @@ mod tests {
#[test]
fn test_evict_from_small_compact() {
- let cache = TinyUfo::new(5, 5);
+ let mut cache = TinyUfo::new(5, 5);
+ cache.random_status = RandomState::with_seeds(2, 3, 4, 5);
+ cache.queues.estimator = TinyLfu::new_compact_seeded(5);
cache.put(1, 1, 1);
cache.put(2, 2, 2);
@@ -672,7 +694,9 @@ mod tests {
#[test]
fn test_evict_from_small_to_main_compact() {
- let cache = TinyUfo::new(5, 5);
+ let mut cache = TinyUfo::new(5, 5);
+ cache.random_status = RandomState::with_seeds(2, 3, 4, 5);
+ cache.queues.estimator = TinyLfu::new_compact_seeded(5);
cache.put(1, 1, 1);
cache.put(2, 2, 2);