1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
|
// Copyright 2024 Cloudflare, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
use super::*;
use crate::proxy_cache::{range_filter::RangeBodyFilter, ServeFromCache};
use crate::proxy_common::*;
use pingora_core::protocols::http::v2::client::{write_body, Http2Session};
// add scheme and authority as required by h2 lib
fn update_h2_scheme_authority(
header: &mut http::request::Parts,
raw_host: &[u8],
tls: bool,
) -> Result<()> {
let authority = if let Ok(s) = std::str::from_utf8(raw_host) {
if s.starts_with('[') {
// don't mess with ipv6 host
s
} else if let Some(colon) = s.find(':') {
if s.len() == colon + 1 {
// colon is the last char, ignore
s
} else if let Some(another_colon) = s[colon + 1..].find(':') {
// try to get rid of extra port numbers
&s[..colon + 1 + another_colon]
} else {
s
}
} else {
s
}
} else {
return Error::e_explain(
InvalidHTTPHeader,
format!("invalid authority from host {:?}", raw_host),
);
};
let scheme = if tls { "https" } else { "http" };
let uri = http::uri::Builder::new()
.scheme(scheme)
.authority(authority)
.path_and_query(header.uri.path_and_query().as_ref().unwrap().as_str())
.build();
match uri {
Ok(uri) => {
header.uri = uri;
Ok(())
}
Err(_) => Error::e_explain(
InvalidHTTPHeader,
format!("invalid authority from host {}", authority),
),
}
}
impl<SV> HttpProxy<SV> {
pub(crate) async fn proxy_1to2(
&self,
session: &mut Session,
client_session: &mut Http2Session,
peer: &HttpPeer,
ctx: &mut SV::CTX,
) -> (bool, Option<Box<Error>>)
// (reuse_server, error)
where
SV: ProxyHttp + Send + Sync,
SV::CTX: Send + Sync,
{
let mut req = session.req_header().clone();
if req.version != Version::HTTP_2 {
/* remove H1 specific headers */
// https://github.com/hyperium/h2/blob/d3b9f1e36aadc1a7a6804e2f8e86d3fe4a244b4f/src/proto/streams/send.rs#L72
req.remove_header(&http::header::TRANSFER_ENCODING);
req.remove_header(&http::header::CONNECTION);
req.remove_header(&http::header::UPGRADE);
req.remove_header("keep-alive");
req.remove_header("proxy-connection");
}
/* turn it into h2 */
req.set_version(Version::HTTP_2);
if session.cache.enabled() {
if let Err(e) = pingora_cache::filters::upstream::request_filter(
&mut req,
session.cache.maybe_cache_meta(),
) {
session.cache.disable(NoCacheReason::InternalError);
warn!("cache upstream filter error {}, disabling cache", e);
}
}
match self
.inner
.upstream_request_filter(session, &mut req, ctx)
.await
{
Ok(_) => { /* continue */ }
Err(e) => {
return (false, Some(e));
}
}
// Remove H1 `Host` header, save it in order to add to :authority
// We do this because certain H2 servers expect request not to have a host header.
// The `Host` is removed after the upstream filters above for 2 reasons
// 1. there is no API to change the :authority header
// 2. the filter code needs to be aware of the host vs :authority across http versions otherwise
let host = req.remove_header(&http::header::HOST);
session.upstream_compression.request_filter(&req);
let body_empty = session.as_mut().is_body_empty();
let mut req: http::request::Parts = req.into();
// H2 requires authority to be set, so copy that from H1 host if that is set
if let Some(host) = host {
if let Err(e) = update_h2_scheme_authority(&mut req, host.as_bytes(), peer.is_tls()) {
return (false, Some(e));
}
}
debug!("Request to h2: {:?}", req);
// don't send END_STREAM on HEADERS for no_header_eos
let send_header_eos = !peer.options.no_header_eos && body_empty;
let req = Box::new(RequestHeader::from(req));
match client_session.write_request_header(req, send_header_eos) {
Ok(v) => v,
Err(e) => {
return (false, Some(e.into_up()));
}
};
// send END_STREAM on empty DATA frame for no_headers_eos
if peer.options.no_header_eos && body_empty {
match client_session.write_request_body(Bytes::new(), true) {
Ok(()) => debug!("sent empty DATA frame to h2"),
Err(e) => {
return (false, Some(e.into_up()));
}
};
}
client_session.read_timeout = peer.options.read_timeout;
// take the body writer out of the client for easy duplex
let mut client_body = client_session
.take_request_body_writer()
.expect("already send request header");
let (tx, rx) = mpsc::channel::<HttpTask>(TASK_BUFFER_SIZE);
session.as_mut().enable_retry_buffering();
/* read downstream body and upstream response at the same time */
let ret = tokio::try_join!(
self.bidirection_1to2(session, &mut client_body, rx, ctx),
pipe_2to1_response(client_session, tx)
);
match ret {
Ok((_first, _second)) => (true, None),
Err(e) => (false, Some(e)),
}
}
pub(crate) async fn proxy_to_h2_upstream(
&self,
session: &mut Session,
client_session: &mut Http2Session,
reused: bool,
peer: &HttpPeer,
ctx: &mut SV::CTX,
) -> (bool, Option<Box<Error>>)
where
SV: ProxyHttp + Send + Sync,
SV::CTX: Send + Sync,
{
if let Err(e) = self
.inner
.connected_to_upstream(
session,
reused,
peer,
client_session.fd(),
client_session.digest(),
ctx,
)
.await
{
return (false, Some(e));
}
let (server_session_reuse, error) =
self.proxy_1to2(session, client_session, peer, ctx).await;
(server_session_reuse, error)
}
async fn bidirection_1to2(
&self,
session: &mut Session,
client_body: &mut h2::SendStream<bytes::Bytes>,
mut rx: mpsc::Receiver<HttpTask>,
ctx: &mut SV::CTX,
) -> Result<()>
where
SV: ProxyHttp + Send + Sync,
SV::CTX: Send + Sync,
{
let mut downstream_state = DownstreamStateMachine::new(session.as_mut().is_body_done());
// retry, send buffer if it exists
if let Some(buffer) = session.as_mut().get_retry_buffer() {
self.send_body_to2(
session,
Some(buffer),
downstream_state.is_done(),
client_body,
ctx,
)
.await?;
}
let mut response_state = ResponseStateMachine::new();
// these two below can be wrapped into an internal ctx
// use cache when upstream revalidates (or TODO: error)
let mut serve_from_cache = ServeFromCache::new();
let mut range_body_filter = proxy_cache::range_filter::RangeBodyFilter::new();
/* duplex mode
* see the Same function for h1 for more comments
*/
while !downstream_state.is_done() || !response_state.is_done() {
// Similar logic in h1 need to reserve capacity first to avoid deadlock
// But we don't need to do the same because the h2 client_body pipe is unbounded (never block)
tokio::select! {
// NOTE: cannot avoid this copy since h2 owns the buf
body = session.downstream_session.read_body_or_idle(downstream_state.is_done()), if downstream_state.can_poll() => {
debug!("downstream event");
let body = match body {
Ok(b) => b,
Err(e) => {
if serve_from_cache.is_miss() {
// ignore downstream error so that upstream can continue to write cache
downstream_state.to_errored();
warn!(
"Downstream Error ignored during caching: {}, {}",
e,
self.inner.request_summary(session, ctx)
);
continue;
} else {
return Err(e.into_down());
}
}
};
let is_body_done = session.is_body_done();
let request_done =
self.send_body_to2(session, body, is_body_done, client_body, ctx)
.await?;
downstream_state.maybe_finished(request_done);
},
task = rx.recv(), if !response_state.upstream_done() => {
if let Some(t) = task {
debug!("upstream event: {:?}", t);
if serve_from_cache.should_discard_upstream() {
// just drain, do we need to do anything else?
continue;
}
// pull as many tasks as we can
let mut tasks = Vec::with_capacity(TASK_BUFFER_SIZE);
tasks.push(t);
while let Some(maybe_task) = rx.recv().now_or_never() {
if let Some(t) = maybe_task {
tasks.push(t);
} else {
break
}
}
/* run filters before sending to downstream */
let mut filtered_tasks = Vec::with_capacity(TASK_BUFFER_SIZE);
for mut t in tasks {
if self.revalidate_or_stale(session, &mut t, ctx).await {
serve_from_cache.enable();
response_state.enable_cached_response();
// skip downstream filtering entirely as the 304 will not be sent
break;
}
session.upstream_compression.response_filter(&mut t);
// check error and abort
// otherwise the error is surfaced via write_response_tasks()
if !serve_from_cache.should_send_to_downstream() {
if let HttpTask::Failed(e) = t {
return Err(e);
}
}
filtered_tasks.push(
self.h2_response_filter(session, t, ctx,
&mut serve_from_cache,
&mut range_body_filter, false).await?);
if serve_from_cache.is_miss_header() {
response_state.enable_cached_response();
}
}
if !serve_from_cache.should_send_to_downstream() {
// TODO: need to derive response_done from filtered_tasks in case downstream failed already
continue;
}
let response_done = session.write_response_tasks(filtered_tasks).await?;
response_state.maybe_set_upstream_done(response_done);
} else {
debug!("empty upstream event");
response_state.maybe_set_upstream_done(true);
}
}
task = serve_from_cache.next_http_task(&mut session.cache),
if !response_state.cached_done() && !downstream_state.is_errored() && serve_from_cache.is_on() => {
let task = self.h2_response_filter(session, task?, ctx,
&mut serve_from_cache,
&mut range_body_filter, true).await?;
match session.write_response_tasks(vec![task]).await {
Ok(b) => response_state.maybe_set_cache_done(b),
Err(e) => if serve_from_cache.is_miss() {
// give up writing to downstream but wait for upstream cache write to finish
downstream_state.to_errored();
response_state.maybe_set_cache_done(true);
warn!(
"Downstream Error ignored during caching: {}, {}",
e,
self.inner.request_summary(session, ctx)
);
continue;
} else {
return Err(e);
}
}
if response_state.cached_done() {
if let Err(e) = session.cache.finish_hit_handler().await {
warn!("Error during finish_hit_handler: {}", e);
}
}
}
else => {
break;
}
}
}
match session.as_mut().finish_body().await {
Ok(_) => {
debug!("finished sending body to downstream");
}
Err(e) => {
error!("Error finish sending body to downstream: {}", e);
// TODO: don't do downstream keepalive
}
}
Ok(())
}
async fn h2_response_filter(
&self,
session: &mut Session,
mut task: HttpTask,
ctx: &mut SV::CTX,
serve_from_cache: &mut ServeFromCache,
range_body_filter: &mut RangeBodyFilter,
from_cache: bool, // are the task from cache already
) -> Result<HttpTask>
where
SV: ProxyHttp + Send + Sync,
SV::CTX: Send + Sync,
{
if !from_cache {
self.upstream_filter(session, &mut task, ctx)?;
// cache the original response before any downstream transformation
// requests that bypassed cache still need to run filters to see if the response has become cacheable
if session.cache.enabled() || session.cache.bypassing() {
if let Err(e) = self
.cache_http_task(session, &task, ctx, serve_from_cache)
.await
{
if serve_from_cache.is_miss_body() {
// if the response stream cache body during miss but write fails, it has to
// give up the entire request
return Err(e);
} else {
// otherwise, continue processing the response
warn!(
"Fail to cache response: {}, {}",
e,
self.inner.request_summary(session, ctx)
);
}
}
}
// skip the downstream filtering if these tasks are just for cache admission
if !serve_from_cache.should_send_to_downstream() {
return Ok(task);
}
} // else: cached/local response, no need to trigger upstream filters and caching
match task {
HttpTask::Header(mut header, eos) => {
let req = session.req_header();
/* Downstream revalidation, only needed when cache is on because otherwise origin
* will handle it */
// TODO: if cache is disabled during response phase, we should still do the filter
if session.cache.enabled() {
self.downstream_response_conditional_filter(
serve_from_cache,
session,
&mut header,
ctx,
);
if !session.ignore_downstream_range {
let range_type =
proxy_cache::range_filter::range_header_filter(req, &mut header);
range_body_filter.set(range_type);
}
}
self.inner
.response_filter(session, &mut header, ctx)
.await?;
/* Downgrade the version so that write_response_header won't panic */
header.set_version(Version::HTTP_11);
// these status codes / method cannot have body, so no need to add chunked encoding
let no_body = session.req_header().method == "HEAD"
|| matches!(header.status.as_u16(), 204 | 304);
/* Add chunked header to tell downstream to use chunked encoding
* during the absent of content-length in h2 */
if !no_body
&& !header.status.is_informational()
&& header.headers.get(http::header::CONTENT_LENGTH).is_none()
{
header.insert_header(http::header::TRANSFER_ENCODING, "chunked")?;
}
Ok(HttpTask::Header(header, eos))
}
HttpTask::Body(data, eos) => {
let mut data = range_body_filter.filter_body(data);
if let Some(duration) = self
.inner
.response_body_filter(session, &mut data, eos, ctx)?
{
trace!("delaying response for {duration:?}");
time::sleep(duration).await;
}
Ok(HttpTask::Body(data, eos))
}
HttpTask::Trailer(mut trailers) => {
let trailer_buffer = match trailers.as_mut() {
Some(trailers) => {
debug!("Parsing response trailers..");
match self
.inner
.response_trailer_filter(session, trailers, ctx)
.await
{
Ok(buf) => buf,
Err(e) => {
error!(
"Encountered error while filtering upstream trailers {:?}",
e
);
None
}
}
}
_ => None,
};
// if we have a trailer buffer write it to the downstream response body
if let Some(buffer) = trailer_buffer {
// write_body will not write additional bytes after reaching the content-length
// for gRPC H2 -> H1 this is not a problem but may be a problem for non gRPC code
// https://http2.github.io/http2-spec/#malformed
Ok(HttpTask::Body(Some(buffer), true))
} else {
Ok(HttpTask::Trailer(trailers))
}
}
HttpTask::Done => Ok(task),
HttpTask::Failed(_) => Ok(task), // Do nothing just pass the error down
}
}
async fn send_body_to2(
&self,
session: &mut Session,
mut data: Option<Bytes>,
end_of_body: bool,
client_body: &mut h2::SendStream<bytes::Bytes>,
ctx: &mut SV::CTX,
) -> Result<bool>
where
SV: ProxyHttp + Send + Sync,
SV::CTX: Send + Sync,
{
session
.downstream_modules_ctx
.request_body_filter(&mut data, end_of_body)
.await?;
self.inner
.request_body_filter(session, &mut data, end_of_body, ctx)
.await?;
/* it is normal to get 0 bytes because of multi-chunk parsing or request_body_filter.
* Although there is no harm writing empty byte to h2, unlike h1, we ignore it
* for consistency */
if !end_of_body && data.as_ref().map_or(false, |d| d.is_empty()) {
return Ok(false);
}
if let Some(data) = data {
debug!("Write {} bytes body to h2 upstream", data.len());
write_body(client_body, data, end_of_body).map_err(|e| e.into_up())?;
} else {
debug!("Read downstream body done");
/* send a standalone END_STREAM flag */
write_body(client_body, Bytes::new(), true).map_err(|e| e.into_up())?;
}
Ok(end_of_body)
}
}
/* Read response header, body and trailer from h2 upstream and send them to tx */
pub(crate) async fn pipe_2to1_response(
client: &mut Http2Session,
tx: mpsc::Sender<HttpTask>,
) -> Result<()> {
client
.read_response_header()
.await
.map_err(|e| e.into_up())?; // should we send the error as an HttpTask?
let resp_header = Box::new(client.response_header().expect("just read").clone());
tx.send(HttpTask::Header(resp_header, client.response_finished()))
.await
.or_err(InternalError, "sending h2 headers to pipe")?;
while let Some(chunk) = client
.read_response_body()
.await
.map_err(|e| e.into_up())
.transpose()
{
let data = match chunk {
Ok(d) => d,
Err(e) => {
// Push the error to downstream and then quit
// Don't care if send fails: downstream already gone
let _ = tx.send(HttpTask::Failed(e.into_up())).await;
// Downstream should consume all remaining data and handle the error
return Ok(());
}
};
if data.is_empty() && !client.response_finished() {
/* it is normal to get 0 bytes because of multi-chunk
* don't write 0 bytes to downstream since it will be
* misread as the terminating chunk */
continue;
}
tx.send(HttpTask::Body(Some(data), client.response_finished()))
.await
.or_err(InternalError, "sending h2 body to pipe")?;
}
// attempt to get trailers
let trailers = match client.read_trailers().await {
Ok(t) => t,
Err(e) => {
// Similar to above, push the error to downstream and then quit
let _ = tx.send(HttpTask::Failed(e.into_up())).await;
return Ok(());
}
};
let trailers = trailers.map(Box::new);
if trailers.is_some() {
tx.send(HttpTask::Trailer(trailers))
.await
.or_err(InternalError, "sending h2 trailer to pipe")?;
}
tx.send(HttpTask::Done)
.await
.unwrap_or_else(|_| debug!("h2 to h1 channel closed!"));
Ok(())
}
#[test]
fn test_update_authority() {
let mut parts = http::request::Builder::new()
.body(())
.unwrap()
.into_parts()
.0;
update_h2_scheme_authority(&mut parts, b"example.com", true).unwrap();
assert_eq!("example.com", parts.uri.authority().unwrap());
update_h2_scheme_authority(&mut parts, b"example.com:456", true).unwrap();
assert_eq!("example.com:456", parts.uri.authority().unwrap());
update_h2_scheme_authority(&mut parts, b"example.com:", true).unwrap();
assert_eq!("example.com:", parts.uri.authority().unwrap());
update_h2_scheme_authority(&mut parts, b"example.com:123:345", true).unwrap();
assert_eq!("example.com:123", parts.uri.authority().unwrap());
update_h2_scheme_authority(&mut parts, b"[::1]", true).unwrap();
assert_eq!("[::1]", parts.uri.authority().unwrap());
// verify scheme
update_h2_scheme_authority(&mut parts, b"example.com", true).unwrap();
assert_eq!("https://example.com", parts.uri);
update_h2_scheme_authority(&mut parts, b"example.com", false).unwrap();
assert_eq!("http://example.com", parts.uri);
}
|