aboutsummaryrefslogtreecommitdiffhomepage
path: root/helpers
diff options
context:
space:
mode:
authorJoe Mooring <[email protected]>2023-10-24 03:04:13 -0700
committerGitHub <[email protected]>2023-10-24 12:04:13 +0200
commit272484f8bfab97dbadad49a638a3e4b6af499f15 (patch)
tree39853fd0d9a1c7e28372777e0924497cc26607b2 /helpers
parentde4e466036026e9a5805155f00882b93267231b5 (diff)
downloadhugo-272484f8bfab97dbadad49a638a3e4b6af499f15.tar.gz
hugo-272484f8bfab97dbadad49a638a3e4b6af499f15.zip
markdown: Pass emoji codes to yuin/goldmark-emoji
Removes emoji code conversion from the page and shortcode parsers. Emoji codes in markdown are now passed to Goldmark, where the goldmark-emoji extension converts them to decimal numeric character references. This disables emoji rendering for the alternate content formats: html, asciidoc, org, pandoc, and rst. Fixes #7332 Fixes #11587 Closes #11598
Diffstat (limited to 'helpers')
-rw-r--r--helpers/emoji_test.go78
1 files changed, 0 insertions, 78 deletions
diff --git a/helpers/emoji_test.go b/helpers/emoji_test.go
index b45444d45..c6a844b9d 100644
--- a/helpers/emoji_test.go
+++ b/helpers/emoji_test.go
@@ -13,13 +13,8 @@
package helpers
import (
- "math"
"reflect"
- "strings"
"testing"
-
- "github.com/gohugoio/hugo/bufferpool"
- "github.com/kyokomi/emoji/v2"
)
func TestEmojiCustom(t *testing.T) {
@@ -68,76 +63,3 @@ func TestEmojiCustom(t *testing.T) {
}
}
-
-// The Emoji benchmarks below are heavily skewed in Hugo's direction:
-//
-// Hugo have a byte slice, wants a byte slice and doesn't mind if the original is modified.
-
-func BenchmarkEmojiKyokomiFprint(b *testing.B) {
- f := func(in []byte) []byte {
- buff := bufferpool.GetBuffer()
- defer bufferpool.PutBuffer(buff)
- emoji.Fprint(buff, string(in))
-
- bc := make([]byte, buff.Len())
- copy(bc, buff.Bytes())
- return bc
- }
-
- doBenchmarkEmoji(b, f)
-}
-
-func BenchmarkEmojiKyokomiSprint(b *testing.B) {
- f := func(in []byte) []byte {
- return []byte(emoji.Sprint(string(in)))
- }
-
- doBenchmarkEmoji(b, f)
-}
-
-func BenchmarkHugoEmoji(b *testing.B) {
- doBenchmarkEmoji(b, Emojify)
-}
-
-func doBenchmarkEmoji(b *testing.B, f func(in []byte) []byte) {
- type input struct {
- in []byte
- expect []byte
- }
-
- data := []struct {
- input string
- expect string
- }{
- {"A :smile: a day", emoji.Sprint("A :smile: a day")},
- {"A :smile: and a :beer: day keeps the doctor away", emoji.Sprint("A :smile: and a :beer: day keeps the doctor away")},
- {"A :smile: a day and 10 " + strings.Repeat(":beer: ", 10), emoji.Sprint("A :smile: a day and 10 " + strings.Repeat(":beer: ", 10))},
- {"No smiles today.", "No smiles today."},
- {"No smiles for you or " + strings.Repeat("you ", 1000), "No smiles for you or " + strings.Repeat("you ", 1000)},
- }
-
- in := make([]input, b.N*len(data))
- cnt := 0
- for i := 0; i < b.N; i++ {
- for _, this := range data {
- in[cnt] = input{[]byte(this.input), []byte(this.expect)}
- cnt++
- }
- }
-
- b.ResetTimer()
- cnt = 0
- for i := 0; i < b.N; i++ {
- for j := range data {
- currIn := in[cnt]
- cnt++
- result := f(currIn.in)
- // The Emoji implementations gives slightly different output.
- diffLen := len(result) - len(currIn.expect)
- diffLen = int(math.Abs(float64(diffLen)))
- if diffLen > 30 {
- b.Fatalf("[%d] emoji std, got \n%q but expected \n%q", j, result, currIn.expect)
- }
- }
- }
-}