diff options
author | Paul Adenot <[email protected]> | 2016-02-15 10:43:52 +0100 |
---|---|---|
committer | Paul Adenot <[email protected]> | 2016-02-17 14:53:51 +0100 |
commit | 0af781aa95dac414a8c960d4524813bdf33a34db (patch) | |
tree | ccc9975592017ba9bc438d6524dc1a635fe975f5 /.gitignore | |
parent | 912097b84ef9683ac2d35fe61adedb8d88d5f672 (diff) | |
download | cubeb-0af781aa95dac414a8c960d4524813bdf33a34db.tar.gz cubeb-0af781aa95dac414a8c960d4524813bdf33a34db.zip |
Address review comments.
Build system.
Review comments: cubeb_resampler_speex_one_way ctor should take uint32_t.
Review comments: Use the default device for test_record.cpp
Review comments: use the correct path to include cubeb.h.
Review comments: use std::unique_ptr instead of auto_ptr, and remove auto_ptr implementation.
Review comments: Add test_duplex{,.exe} to .gitignore.
Review comments: Formatting in noop_resampler::fill.
Review comments: rename auto_array::resize to auto_array::reserve.
Review comments: Rename the method that push silence in an auto_array push_silence.
Review comments: Make test_duplex work with backend that use integers.
Review comments: indent in cubeb_resampler.cpp.
Review comments: call the target rate in the public interface of the resampler `target_rate`.
Review comments: Clarify the comment on cubeb_speex_resampler_one_way::drain.
Review comments: trailing space in cubeb_resampler_one_way::output assert.
Review comments: space between T and *.
Review comments: s/outut/output/.
Review comments: return before {.
Review comments: Use unique_ptr to create resampler objects.
We can't really use std::move here, as we appear to target platforms that don't
have it (Gecko on Android uses stlport that does not have std::move).
Review comments: check that the delay lign creation succeeded.
Review comments: Remove frame_count_at_rate.
Review comments: assert speex resampling suceeds.
Review comments: s/l atency/latency/.
Review comments: Remove comment.
Review comments: skip the tests that require an available audio input if none is available.
Diffstat (limited to '.gitignore')
-rw-r--r-- | .gitignore | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -55,6 +55,8 @@ test/test_resampler test/test_resampler.exe test/test_record test/test_record.exe +test/test_duplex +test/test_duplex.exe test/test_utils test/test_utils.exe include/cubeb/cubeb-stdint.h |