diff options
| author | Ayke van Laethem <[email protected]> | 2022-08-03 16:24:47 +0200 |
|---|---|---|
| committer | Ayke <[email protected]> | 2022-08-04 12:18:32 +0200 |
| commit | c7a23183e822b9eebb639902414a0e08a09fbba0 (patch) | |
| tree | 894a03fe2f4980a728c8401604d8a2c17503fde5 | |
| parent | f936125658e8aef885a0e31d8fc343859defe63c (diff) | |
| download | tinygo-c7a23183e822b9eebb639902414a0e08a09fbba0.tar.gz tinygo-c7a23183e822b9eebb639902414a0e08a09fbba0.zip | |
all: format code according to Go 1.19 rules
Go 1.19 started reformatting code in a way that makes it more obvious
how it will be rendered on pkg.go.dev. It gets it almost right, but not
entirely. Therefore, I had to modify some of the comments so that they
are formatted correctly.
114 files changed, 509 insertions, 381 deletions
diff --git a/builder/ar.go b/builder/ar.go index 7e33e731b..c3aad171e 100644 --- a/builder/ar.go +++ b/builder/ar.go @@ -18,7 +18,7 @@ import ( // makeArchive creates an arcive for static linking from a list of object files // given as a parameter. It is equivalent to the following command: // -// ar -rcs <archivePath> <objs...> +// ar -rcs <archivePath> <objs...> func makeArchive(arfile *os.File, objs []string) error { // Open the archive file. arwriter := ar.NewWriter(arfile) diff --git a/builder/build.go b/builder/build.go index ab5b2b44e..19145f554 100644 --- a/builder/build.go +++ b/builder/build.go @@ -1367,10 +1367,10 @@ func modifyStackSizes(executable string, stackSizeLoads []string, stackSizes map // // It might print something like the following: // -// function stack usage (in bytes) -// Reset_Handler 316 -// examples/blinky2.led1 92 -// runtime.run$1 300 +// function stack usage (in bytes) +// Reset_Handler 316 +// examples/blinky2.led1 92 +// runtime.run$1 300 func printStacks(calculatedStacks []string, stackSizes map[string]functionStackSize) { // Print the sizes of all stacks. fmt.Printf("%-32s %s\n", "function", "stack usage (in bytes)") diff --git a/builder/cc.go b/builder/cc.go index a1628f62c..03c8c6159 100644 --- a/builder/cc.go +++ b/builder/cc.go @@ -33,29 +33,29 @@ import ( // Because of this complexity, every file has in fact two cached build outputs: // the file itself, and the list of dependencies. Its operation is as follows: // -// depfile = hash(path, compiler, cflags, ...) -// if depfile exists: -// outfile = hash of all files and depfile name -// if outfile exists: -// # cache hit -// return outfile -// # cache miss -// tmpfile = compile file -// read dependencies (side effect of compile) -// write depfile -// outfile = hash of all files and depfile name -// rename tmpfile to outfile +// depfile = hash(path, compiler, cflags, ...) +// if depfile exists: +// outfile = hash of all files and depfile name +// if outfile exists: +// # cache hit +// return outfile +// # cache miss +// tmpfile = compile file +// read dependencies (side effect of compile) +// write depfile +// outfile = hash of all files and depfile name +// rename tmpfile to outfile // // There are a few edge cases that are not handled: -// - If a file is added to an include path, that file may be included instead of -// some other file. This would be fixed by also including lookup failures in the -// dependencies file, but I'm not aware of a compiler which does that. -// - The Makefile syntax that compilers output has issues, see readDepFile for -// details. -// - A header file may be changed to add/remove an include. This invalidates the -// depfile but without invalidating its name. For this reason, the depfile is -// written on each new compilation (even when it seems unnecessary). However, it -// could in rare cases lead to a stale file fetched from the cache. +// - If a file is added to an include path, that file may be included instead of +// some other file. This would be fixed by also including lookup failures in the +// dependencies file, but I'm not aware of a compiler which does that. +// - The Makefile syntax that compilers output has issues, see readDepFile for +// details. +// - A header file may be changed to add/remove an include. This invalidates the +// depfile but without invalidating its name. For this reason, the depfile is +// written on each new compilation (even when it seems unnecessary). However, it +// could in rare cases lead to a stale file fetched from the cache. func compileAndCacheCFile(abspath, tmpdir string, cflags []string, thinlto bool, printCommands func(string, ...string)) (string, error) { // Hash input file. fileHash, err := hashFile(abspath) @@ -252,13 +252,14 @@ func hashFile(path string) (string, error) { // file is assumed to have a single target named deps. // // There are roughly three make syntax variants: -// - BSD make, which doesn't support any escaping. This means that many special -// characters are not supported in file names. -// - GNU make, which supports escaping using a backslash but when it fails to -// find a file it tries to fall back with the literal path name (to match BSD -// make). -// - NMake (Visual Studio) and Jom, which simply quote the string if there are -// any weird characters. +// - BSD make, which doesn't support any escaping. This means that many special +// characters are not supported in file names. +// - GNU make, which supports escaping using a backslash but when it fails to +// find a file it tries to fall back with the literal path name (to match BSD +// make). +// - NMake (Visual Studio) and Jom, which simply quote the string if there are +// any weird characters. +// // Clang supports two variants: a format that's a compromise between BSD and GNU // make (and is buggy to match GCC which is equally buggy), and NMake/Jom, which // is at least somewhat sane. This last format isn't perfect either: it does not diff --git a/cgo/cgo.go b/cgo/cgo.go index 42914a11a..e1be8ab49 100644 --- a/cgo/cgo.go +++ b/cgo/cgo.go @@ -493,15 +493,15 @@ func (p *cgoPackage) makeUnionField(typ *elaboratedTypeInfo) *ast.StructType { // createUnionAccessor creates a function that returns a typed pointer to a // union field for each field in a union. For example: // -// func (union *C.union_1) unionfield_d() *float64 { -// return (*float64)(unsafe.Pointer(&union.$union)) -// } +// func (union *C.union_1) unionfield_d() *float64 { +// return (*float64)(unsafe.Pointer(&union.$union)) +// } // // Where C.union_1 is defined as: // -// type C.union_1 struct{ -// $union uint64 -// } +// type C.union_1 struct{ +// $union uint64 +// } // // The returned pointer can be used to get or set the field, or get the pointer // to a subfield. @@ -617,9 +617,9 @@ func (p *cgoPackage) createUnionAccessor(field *ast.Field, typeName string) { // createBitfieldGetter creates a bitfield getter function like the following: // -// func (s *C.struct_foo) bitfield_b() byte { -// return (s.__bitfield_1 >> 5) & 0x1 -// } +// func (s *C.struct_foo) bitfield_b() byte { +// return (s.__bitfield_1 >> 5) & 0x1 +// } func (p *cgoPackage) createBitfieldGetter(bitfield bitfieldInfo, typeName string) { // The value to return from the getter. // Not complete: this is just an expression to get the complete field. @@ -729,15 +729,15 @@ func (p *cgoPackage) createBitfieldGetter(bitfield bitfieldInfo, typeName string // createBitfieldSetter creates a bitfield setter function like the following: // -// func (s *C.struct_foo) set_bitfield_b(value byte) { -// s.__bitfield_1 = s.__bitfield_1 ^ 0x60 | ((value & 1) << 5) -// } +// func (s *C.struct_foo) set_bitfield_b(value byte) { +// s.__bitfield_1 = s.__bitfield_1 ^ 0x60 | ((value & 1) << 5) +// } // // Or the following: // -// func (s *C.struct_foo) set_bitfield_c(value byte) { -// s.__bitfield_1 = s.__bitfield_1 & 0x3f | (value << 6) -// } +// func (s *C.struct_foo) set_bitfield_c(value byte) { +// s.__bitfield_1 = s.__bitfield_1 & 0x3f | (value << 6) +// } func (p *cgoPackage) createBitfieldSetter(bitfield bitfieldInfo, typeName string) { // The full field with all bitfields. var field ast.Expr = &ast.SelectorExpr{ diff --git a/compiler/goroutine.go b/compiler/goroutine.go index a9b83c7cb..8d76c89f1 100644 --- a/compiler/goroutine.go +++ b/compiler/goroutine.go @@ -120,16 +120,16 @@ func (b *builder) createGo(instr *ssa.Go) { // createGoroutineStartWrapper creates a wrapper for the task-based // implementation of goroutines. For example, to call a function like this: // -// func add(x, y int) int { ... } +// func add(x, y int) int { ... } // // It creates a wrapper like this: // -// func add$gowrapper(ptr *unsafe.Pointer) { -// args := (*struct{ -// x, y int -// })(ptr) -// add(args.x, args.y) -// } +// func add$gowrapper(ptr *unsafe.Pointer) { +// args := (*struct{ +// x, y int +// })(ptr) +// add(args.x, args.y) +// } // // This is useful because the task-based goroutine start implementation only // allows a single (pointer) argument to the newly started goroutine. Also, it diff --git a/compiler/inlineasm.go b/compiler/inlineasm.go index 01725a274..27b0492bc 100644 --- a/compiler/inlineasm.go +++ b/compiler/inlineasm.go @@ -17,7 +17,7 @@ import ( // operands or return values. It is useful for trivial instructions, like wfi in // ARM or sleep in AVR. // -// func Asm(asm string) +// func Asm(asm string) // // The provided assembly must be a constant. func (b *builder) createInlineAsm(args []ssa.Value) (llvm.Value, error) { @@ -31,17 +31,17 @@ func (b *builder) createInlineAsm(args []ssa.Value) (llvm.Value, error) { // This is a compiler builtin, which allows assembly to be called in a flexible // way. // -// func AsmFull(asm string, regs map[string]interface{}) uintptr +// func AsmFull(asm string, regs map[string]interface{}) uintptr // // The asm parameter must be a constant string. The regs parameter must be // provided immediately. For example: // -// arm.AsmFull( -// "str {value}, {result}", -// map[string]interface{}{ -// "value": 1 -// "result": &dest, -// }) +// arm.AsmFull( +// "str {value}, {result}", +// map[string]interface{}{ +// "value": 1 +// "result": &dest, +// }) func (b *builder) createInlineAsmFull(instr *ssa.CallCommon) (llvm.Value, error) { asmString := constant.StringVal(instr.Args[0].(*ssa.Const).Value) registers := map[string]llvm.Value{} @@ -132,11 +132,11 @@ func (b *builder) createInlineAsmFull(instr *ssa.CallCommon) (llvm.Value, error) // This is a compiler builtin which emits an inline SVCall instruction. It can // be one of: // -// func SVCall0(num uintptr) uintptr -// func SVCall1(num uintptr, a1 interface{}) uintptr -// func SVCall2(num uintptr, a1, a2 interface{}) uintptr -// func SVCall3(num uintptr, a1, a2, a3 interface{}) uintptr -// func SVCall4(num uintptr, a1, a2, a3, a4 interface{}) uintptr +// func SVCall0(num uintptr) uintptr +// func SVCall1(num uintptr, a1 interface{}) uintptr +// func SVCall2(num uintptr, a1, a2 interface{}) uintptr +// func SVCall3(num uintptr, a1, a2, a3 interface{}) uintptr +// func SVCall4(num uintptr, a1, a2, a3, a4 interface{}) uintptr // // The num parameter must be a constant. All other parameters may be any scalar // value supported by LLVM inline assembly. @@ -169,11 +169,11 @@ func (b *builder) emitSVCall(args []ssa.Value) (llvm.Value, error) { // This is a compiler builtin which emits an inline SVCall instruction. It can // be one of: // -// func SVCall0(num uintptr) uintptr -// func SVCall1(num uintptr, a1 interface{}) uintptr -// func SVCall2(num uintptr, a1, a2 interface{}) uintptr -// func SVCall3(num uintptr, a1, a2, a3 interface{}) uintptr -// func SVCall4(num uintptr, a1, a2, a3, a4 interface{}) uintptr +// func SVCall0(num uintptr) uintptr +// func SVCall1(num uintptr, a1 interface{}) uintptr +// func SVCall2(num uintptr, a1, a2 interface{}) uintptr +// func SVCall3(num uintptr, a1, a2, a3 interface{}) uintptr +// func SVCall4(num uintptr, a1, a2, a3, a4 interface{}) uintptr // // The num parameter must be a constant. All other parameters may be any scalar // value supported by LLVM inline assembly. @@ -206,10 +206,10 @@ func (b *builder) emitSV64Call(args []ssa.Value) (llvm.Value, error) { // This is a compiler builtin which emits CSR instructions. It can be one of: // -// func (csr CSR) Get() uintptr -// func (csr CSR) Set(uintptr) -// func (csr CSR) SetBits(uintptr) uintptr -// func (csr CSR) ClearBits(uintptr) uintptr +// func (csr CSR) Get() uintptr +// func (csr CSR) Set(uintptr) +// func (csr CSR) SetBits(uintptr) uintptr +// func (csr CSR) ClearBits(uintptr) uintptr // // The csr parameter (method receiver) must be a constant. Other parameter can // be any value. diff --git a/compiler/interface.go b/compiler/interface.go index 03a9e150b..c59a9ade1 100644 --- a/compiler/interface.go +++ b/compiler/interface.go @@ -550,8 +550,8 @@ func (c *compilerContext) getInterfaceInvokeWrapper(fn *ssa.Function, llvmFn llv // internally to match interfaces and to call the correct method on an // interface. Examples: // -// String() string -// Read([]byte) (int, error) +// String() string +// Read([]byte) (int, error) func methodSignature(method *types.Func) string { return method.Name() + signature(method.Type().(*types.Signature)) } @@ -559,8 +559,8 @@ func methodSignature(method *types.Func) string { // Make a readable version of a function (pointer) signature. // Examples: // -// () string -// (string, int) (int, error) +// () string +// (string, int) (int, error) func signature(sig *types.Signature) string { s := "" if sig.Params().Len() == 0 { diff --git a/compiler/testdata/pragma.go b/compiler/testdata/pragma.go index b6ebc83b2..8ebb9ff12 100644 --- a/compiler/testdata/pragma.go +++ b/compiler/testdata/pragma.go @@ -3,44 +3,53 @@ package main import _ "unsafe" // Creates an external global with name extern_global. +// //go:extern extern_global var externGlobal [0]byte // Creates a +// //go:align 32 var alignedGlobal [4]uint32 // Test conflicting pragmas (the last one counts). +// //go:align 64 //go:align 16 var alignedGlobal16 [4]uint32 // Test exported functions. +// //export extern_func func externFunc() { } // Define a function in a different package using go:linkname. +// //go:linkname withLinkageName1 somepkg.someFunction1 func withLinkageName1() { } // Import a function from a different package using go:linkname. +// //go:linkname withLinkageName2 somepkg.someFunction2 func withLinkageName2() // Function has an 'inline hint', similar to the inline keyword in C. +// //go:inline func inlineFunc() { } // Function should never be inlined, equivalent to GCC // __attribute__((noinline)). +// //go:noinline func noinlineFunc() { } // This function should have the specified section. +// //go:section .special_function_section func functionInSection() { } @@ -51,6 +60,7 @@ func exportedFunctionInSection() { } // This function should not: it's only a declaration and not a definition. +// //go:section .special_function_section func undefinedFunctionNotInSection() diff --git a/src/crypto/rand/rand_arc4random.go b/src/crypto/rand/rand_arc4random.go index 8bfcbe872..6fcf1fd68 100644 --- a/src/crypto/rand/rand_arc4random.go +++ b/src/crypto/rand/rand_arc4random.go @@ -27,5 +27,6 @@ func (r *reader) Read(b []byte) (n int, err error) { } // void arc4random_buf(void *buf, size_t buflen); +// //export arc4random_buf func libc_arc4random_buf(buf unsafe.Pointer, buflen uint) diff --git a/src/crypto/rand/rand_windows.go b/src/crypto/rand/rand_windows.go index 9a840c32d..16266198f 100644 --- a/src/crypto/rand/rand_windows.go +++ b/src/crypto/rand/rand_windows.go @@ -38,5 +38,6 @@ func (r *reader) Read(b []byte) (n int, err error) { // Cryptographically secure random number generator. // https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/rand-s?view=msvc-170 // errno_t rand_s(unsigned int* randomValue); +// //export rand_s func libc_rand_s(randomValue *uint32) int32 diff --git a/src/device/arm/arm.go b/src/device/arm/arm.go index d6f44abcd..04637f317 100644 --- a/src/device/arm/arm.go +++ b/src/device/arm/arm.go @@ -2,31 +2,31 @@ // // Original copyright: // -// Copyright (c) 2009 - 2015 ARM LIMITED +// Copyright (c) 2009 - 2015 ARM LIMITED // -// All rights reserved. -// Redistribution and use in source and binary forms, with or without -// modification, are permitted provided that the following conditions are met: -// - Redistributions of source code must retain the above copyright -// notice, this list of conditions and the following disclaimer. -// - Redistributions in binary form must reproduce the above copyright -// notice, this list of conditions and the following disclaimer in the -// documentation and/or other materials provided with the distribution. -// - Neither the name of ARM nor the names of its contributors may be used -// to endorse or promote products derived from this software without -// specific prior written permission. +// All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are met: +// - Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// - Redistributions in binary form must reproduce the above copyright +// notice, this list of conditions and the following disclaimer in the +// documentation and/or other materials provided with the distribution. +// - Neither the name of ARM nor the names of its contributors may be used +// to endorse or promote products derived from this software without +// specific prior written permission. // -// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" -// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE -// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE -// ARE DISCLAIMED. IN NO EVENT SHALL COPYRIGHT HOLDERS AND CONTRIBUTORS BE -// LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR -// CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF -// SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS -// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN -// CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) -// ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE -// POSSIBILITY OF SUCH DAMAGE. +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" +// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE +// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE +// ARE DISCLAIMED. IN NO EVENT SHALL COPYRIGHT HOLDERS AND CONTRIBUTORS BE +// LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR +// CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF +// SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS +// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN +// CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) +// ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE +// POSSIBILITY OF SUCH DAMAGE. package arm import ( @@ -46,12 +46,12 @@ func Asm(asm string) // effects, as it would otherwise be optimized away. The inline assembly string // recognizes template values in the form {name}, like so: // -// arm.AsmFull( -// "str {value}, {result}", -// map[string]interface{}{ -// "value": 1 -// "result": &dest, -// }) +// arm.AsmFull( +// "str {value}, {result}", +// map[string]interface{}{ +// "value": 1 +// "result": &dest, +// }) // // You can use {} in the asm string (which expands to a register) to set the // return value. diff --git a/src/device/arm/semihosting.go b/src/device/arm/semihosting.go index 19e9f22c0..10b6497d1 100644 --- a/src/device/arm/semihosting.go +++ b/src/device/arm/semihosting.go @@ -60,5 +60,6 @@ const ( // Call a semihosting function. // TODO: implement it here using inline assembly. +// //go:linkname SemihostingCall SemihostingCall func SemihostingCall(num int, arg uintptr) int diff --git a/src/device/arm64/arm64.go b/src/device/arm64/arm64.go index bfd18ab28..7e8cea6c7 100644 --- a/src/device/arm64/arm64.go +++ b/src/device/arm64/arm64.go @@ -9,12 +9,12 @@ func Asm(asm string) // effects, as it would otherwise be optimized away. The inline assembly string // recognizes template values in the form {name}, like so: // -// arm.AsmFull( -// "str {value}, {result}", -// map[string]interface{}{ -// "value": 1 -// "result": &dest, -// }) +// arm.AsmFull( +// "str {value}, {result}", +// map[string]interface{}{ +// "value": 1 +// "result": &dest, +// }) // // You can use {} in the asm string (which expands to a register) to set the // return value. diff --git a/src/device/asm.go b/src/device/asm.go index f441b6ae2..49ddbc3ef 100644 --- a/src/device/asm.go +++ b/src/device/asm.go @@ -9,12 +9,12 @@ func Asm(asm string) // effects, as it would otherwise be optimized away. The inline assembly string // recognizes template values in the form {name}, like so: // -// arm.AsmFull( -// "str {value}, {result}", -// map[string]interface{}{ -// "value": 1 -// "result": &dest, -// }) +// arm.AsmFull( +// "str {value}, {result}", +// map[string]interface{}{ +// "value": 1 +// "result": &dest, +// }) // // You can use {} in the asm string (which expands to a register) to set the // return value. diff --git a/src/device/avr/avr.go b/src/device/avr/avr.go index 12f145dd7..1890e18b5 100644 --- a/src/device/avr/avr.go +++ b/src/device/avr/avr.go @@ -9,12 +9,12 @@ func Asm(asm string) // effects, as it would otherwise be optimized away. The inline assembly string // recognizes template values in the form {name}, like so: // -// avr.AsmFull( -// "str {value}, {result}", -// map[string]interface{}{ -// "value": 1 -// "result": &dest, -// }) +// avr.AsmFull( +// "str {value}, {result}", +// map[string]interface{}{ +// "value": 1 +// "result": &dest, +// }) // // You can use {} in the asm string (which expands to a register) to set the // return value. diff --git a/src/device/riscv/riscv.go b/src/device/riscv/riscv.go index b621a17c4..1c3c3e63a 100644 --- a/src/device/riscv/riscv.go +++ b/src/device/riscv/riscv.go @@ -9,12 +9,12 @@ func Asm(asm string) // effects, as it would otherwise be optimized away. The inline assembly string // recognizes template values in the form {name}, like so: // -// arm.AsmFull( -// "st {value}, {result}", -// map[string]interface{}{ -// "value": 1 -// "result": &dest, -// }) +// arm.AsmFull( +// "st {value}, {result}", +// map[string]interface{}{ +// "value": 1 +// "result": &dest, +// }) // // You can use {} in the asm string (which expands to a register) to set the // return value. diff --git a/src/examples/i2s/i2s.go b/src/examples/i2s/i2s.go index 2f2c2f5b2..4936d92ff 100644 --- a/src/examples/i2s/i2s.go +++ b/src/examples/i2s/i2s.go @@ -1,6 +1,5 @@ // Example using the i2s hardware interface on the Adafruit Circuit Playground Express // to read data from the onboard MEMS microphone. -// package main import ( diff --git a/src/internal/task/task_stack.go b/src/internal/task/task_stack.go index 59af65031..63a8fdc82 100644 --- a/src/internal/task/task_stack.go +++ b/src/internal/task/task_stack.go @@ -89,6 +89,7 @@ func swapTask(oldStack uintptr, newStack *uintptr) // startTask is a small wrapper function that sets up the first (and only) // argument to the new goroutine and makes sure it is exited when the goroutine // finishes. +// //go:extern tinygo_startTask var startTask [0]uint8 diff --git a/src/internal/task/task_stack_avr.go b/src/internal/task/task_stack_avr.go index 96b7034d9..3af801fe9 100644 --- a/src/internal/task/task_stack_avr.go +++ b/src/internal/task/task_stack_avr.go @@ -29,6 +29,7 @@ type calleeSavedRegs struct { // archInit runs architecture-specific setup for the goroutine startup. // Note: adding //go:noinline to work around an AVR backend bug. +// //go:noinline func (s *state) archInit(r *calleeSavedRegs, fn uintptr, args unsafe.Pointer) { // Store the initial sp for the startTask function (implemented in assembly). diff --git a/src/machine/board_arduino_mkr1000.go b/src/machine/board_arduino_mkr1000.go index a494eb7f1..133cb5b89 100644 --- a/src/machine/board_arduino_mkr1000.go +++ b/src/machine/board_arduino_mkr1000.go @@ -4,7 +4,6 @@ // This contains the pin mappings for the Arduino MKR1000 board. // // For more information, see: https://store.arduino.cc/usa/arduino-mkr1000-with-headers-mounted -// package machine // used to reset into bootloader diff --git a/src/machine/board_arduino_mkrwifi1010.go b/src/machine/board_arduino_mkrwifi1010.go index 03d4f11b6..931261d7a 100644 --- a/src/machine/board_arduino_mkrwifi1010.go +++ b/src/machine/board_arduino_mkrwifi1010.go @@ -4,7 +4,6 @@ // This contains the pin mappings for the Arduino MKR WiFi 1010 board. // // For more information, see: https://store.arduino.cc/usa/mkr-wifi-1010 -// package machine // used to reset into bootloader diff --git a/src/machine/board_arduino_nano33.go b/src/machine/board_arduino_nano33.go index 49cb09c83..9655dd66c 100644 --- a/src/machine/board_arduino_nano33.go +++ b/src/machine/board_arduino_nano33.go @@ -4,7 +4,6 @@ // This contains the pin mappings for the Arduino Nano33 IoT board. // // For more information, see: https://store.arduino.cc/nano-33-iot -// package machine // used to reset into bootloader diff --git a/src/machine/board_badger2040.go b/src/machine/board_badger2040.go index 2619af364..46e3ce566 100644 --- a/src/machine/board_badger2040.go +++ b/src/machine/board_badger2040.go @@ -6,7 +6,6 @@ // For more information, see: https://shop.pimoroni.com/products/badger-2040 // Also // - Badger 2040 schematic: https://cdn.shopify.com/s/files/1/0174/1800/files/badger_2040_schematic.pdf?v=1645702148 -// package machine import ( @@ -58,14 +57,15 @@ const ( // QSPI pins¿? const ( -/* TODO +/* + TODO + SPI0_SD0_PIN Pin = QSPI_SD0 SPI0_SD1_PIN Pin = QSPI_SD1 SPI0_SD2_PIN Pin = QSPI_SD2 SPI0_SD3_PIN Pin = QSPI_SD3 SPI0_SCK_PIN Pin = QSPI_SCLKGPIO6 SPI0_CS_PIN Pin = QSPI_CS - */ ) diff --git a/src/machine/board_nano-33-ble.go b/src/machine/board_nano-33-ble.go index e1a1b6b86..127484253 100644 --- a/src/machine/board_nano-33-ble.go +++ b/src/machine/board_nano-33-ble.go @@ -10,11 +10,11 @@ // // Special version of bossac is required. // This executable can be obtained two ways: -// 1) In Arduino IDE, install support for the board ("Arduino Mbed OS Nano Boards") -// Search for "tools/bossac/1.9.1-arduino2/bossac" in Arduino IDEs directory -// 2) Download https://downloads.arduino.cc/packages/package_index.json -// Search for "bossac-1.9.1-arduino2" in that file -// Download tarball for your OS and unpack it +// 1. In Arduino IDE, install support for the board ("Arduino Mbed OS Nano Boards") +// Search for "tools/bossac/1.9.1-arduino2/bossac" in Arduino IDEs directory +// 2. Download https://downloads.arduino.cc/packages/package_index.json +// Search for "bossac-1.9.1-arduino2" in that file +// Download tarball for your OS and unpack it // // Once you have the executable, make it accessible in your PATH as "bossac_arduino2". // @@ -29,7 +29,6 @@ // // SoftDevice overwrites original bootloader and flashing method described above is not avalable anymore. // Instead, please use debug probe and flash your code with "nano-33-ble-s140v7" target. -// package machine const HasLowFrequencyCrystal = true diff --git a/src/machine/board_nano-rp2040.go b/src/machine/board_nano-rp2040.go index 11dab88e4..898559730 100644 --- a/src/machine/board_nano-rp2040.go +++ b/src/machine/board_nano-rp2040.go @@ -10,7 +10,6 @@ // Also // - Datasheets: https://docs.arduino.cc/hardware/nano-rp2040-connect // - Nano RP2040 Connect technical reference: https://docs.arduino.cc/tutorials/nano-rp2040-connect/rp2040-01-technical-reference -// package machine import ( diff --git a/src/machine/board_p1am-100.go b/src/machine/board_p1am-100.go index e75d464b6..4d7410d58 100644 --- a/src/machine/board_p1am-100.go +++ b/src/machine/board_p1am-100.go @@ -4,7 +4,6 @@ // This contains the pin mappings for the ProductivityOpen P1AM-100 board. // // For more information, see: https://facts-engineering.github.io/ -// package machine // used to reset into bootloader diff --git a/src/machine/board_xiao-ble.go b/src/machine/board_xiao-ble.go index 9eae4ea74..ab8aa5c25 100644 --- a/src/machine/board_xiao-ble.go +++ b/src/machine/board_xiao-ble.go @@ -17,7 +17,6 @@ // // - https://wiki.seeedstudio.com/XIAO_BLE/ // - https://github.com/Seeed-Studio/ArduinoCore-mbed/tree/master/variants/SEEED_XIAO_NRF52840_SENSE -// package machine const HasLowFrequencyCrystal = true diff --git a/src/machine/board_xiao-rp2040.go b/src/machine/board_xiao-rp2040.go index 420319bd2..11f9a4d9c 100644 --- a/src/machine/board_xiao-rp2040.go +++ b/src/machine/board_xiao-rp2040.go @@ -6,7 +6,6 @@ // XIAO RP2040 is a microcontroller using the Raspberry Pi RP2040 chip. // // - https://wiki.seeedstudio.com/XIAO-RP2040/ -// package machine import ( diff --git a/src/machine/machine_atmega1280.go b/src/machine/machine_atmega1280.go index 7278173af..d8b92ad57 100644 --- a/src/machine/machine_atmega1280.go +++ b/src/machine/machine_atmega1280.go @@ -264,7 +264,7 @@ func (pwm PWM) Configure(config PWMConfig) error { // SetPeriod updates the period of this PWM peripheral. // To set a particular frequency, use the following formula: // -// period = 1e9 / frequency +// period = 1e9 / frequency // // If you use a period of 0, a period that works well for LEDs will be picked. // @@ -694,7 +694,7 @@ func (pwm PWM) SetInverting(channel uint8, inverting bool) { // cycle, in other words the fraction of time the channel output is high (or low // when inverted). For example, to set it to a 25% duty cycle, use: // -// pwm.Set(channel, pwm.Top() / 4) +// pwm.Set(channel, pwm.Top() / 4) // // pwm.Set(channel, 0) will set the output to low and pwm.Set(channel, // pwm.Top()) will set the output to high, assuming the output isn't inverted. diff --git a/src/machine/machine_atmega328p.go b/src/machine/machine_atmega328p.go index ee92c1b52..a7d5d0c20 100644 --- a/src/machine/machine_atmega328p.go +++ b/src/machine/machine_atmega328p.go @@ -134,7 +134,7 @@ func (pwm PWM) Configure(config PWMConfig) error { // SetPeriod updates the period of this PWM peripheral. // To set a particular frequency, use the following formula: // -// period = 1e9 / frequency +// period = 1e9 / frequency // // If you use a period of 0, a period that works well for LEDs will be picked. // @@ -375,7 +375,7 @@ func (pwm PWM) SetInverting(channel uint8, inverting bool) { // cycle, in other words the fraction of time the channel output is high (or low // when inverted). For example, to set it to a 25% duty cycle, use: // -// pwm.Set(channel, pwm.Top() / 4) +// pwm.Set(channel, pwm.Top() / 4) // // pwm.Set(channel, 0) will set the output to low and pwm.Set(channel, // pwm.Top()) will set the output to high, assuming the output isn't inverted. diff --git a/src/machine/machine_atsamd21.go b/src/machine/machine_atsamd21.go index 01dc9a02c..a24e52539 100644 --- a/src/machine/machine_atsamd21.go +++ b/src/machine/machine_atsamd21.go @@ -5,7 +5,6 @@ // // Datasheet: // http://ww1.microchip.com/downloads/en/DeviceDoc/SAMD21-Family-DataSheet-DS40001882D.pdf -// package machine import ( @@ -88,10 +87,11 @@ const ( // SERCOM and SERCOM-ALT. // // Observations: -// * There are six SERCOMs. Those SERCOM numbers can be encoded in 3 bits. -// * Even pad numbers are always on even pins, and odd pad numbers are always on +// - There are six SERCOMs. Those SERCOM numbers can be encoded in 3 bits. +// - Even pad numbers are always on even pins, and odd pad numbers are always on // odd pins. -// * Pin pads come in pairs. If PA00 has pad 0, then PA01 has pad 1. +// - Pin pads come in pairs. If PA00 has pad 0, then PA01 has pad 1. +// // With this information, we can encode SERCOM pin/pad numbers much more // efficiently. First of all, due to pads coming in pairs, we can ignore half // the pins: the information for an odd pin can be calculated easily from the @@ -1285,17 +1285,16 @@ var ( // This form sends the bytes in tx buffer, putting the resulting bytes read into the rx buffer. // Note that the tx and rx buffers must be the same size: // -// spi.Tx(tx, rx) +// spi.Tx(tx, rx) // // This form sends the tx buffer, ignoring the result. Useful for sending "commands" that return zeros // until all the bytes in the command packet have been received: // -// spi.Tx(tx, nil) +// spi.Tx(tx, nil) // // This form sends zeros, putting the result into the rx buffer. Good for reading a "result packet": // -// spi.Tx(nil, rx) -// +// spi.Tx(nil, rx) func (spi SPI) Tx(w, r []byte) error { switch { case w == nil: @@ -1441,7 +1440,7 @@ func (tcc *TCC) Configure(config PWMConfig) error { // SetPeriod updates the period of this TCC peripheral. // To set a particular frequency, use the following formula: // -// period = 1e9 / frequency +// period = 1e9 / frequency // // If you use a period of 0, a period that works well for LEDs will be picked. // @@ -1709,7 +1708,7 @@ func (tcc *TCC) SetInverting(channel uint8, inverting bool) { // cycle, in other words the fraction of time the channel output is high (or low // when inverted). For example, to set it to a 25% duty cycle, use: // -// tcc.Set(channel, tcc.Top() / 4) +// tcc.Set(channel, tcc.Top() / 4) // // tcc.Set(channel, 0) will set the output to low and tcc.Set(channel, // tcc.Top()) will set the output to high, assuming the output isn't inverted. diff --git a/src/machine/machine_atsamd21e18.go b/src/machine/machine_atsamd21e18.go index f019d6125..26e251678 100644 --- a/src/machine/machine_atsamd21e18.go +++ b/src/machine/machine_atsamd21e18.go @@ -5,7 +5,6 @@ // // Datasheet: // http://ww1.microchip.com/downloads/en/DeviceDoc/SAMD21-Family-DataSheet-DS40001882D.pdf -// package machine import ( diff --git a/src/machine/machine_atsamd21g18.go b/src/machine/machine_atsamd21g18.go index aece56f47..c933f4bfe 100644 --- a/src/machine/machine_atsamd21g18.go +++ b/src/machine/machine_atsamd21g18.go @@ -5,7 +5,6 @@ // // Datasheet: // http://ww1.microchip.com/downloads/en/DeviceDoc/SAMD21-Family-DataSheet-DS40001882D.pdf -// package machine import ( diff --git a/src/machine/machine_atsamd51.go b/src/machine/machine_atsamd51.go index 54bd1fc9f..dd0ba9994 100644 --- a/src/machine/machine_atsamd51.go +++ b/src/machine/machine_atsamd51.go @@ -5,7 +5,6 @@ // // Datasheet: // http://ww1.microchip.com/downloads/en/DeviceDoc/60001507C.pdf -// package machine import ( @@ -250,12 +249,13 @@ const ( // SERCOM and SERCOM-ALT. // // Observations: -// * There are eight SERCOMs. Those SERCOM numbers can be encoded in 4 bits. -// * Even pad numbers are usually on even pins, and odd pad numbers are usually +// - There are eight SERCOMs. Those SERCOM numbers can be encoded in 4 bits. +// - Even pad numbers are usually on even pins, and odd pad numbers are usually // on odd pins. The exception is SERCOM-ALT, which sometimes swaps pad 0 and 1. // With that, there is still an invariant that the pad number for an odd pin is // the pad number for the corresponding even pin with the low bit toggled. -// * Pin pads come in pairs. If PA00 has pad 0, then PA01 has pad 1. +// - Pin pads come in pairs. If PA00 has pad 0, then PA01 has pad 1. +// // With this information, we can encode SERCOM pin/pad numbers much more // efficiently. Due to pads coming in pairs, we can ignore half the pins: the // information for an odd pin can be calculated easily from the preceding even @@ -1538,17 +1538,16 @@ var ( // This form sends the bytes in tx buffer, putting the resulting bytes read into the rx buffer. // Note that the tx and rx buffers must be the same size: // -// spi.Tx(tx, rx) +// spi.Tx(tx, rx) // // This form sends the tx buffer, ignoring the result. Useful for sending "commands" that return zeros // until all the bytes in the command packet have been received: // -// spi.Tx(tx, nil) +// spi.Tx(tx, nil) // // This form sends zeros, putting the result into the rx buffer. Good for reading a "result packet": // -// spi.Tx(nil, rx) -// +// spi.Tx(nil, rx) func (spi SPI) Tx(w, r []byte) error { switch { case w == nil: @@ -1672,7 +1671,7 @@ func (tcc *TCC) Configure(config PWMConfig) error { // SetPeriod updates the period of this TCC peripheral. // To set a particular frequency, use the following formula: // -// period = 1e9 / frequency +// period = 1e9 / frequency // // If you use a period of 0, a period that works well for LEDs will be picked. // @@ -1962,7 +1961,7 @@ func (tcc *TCC) SetInverting(channel uint8, inverting bool) { // cycle, in other words the fraction of time the channel output is high (or low // when inverted). For example, to set it to a 25% duty cycle, use: // -// tcc.Set(channel, tcc.Top() / 4) +// tcc.Set(channel, tcc.Top() / 4) // // tcc.Set(channel, 0) will set the output to low and tcc.Set(channel, // tcc.Top()) will set the output to high, assuming the output isn't inverted. diff --git a/src/machine/machine_atsamd51g19.go b/src/machine/machine_atsamd51g19.go index e5c9d4593..c0dc1993c 100644 --- a/src/machine/machine_atsamd51g19.go +++ b/src/machine/machine_atsamd51g19.go @@ -5,7 +5,6 @@ // // Datasheet: // http://ww1.microchip.com/downloads/en/DeviceDoc/60001507C.pdf -// package machine import "device/sam" diff --git a/src/machine/machine_atsamd51j19.go b/src/machine/machine_atsamd51j19.go index a49ed2980..28c73060d 100644 --- a/src/machine/machine_atsamd51j19.go +++ b/src/machine/machine_atsamd51j19.go @@ -5,7 +5,6 @@ // // Datasheet: // http://ww1.microchip.com/downloads/en/DeviceDoc/SAM_D5xE5x_Family_Data_Sheet_DS60001507F.pdf -// package machine import "device/sam" diff --git a/src/machine/machine_atsamd51j20.go b/src/machine/machine_atsamd51j20.go index e8146b9ae..411b029d2 100644 --- a/src/machine/machine_atsamd51j20.go +++ b/src/machine/machine_atsamd51j20.go @@ -5,7 +5,6 @@ // // Datasheet: // http://ww1.microchip.com/downloads/en/DeviceDoc/60001507C.pdf -// package machine import "device/sam" diff --git a/src/machine/machine_atsamd51p19.go b/src/machine/machine_atsamd51p19.go index 9ad041f06..c3026966e 100644 --- a/src/machine/machine_atsamd51p19.go +++ b/src/machine/machine_atsamd51p19.go @@ -5,7 +5,6 @@ // // Datasheet: // http://ww1.microchip.com/downloads/en/DeviceDoc/60001507C.pdf -// package machine import "device/sam" diff --git a/src/machine/machine_atsamd51p20.go b/src/machine/machine_atsamd51p20.go index a4009f91e..b418faec5 100644 --- a/src/machine/machine_atsamd51p20.go +++ b/src/machine/machine_atsamd51p20.go @@ -5,7 +5,6 @@ // // Datasheet: // http://ww1.microchip.com/downloads/en/DeviceDoc/60001507C.pdf -// package machine import "device/sam" diff --git a/src/machine/machine_atsame51j19.go b/src/machine/machine_atsame51j19.go index fd94c923e..2f3ba62f0 100644 --- a/src/machine/machine_atsame51j19.go +++ b/src/machine/machine_atsame51j19.go @@ -5,7 +5,6 @@ // // Datasheet: // http://ww1.microchip.com/downloads/en/DeviceDoc/SAM_D5xE5x_Family_Data_Sheet_DS60001507F.pdf -// package machine import "device/sam" diff --git a/src/machine/machine_atsame54p20.go b/src/machine/machine_atsame54p20.go index 274ded1a2..02661a601 100644 --- a/src/machine/machine_atsame54p20.go +++ b/src/machine/machine_atsame54p20.go @@ -5,7 +5,6 @@ // // Datasheet: // http://ww1.microchip.com/downloads/en/DeviceDoc/60001507C.pdf -// package machine import "device/sam" diff --git a/src/machine/machine_esp32.go b/src/machine/machine_esp32.go index dd3ddc41e..c17f431a5 100644 --- a/src/machine/machine_esp32.go +++ b/src/machine/machine_esp32.go @@ -462,7 +462,6 @@ func (spi SPI) Transfer(w byte) (byte, error) { // interface, there must always be the same number of bytes written as bytes read. // This is accomplished by sending zero bits if r is bigger than w or discarding // the incoming data if w is bigger than r. -// func (spi SPI) Tx(w, r []byte) error { toTransfer := len(w) if len(r) > toTransfer { diff --git a/src/machine/machine_mimxrt1062.go b/src/machine/machine_mimxrt1062.go index ceacab706..3e20bd679 100644 --- a/src/machine/machine_mimxrt1062.go +++ b/src/machine/machine_mimxrt1062.go @@ -726,7 +726,7 @@ func (p Pin) getPad() (pad *volatile.Register32, mux *volatile.Register32) { // // The reference manual refers to this functionality as a "Daisy Chain". The // associated docs are found in the i.MX RT1060 Processor Reference Manual: -// "Chapter 11.3.3 Daisy chain - multi pads driving same module input pin" +// "Chapter 11.3.3 Daisy chain - multi pads driving same module input pin" type muxSelect struct { mux uint8 // AF mux selection (NOT a Pin type) sel *volatile.Register32 // AF selection register diff --git a/src/machine/machine_mimxrt1062_spi.go b/src/machine/machine_mimxrt1062_spi.go index f5f7607bc..6068f5050 100644 --- a/src/machine/machine_mimxrt1062_spi.go +++ b/src/machine/machine_mimxrt1062_spi.go @@ -204,7 +204,8 @@ func (spi *SPI) hasHardwareCSPin() bool { // getClockDivisor finds the SPI prescalar that minimizes the error between // requested frequency and possible frequencies available with the LPSPI clock. // this routine is based on Teensyduino (libraries/SPI/SPI.cpp): -// `void SPIClass::setClockDivider_noInline(uint32_t clk)` +// +// void SPIClass::setClockDivider_noInline(uint32_t clk) func (spi *SPI) getClockDivisor(freq uint32) uint32 { const clock = 132000000 // LPSPI root clock frequency (PLL2) d := uint32(clock) diff --git a/src/machine/machine_mimxrt1062_uart.go b/src/machine/machine_mimxrt1062_uart.go index 95813d836..98bf477b8 100644 --- a/src/machine/machine_mimxrt1062_uart.go +++ b/src/machine/machine_mimxrt1062_uart.go @@ -188,8 +188,10 @@ func (uart *UART) WriteByte(c byte) error { // // This is an integral (non-floating point) translation of the logic at the // beginning of: -// void HardwareSerial::begin(uint32_t baud, uint16_t format) -// (from Teensyduino: `cores/teensy4/HardwareSerial.cpp`) +// +// void HardwareSerial::begin(uint32_t baud, uint16_t format) +// +// (from Teensyduino: cores/teensy4/HardwareSerial.cpp) // // We don't want to use floating point here in case it gets called from an ISR // or very early during system init. diff --git a/src/machine/machine_nrf51.go b/src/machine/machine_nrf51.go index 372c8692c..34b0137d1 100644 --- a/src/machine/machine_nrf51.go +++ b/src/machine/machine_nrf51.go @@ -133,17 +133,16 @@ func (spi SPI) Transfer(w byte) (byte, error) { // This form sends the bytes in tx buffer, putting the resulting bytes read into the rx buffer. // Note that the tx and rx buffers must be the same size: // -// spi.Tx(tx, rx) +// spi.Tx(tx, rx) // // This form sends the tx buffer, ignoring the result. Useful for sending "commands" that return zeros // until all the bytes in the command packet have been received: // -// spi.Tx(tx, nil) +// spi.Tx(tx, nil) // // This form sends zeros, putting the result into the rx buffer. Good for reading a "result packet": // -// spi.Tx(nil, rx) -// +// spi.Tx(nil, rx) func (spi SPI) Tx(w, r []byte) error { var err error diff --git a/src/machine/machine_nrf528xx.go b/src/machine/machine_nrf528xx.go index 02fe9ebc1..b3f88ad14 100644 --- a/src/machine/machine_nrf528xx.go +++ b/src/machine/machine_nrf528xx.go @@ -299,7 +299,7 @@ func (pwm *PWM) Configure(config PWMConfig) error { // SetPeriod updates the period of this PWM peripheral. // To set a particular frequency, use the following formula: // -// period = 1e9 / frequency +// period = 1e9 / frequency // // If you use a period of 0, a period that works well for LEDs will be picked. // @@ -449,7 +449,7 @@ func (pwm *PWM) SetInverting(channel uint8, inverting bool) { // Set updates the channel value. This is used to control the channel duty // cycle. For example, to set it to a 25% duty cycle, use: // -// ch.Set(ch.Top() / 4) +// ch.Set(ch.Top() / 4) // // ch.Set(0) will set the output to low and ch.Set(ch.Top()) will set the output // to high, assuming the output isn't inverted. diff --git a/src/machine/machine_rp2040_i2c.go b/src/machine/machine_rp2040_i2c.go index 7758d4417..3e75e7e68 100644 --- a/src/machine/machine_rp2040_i2c.go +++ b/src/machine/machine_rp2040_i2c.go @@ -66,10 +66,12 @@ var ( // Passing a nil value for w or r skips the transfer corresponding to write // or read, respectively. // -// i2c.Tx(addr, nil, r) +// i2c.Tx(addr, nil, r) +// // Performs only a read transfer. // -// i2c.Tx(addr, w, nil) +// i2c.Tx(addr, w, nil) +// // Performs only a write transfer. func (i2c *I2C) Tx(addr uint16, w, r []byte) error { // timeout in microseconds. @@ -79,11 +81,14 @@ func (i2c *I2C) Tx(addr uint16, w, r []byte) error { // Configure initializes i2c peripheral and configures I2C config's pins passed. // Here's a list of valid SDA and SCL GPIO pins on bus I2C0 of the rp2040: -// SDA: 0, 4, 8, 12, 16, 20 -// SCL: 1, 5, 9, 13, 17, 21 +// +// SDA: 0, 4, 8, 12, 16, 20 +// SCL: 1, 5, 9, 13, 17, 21 +// // Same as above for I2C1 bus: -// SDA: 2, 6, 10, 14, 18, 26 -// SCL: 3, 7, 11, 15, 19, 27 +// +// SDA: 2, 6, 10, 14, 18, 26 +// SCL: 3, 7, 11, 15, 19, 27 func (i2c *I2C) Configure(config I2CConfig) error { const defaultBaud uint32 = 100_000 // 100kHz standard mode if config.SCL == 0 { @@ -107,6 +112,7 @@ func (i2c *I2C) Configure(config I2CConfig) error { // SetBaudRate sets the I2C frequency. It has the side effect of also // enabling the I2C hardware if disabled beforehand. +// //go:inline func (i2c *I2C) SetBaudRate(br uint32) error { @@ -168,6 +174,7 @@ func (i2c *I2C) enable() { } // Implemented as per 4.3.10.3. Disabling DW_apb_i2c section. +// //go:inline func (i2c *I2C) disable() error { const MAX_T_POLL_COUNT = 64 // 64 us timeout corresponds to around 1000kb/s i2c transfer rate. @@ -203,6 +210,7 @@ func (i2c *I2C) init(config I2CConfig) error { } // reset sets I2C register RESET bits in the reset peripheral and then clears them. +// //go:inline func (i2c *I2C) reset() { resetVal := i2c.deinit() @@ -213,6 +221,7 @@ func (i2c *I2C) reset() { } // deinit sets reset bit for I2C. Must call reset to reenable I2C after deinit. +// //go:inline func (i2c *I2C) deinit() (resetVal uint32) { switch { @@ -348,18 +357,21 @@ func (i2c *I2C) tx(addr uint8, tx, rx []byte, timeout_us uint64) (err error) { } // writeAvailable determines non-blocking write space available +// //go:inline func (i2c *I2C) writeAvailable() uint32 { return rp.I2C0_IC_COMP_PARAM_1_TX_BUFFER_DEPTH_Pos - i2c.Bus.IC_TXFLR.Get() } // readAvailable determines number of bytes received +// //go:inline func (i2c *I2C) readAvailable() uint32 { return i2c.Bus.IC_RXFLR.Get() } // Equivalent to IC_CLR_TX_ABRT.Get() (side effect clears ABORT_REASON) +// //go:inline func (i2c *I2C) clearAbortReason() { // Note clearing the abort flag also clears the reason, and @@ -369,13 +381,16 @@ func (i2c *I2C) clearAbortReason() { } // getAbortReason reads IC_TX_ABRT_SOURCE register. +// //go:inline func (i2c *I2C) getAbortReason() uint32 { return i2c.Bus.IC_TX_ABRT_SOURCE.Get() } // returns true if RAW_INTR_STAT bits in mask are all set. performs: -// RAW_INTR_STAT & mask == mask +// +// RAW_INTR_STAT & mask == mask +// //go:inline func (i2c *I2C) interrupted(mask uint32) bool { reg := i2c.Bus.IC_RAW_INTR_STAT.Get() diff --git a/src/machine/machine_rp2040_pwm.go b/src/machine/machine_rp2040_pwm.go index a355be4c8..330968a6a 100644 --- a/src/machine/machine_rp2040_pwm.go +++ b/src/machine/machine_rp2040_pwm.go @@ -45,8 +45,10 @@ type pwmGroup struct { } // Equivalent of -// var pwmSlice []pwmGroup = (*[8]pwmGroup)(unsafe.Pointer(rp.PWM))[:] -// return &pwmSlice[index] +// +// var pwmSlice []pwmGroup = (*[8]pwmGroup)(unsafe.Pointer(rp.PWM))[:] +// return &pwmSlice[index] +// // 0x14 is the size of a pwmGroup. func getPWMGroup(index uintptr) *pwmGroup { return (*pwmGroup)(unsafe.Pointer(uintptr(unsafe.Pointer(rp.PWM)) + 0x14*index)) @@ -112,7 +114,7 @@ func (pwm *pwmGroup) peripheral() uint8 { // SetPeriod updates the period of this PWM peripheral in nanoseconds. // To set a particular frequency, use the following formula: // -// period = 1e9 / frequency +// period = 1e9 / frequency // // Where frequency is in hertz. If you use a period of 0, a period // that works well for LEDs will be picked. @@ -167,7 +169,7 @@ func (p *pwmGroup) SetInverting(channel uint8, inverting bool) { // cycle, in other words the fraction of time the channel output is high (or low // when inverted). For example, to set it to a 25% duty cycle, use: // -// pwm.Set(channel, pwm.Top() / 4) +// pwm.Set(channel, pwm.Top() / 4) // // pwm.Set(channel, 0) will set the output to low and pwm.Set(channel, // pwm.Top()) will set the output to high, assuming the output isn't inverted. @@ -238,14 +240,17 @@ func (pwm *pwmGroup) setPhaseCorrect(correct bool) { } // Takes any of the following: -// rp.PWM_CH0_CSR_DIVMODE_DIV, rp.PWM_CH0_CSR_DIVMODE_FALL, -// rp.PWM_CH0_CSR_DIVMODE_LEVEL, rp.PWM_CH0_CSR_DIVMODE_RISE +// +// rp.PWM_CH0_CSR_DIVMODE_DIV, rp.PWM_CH0_CSR_DIVMODE_FALL, +// rp.PWM_CH0_CSR_DIVMODE_LEVEL, rp.PWM_CH0_CSR_DIVMODE_RISE func (pwm *pwmGroup) setDivMode(mode uint32) { pwm.CSR.ReplaceBits(mode<<rp.PWM_CH0_CSR_DIVMODE_Pos, rp.PWM_CH0_CSR_DIVMODE_Msk, 0) } // setPeriod sets the pwm peripheral period (frequency). Calculates DIV_INT,DIV_FRAC and sets it from following equation: -// cycles = (TOP+1) * (CSRPHCorrect + 1) * (DIV_INT + DIV_FRAC/16) +// +// cycles = (TOP+1) * (CSRPHCorrect + 1) * (DIV_INT + DIV_FRAC/16) +// // where cycles is amount of clock cycles per PWM period. func (pwm *pwmGroup) setPeriod(period uint64) error { // This period calculation algorithm consists of @@ -303,7 +308,7 @@ func (pwm *pwmGroup) setPeriod(period uint64) error { // frac's (DIV_FRAC) default value on reset is 0. Max value for frac is 15 (4 bits). This is known as a fixed-point // fractional number. // -// cycles = (TOP+1) * (CSRPHCorrect + 1) * (DIV_INT + DIV_FRAC/16) +// cycles = (TOP+1) * (CSRPHCorrect + 1) * (DIV_INT + DIV_FRAC/16) func (pwm *pwmGroup) setClockDiv(Int, frac uint8) { pwm.DIV.ReplaceBits((uint32(frac)<<rp.PWM_CH0_DIV_FRAC_Pos)| u32max(uint32(Int), 1)<<rp.PWM_CH0_DIV_INT_Pos, rp.PWM_CH0_DIV_FRAC_Msk|rp.PWM_CH0_DIV_INT_Msk, 0) diff --git a/src/machine/machine_rp2040_spi.go b/src/machine/machine_rp2040_spi.go index 8e5525413..bf97403a7 100644 --- a/src/machine/machine_rp2040_spi.go +++ b/src/machine/machine_rp2040_spi.go @@ -58,21 +58,21 @@ const _SPITimeout = 10 * 1000 // 10 ms // This form sends the bytes in tx buffer, putting the resulting bytes read into the rx buffer. // Note that the tx and rx buffers must be the same size: // -// spi.Tx(tx, rx) +// spi.Tx(tx, rx) // // This form sends the tx buffer, ignoring the result. Useful for sending "commands" that return zeros // until all the bytes in the command packet have been received: // -// spi.Tx(tx, nil) +// spi.Tx(tx, nil) // // This form sends zeros, putting the result into the rx buffer. Good for reading a "result packet": // -// spi.Tx(nil, rx) +// spi.Tx(nil, rx) // // Remark: This implementation (RP2040) allows reading into buffer with a custom repeated // value on tx. // -// spi.Tx([]byte{0xff}, rx) // may cause unwanted heap allocations. +// spi.Tx([]byte{0xff}, rx) // may cause unwanted heap allocations. // // This form sends 0xff and puts the result into rx buffer. Useful for reading from SD cards // which require 0xff input on SI. @@ -150,13 +150,17 @@ func (spi SPI) GetBaudRate() uint32 { // Default baudrate of 115200 is used if Frequency == 0. Default // word length (data bits) is 8. // Below is a list of GPIO pins corresponding to SPI0 bus on the rp2040: -// SI : 0, 4, 17 a.k.a RX and MISO (if rp2040 is master) -// SO : 3, 7, 19 a.k.a TX and MOSI (if rp2040 is master) -// SCK: 2, 6, 18 +// +// SI : 0, 4, 17 a.k.a RX and MISO (if rp2040 is master) +// SO : 3, 7, 19 a.k.a TX and MOSI (if rp2040 is master) +// SCK: 2, 6, 18 +// // SPI1 bus GPIO pins: -// SI : 8, 12 -// SO : 11, 15 -// SCK: 10, 14 +// +// SI : 8, 12 +// SO : 11, 15 +// SCK: 10, 14 +// // No pin configuration is needed of SCK, SDO and SDI needed after calling Configure. func (spi SPI) Configure(config SPIConfig) error { const defaultBaud uint32 = 115200 @@ -217,6 +221,7 @@ func (spi SPI) setFormat(databits, mode uint8, frameFormat uint32) { } // reset resets SPI and waits until reset is done. +// //go:inline func (spi SPI) reset() { resetVal := spi.deinit() @@ -240,12 +245,14 @@ func (spi SPI) deinit() (resetVal uint32) { } // isWritable returns false if no space is available to write. True if a write is possible +// //go:inline func (spi SPI) isWritable() bool { return spi.Bus.SSPSR.HasBits(rp.SPI0_SSPSR_TNF) } // isReadable returns true if a read is possible i.e. data is present +// //go:inline func (spi SPI) isReadable() bool { return spi.Bus.SSPSR.HasBits(rp.SPI0_SSPSR_RNE) diff --git a/src/machine/machine_stm32_moder_gpio.go b/src/machine/machine_stm32_moder_gpio.go index b24ac48c3..c1439eb5a 100644 --- a/src/machine/machine_stm32_moder_gpio.go +++ b/src/machine/machine_stm32_moder_gpio.go @@ -72,7 +72,8 @@ func (p Pin) Configure(config PinConfig) { } // Configure this pin with the given configuration including alternate -// function mapping if necessary. +// +// function mapping if necessary. func (p Pin) ConfigureAltFunc(config PinConfig, altFunc uint8) { // Configure the GPIO pin. p.enableClock() diff --git a/src/machine/machine_stm32_tim.go b/src/machine/machine_stm32_tim.go index 02c6c7a16..4f607d036 100644 --- a/src/machine/machine_stm32_tim.go +++ b/src/machine/machine_stm32_tim.go @@ -115,7 +115,7 @@ func (t *TIM) SetMatchInterrupt(channel uint8, callback ChannelCallback) error { // SetPeriod updates the period of this PWM peripheral. // To set a particular frequency, use the following formula: // -// period = 1e9 / frequency +// period = 1e9 / frequency // // If you use a period of 0, a period that works well for LEDs will be picked. // @@ -195,7 +195,7 @@ func (t *TIM) Channel(pin Pin) (uint8, error) { // Set updates the channel value. This is used to control the channel duty // cycle. For example, to set it to a 25% duty cycle, use: // -// t.Set(ch, t.Top() / 4) +// t.Set(ch, t.Top() / 4) // // ch.Set(0) will set the output to low and ch.Set(ch.Top()) will set the output // to high, assuming the output isn't inverted. diff --git a/src/machine/spi.go b/src/machine/spi.go index a8d4d329a..b815e7a43 100644 --- a/src/machine/spi.go +++ b/src/machine/spi.go @@ -25,17 +25,16 @@ var ( // This form sends the bytes in tx buffer, putting the resulting bytes read into the rx buffer. // Note that the tx and rx buffers must be the same size: // -// spi.Tx(tx, rx) +// spi.Tx(tx, rx) // // This form sends the tx buffer, ignoring the result. Useful for sending "commands" that return zeros // until all the bytes in the command packet have been received: // -// spi.Tx(tx, nil) +// spi.Tx(tx, nil) // // This form sends zeros, putting the result into the rx buffer. Good for reading a "result packet": // -// spi.Tx(nil, rx) -// +// spi.Tx(nil, rx) func (spi SPI) Tx(w, r []byte) error { var err error diff --git a/src/machine/usb/hid/keyboard/keyboard.go b/src/machine/usb/hid/keyboard/keyboard.go index 7a51eff41..18fd0bb2e 100644 --- a/src/machine/usb/hid/keyboard/keyboard.go +++ b/src/machine/usb/hid/keyboard/keyboard.go @@ -114,24 +114,21 @@ func (kb *keyboard) Write(b []byte) (n int, err error) { // stateful method with respect to the receiver Keyboard, meaning that its exact // behavior will depend on the current state of its UTF-8 decode state machine: // -// (a) If the given byte is a valid ASCII encoding (0-127), then a keypress -// sequence is immediately transmitted for the respective Keycode. +// 1. If the given byte is a valid ASCII encoding (0-127), then a keypress +// sequence is immediately transmitted for the respective Keycode. +// 2. If the given byte represents the final byte in a multi-byte codepoint, +// then a keypress sequence is immediately transmitted by translating the +// multi-byte codepoint to its respective Keycode. +// 3. If the given byte appears to represent high bits for a multi-byte +// codepoint, then the bits are copied to the receiver's internal state +// machine buffer for use by a subsequent call to WriteByte() (or Write()) +// that completes the codepoint. +// 4. If the given byte is out of range, or contains illegal bits for the +// current state of the UTF-8 decoder, then the UTF-8 decode state machine +// is reset to its initial state. // -// (b) If the given byte represents the final byte in a multi-byte codepoint, -// then a keypress sequence is immediately transmitted by translating the -// multi-byte codepoint to its respective Keycode. -// -// (c) If the given byte appears to represent high bits for a multi-byte -// codepoint, then the bits are copied to the receiver's internal state -// machine buffer for use by a subsequent call to WriteByte() (or Write()) -// that completes the codepoint. -// -// (d) If the given byte is out of range, or contains illegal bits for the -// current state of the UTF-8 decoder, then the UTF-8 decode state machine -// is reset to its initial state. -// -// In cases (c) and (d), a keypress sequence is not generated and no data is -// transmitted. In case (c), additional bytes must be received via WriteByte() +// In cases 3 and 4, a keypress sequence is not generated and no data is +// transmitted. In case 3, additional bytes must be received via WriteByte() // (or Write()) to complete or discard the current codepoint. func (kb *keyboard) WriteByte(b byte) error { switch { @@ -211,13 +208,13 @@ func (kb *keyboard) writeKeycode(c Keycode) error { // // The following values of Keycode are supported: // -// 0x0020 - 0x007F ASCII (U+0020 to U+007F) [USES LAYOUT] -// 0x0080 - 0xC1FF Unicode (U+0080 to U+C1FF) [USES LAYOUT] -// 0xC200 - 0xDFFF UTF-8 packed (U+0080 to U+07FF) [USES LAYOUT] -// 0xE000 - 0xE0FF Modifier key (bitmap, 8 keys, Shift/Ctrl/Alt/GUI) -// 0xE200 - 0xE2FF System key (HID usage code, page 1) -// 0xE400 - 0xE7FF Media/Consumer key (HID usage code, page 12) -// 0xF000 - 0xFFFF Normal key (HID usage code, page 7) +// 0x0020 - 0x007F ASCII (U+0020 to U+007F) [USES LAYOUT] +// 0x0080 - 0xC1FF Unicode (U+0080 to U+C1FF) [USES LAYOUT] +// 0xC200 - 0xDFFF UTF-8 packed (U+0080 to U+07FF) [USES LAYOUT] +// 0xE000 - 0xE0FF Modifier key (bitmap, 8 keys, Shift/Ctrl/Alt/GUI) +// 0xE200 - 0xE2FF System key (HID usage code, page 1) +// 0xE400 - 0xE7FF Media/Consumer key (HID usage code, page 12) +// 0xF000 - 0xFFFF Normal key (HID usage code, page 7) func (kb *keyboard) Press(c Keycode) error { if err := kb.Down(c); nil != err { return err diff --git a/src/machine/usb/hid/keyboard/keycode.go b/src/machine/usb/hid/keyboard/keycode.go index c9e3b9350..8b26eaccd 100644 --- a/src/machine/usb/hid/keyboard/keycode.go +++ b/src/machine/usb/hid/keyboard/keycode.go @@ -5,6 +5,7 @@ type Keycode uint16 // keycode returns the given Unicode codepoint translated to a Keycode sequence. // Unicode codepoints greater than U+FFFF are unsupported. +// //go:inline func keycode(p uint16) Keycode { if p < 0x80 { diff --git a/src/net/mac.go b/src/net/mac.go index 815b2738f..2bad98c46 100644 --- a/src/net/mac.go +++ b/src/net/mac.go @@ -28,6 +28,7 @@ func (a HardwareAddr) String() string { // ParseMAC parses s as an IEEE 802 MAC-48, EUI-48, EUI-64, or a 20-octet // IP over InfiniBand link-layer address using one of the following formats: +// // 00:00:5e:00:53:01 // 02:00:5e:10:00:00:00:01 // 00:00:00:00:fe:80:00:00:00:00:00:00:02:00:5e:10:00:00:00:01 diff --git a/src/reflect/deepequal.go b/src/reflect/deepequal.go index 49dac165d..f84ddc8b5 100644 --- a/src/reflect/deepequal.go +++ b/src/reflect/deepequal.go @@ -132,7 +132,7 @@ func deepValueEqual(v1, v2 Value, visited map[visit]struct{}) bool { } } -// DeepEqual reports whether x and y are ``deeply equal,'' defined as follows. +// DeepEqual reports whether x and y are “deeply equal”, defined as follows. // Two values of identical type are deeply equal if one of the following cases applies. // Values of distinct types are never deeply equal. // diff --git a/src/reflect/sidetables.go b/src/reflect/sidetables.go index 2268d3ebf..ea26ff767 100644 --- a/src/reflect/sidetables.go +++ b/src/reflect/sidetables.go @@ -7,6 +7,7 @@ import ( // This stores a varint for each named type. Named types are identified by their // name instead of by their type. The named types stored in this struct are // non-basic types: pointer, struct, and channel. +// //go:extern reflect.namedNonBasicTypesSidetable var namedNonBasicTypesSidetable uintptr diff --git a/src/reflect/strconv.go b/src/reflect/strconv.go index 9b07cb458..b75d51341 100644 --- a/src/reflect/strconv.go +++ b/src/reflect/strconv.go @@ -34,10 +34,10 @@ func unhex(b byte) (v rune, ok bool) { // or character literal represented by the string s. // It returns four values: // -// 1) value, the decoded Unicode code point or byte value; -// 2) multibyte, a boolean indicating whether the decoded character requires a multibyte UTF-8 representation; -// 3) tail, the remainder of the string after the character; and -// 4) an error that will be nil if the character is syntactically valid. +// 1. value, the decoded Unicode code point or byte value; +// 2. multibyte, a boolean indicating whether the decoded character requires a multibyte UTF-8 representation; +// 3. tail, the remainder of the string after the character; and +// 4. an error that will be nil if the character is syntactically valid. // // The second argument, quote, specifies the type of literal being parsed // and therefore which escaped quote character is permitted. diff --git a/src/runtime/chan.go b/src/runtime/chan.go index 9b13a983a..5bc05929d 100644 --- a/src/runtime/chan.go +++ b/src/runtime/chan.go @@ -139,6 +139,7 @@ func chanMake(elementSize uintptr, bufSize uintptr) *channel { // Return the number of entries in this chan, called from the len builtin. // A nil chan is defined as having length 0. +// //go:inline func chanLen(c *channel) int { if c == nil { @@ -155,6 +156,7 @@ func chanLenUnsafePointer(p unsafe.Pointer) int { // Return the capacity of this chan, called from the cap builtin. // A nil chan is defined as having capacity 0. +// //go:inline func chanCap(c *channel) int { if c == nil { diff --git a/src/runtime/env_linux.go b/src/runtime/env_linux.go index 2d0a7ea56..cfe8c7f85 100644 --- a/src/runtime/env_linux.go +++ b/src/runtime/env_linux.go @@ -5,6 +5,7 @@ package runtime // Update the C environment if cgo is loaded. // Called from syscall.Setenv. +// //go:linkname syscall_setenv_c syscall.setenv_c func syscall_setenv_c(key string, val string) { keydata := cstring(key) @@ -16,6 +17,7 @@ func syscall_setenv_c(key string, val string) { // Update the C environment if cgo is loaded. // Called from syscall.Unsetenv. +// //go:linkname syscall_unsetenv_c syscall.unsetenv_c func syscall_unsetenv_c(key string) { keydata := cstring(key) @@ -34,9 +36,11 @@ func cstring(s string) []byte { } // int setenv(const char *name, const char *val, int replace); +// //export setenv func libc_setenv(name *byte, val *byte, replace int32) int32 // int unsetenv(const char *name); +// //export unsetenv func libc_unsetenv(name *byte) int32 diff --git a/src/runtime/float.go b/src/runtime/float.go index 459e58dd7..c80c8b7ab 100644 --- a/src/runtime/float.go +++ b/src/runtime/float.go @@ -8,7 +8,7 @@ import "unsafe" var inf = float64frombits(0x7FF0000000000000) -// isNaN reports whether f is an IEEE 754 ``not-a-number'' value. +// isNaN reports whether f is an IEEE 754 “not-a-number” value. func isNaN(f float64) (is bool) { // IEEE 754 says that only NaNs satisfy f != f. return f != f @@ -27,6 +27,7 @@ func isInf(f float64) bool { // Abs returns the absolute value of x. // // Special cases are: +// // Abs(±Inf) = +Inf // Abs(NaN) = NaN func abs(x float64) float64 { diff --git a/src/runtime/gc_conservative.go b/src/runtime/gc_conservative.go index 00cadc30c..9d7a55846 100644 --- a/src/runtime/gc_conservative.go +++ b/src/runtime/gc_conservative.go @@ -259,6 +259,7 @@ func calculateHeapAddresses() { // alloc tries to find some free space on the heap, possibly doing a garbage // collection cycle if needed. If no space is free, it panics. +// //go:noinline func alloc(size uintptr, layout unsafe.Pointer) unsafe.Pointer { if size == 0 { diff --git a/src/runtime/gc_leaking.go b/src/runtime/gc_leaking.go index 7d5e2c316..536ce256b 100644 --- a/src/runtime/gc_leaking.go +++ b/src/runtime/gc_leaking.go @@ -18,6 +18,7 @@ var heapptr = heapStart // Inlining alloc() speeds things up slightly but bloats the executable by 50%, // see https://github.com/tinygo-org/tinygo/issues/2674. So don't. +// //go:noinline func alloc(size uintptr, layout unsafe.Pointer) unsafe.Pointer { // TODO: this can be optimized by not casting between pointers and ints so diff --git a/src/runtime/hashmap.go b/src/runtime/hashmap.go index 53542d549..965dab29c 100644 --- a/src/runtime/hashmap.go +++ b/src/runtime/hashmap.go @@ -133,6 +133,7 @@ func hashmapShouldGrow(m *hashmap) bool { // Return the number of entries in this hashmap, called from the len builtin. // A nil hashmap is defined as having length 0. +// //go:inline func hashmapLen(m *hashmap) int { if m == nil { @@ -148,6 +149,7 @@ func hashmapLenUnsafePointer(p unsafe.Pointer) int { } // Set a specified key to a given value. Grow the map if necessary. +// //go:nobounds func hashmapSet(m *hashmap, key unsafe.Pointer, value unsafe.Pointer, hash uint32) { if hashmapShouldGrow(m) { @@ -251,6 +253,7 @@ func hashmapGrow(m *hashmap) { } // Get the value of a specified key, or zero the value if not found. +// //go:nobounds func hashmapGet(m *hashmap, key, value unsafe.Pointer, valueSize uintptr, hash uint32) bool { if m == nil { @@ -298,6 +301,7 @@ func hashmapGet(m *hashmap, key, value unsafe.Pointer, valueSize uintptr, hash u // Delete a given key from the map. No-op when the key does not exist in the // map. +// //go:nobounds func hashmapDelete(m *hashmap, key unsafe.Pointer, hash uint32) { if m == nil { @@ -338,6 +342,7 @@ func hashmapDelete(m *hashmap, key unsafe.Pointer, hash uint32) { } // Iterate over a hashmap. +// //go:nobounds func hashmapNext(m *hashmap, it *hashmapIterator, key, value unsafe.Pointer) bool { if m == nil { @@ -477,6 +482,7 @@ func hashmapStringDelete(m *hashmap, key string) { // is identical to the Interface() method call, except it doesn't check whether // a field is exported and thus allows circumventing the type system. // The hash function needs it as it also needs to hash unexported struct fields. +// //go:linkname valueInterfaceUnsafe reflect.valueInterfaceUnsafe func valueInterfaceUnsafe(v reflect.Value) interface{} diff --git a/src/runtime/interrupt/interrupt_avr.go b/src/runtime/interrupt/interrupt_avr.go index 295757838..8fc4aabd5 100644 --- a/src/runtime/interrupt/interrupt_avr.go +++ b/src/runtime/interrupt/interrupt_avr.go @@ -11,9 +11,9 @@ type State uint8 // Disable disables all interrupts and returns the previous interrupt state. It // can be used in a critical section like this: // -// state := interrupt.Disable() -// // critical section -// interrupt.Restore(state) +// state := interrupt.Disable() +// // critical section +// interrupt.Restore(state) // // Critical sections can be nested. Make sure to call Restore in the same order // as you called Disable (this happens naturally with the pattern above). diff --git a/src/runtime/interrupt/interrupt_cortexm.go b/src/runtime/interrupt/interrupt_cortexm.go index 131e9ede1..e56a3bbe8 100644 --- a/src/runtime/interrupt/interrupt_cortexm.go +++ b/src/runtime/interrupt/interrupt_cortexm.go @@ -34,9 +34,9 @@ type State uintptr // Disable disables all interrupts and returns the previous interrupt state. It // can be used in a critical section like this: // -// state := interrupt.Disable() -// // critical section -// interrupt.Restore(state) +// state := interrupt.Disable() +// // critical section +// interrupt.Restore(state) // // Critical sections can be nested. Make sure to call Restore in the same order // as you called Disable (this happens naturally with the pattern above). diff --git a/src/runtime/interrupt/interrupt_esp32c3.go b/src/runtime/interrupt/interrupt_esp32c3.go index 068f95fd5..b32a9afe0 100644 --- a/src/runtime/interrupt/interrupt_esp32c3.go +++ b/src/runtime/interrupt/interrupt_esp32c3.go @@ -16,11 +16,11 @@ import ( // The Interrupt.New(x, f) (x = [1..31]) attaches CPU interrupt to function f. // Caller must map the selected interrupt using following sequence (for example using id 5): // -// // map interrupt 5 to my XXXX module -// esp.INTERRUPT_CORE0.XXXX_INTERRUPT_PRO_MAP.Set( 5 ) -// _ = Interrupt.New(5, func(interrupt.Interrupt) { -// ... -// }).Enable() +// // map interrupt 5 to my XXXX module +// esp.INTERRUPT_CORE0.XXXX_INTERRUPT_PRO_MAP.Set( 5 ) +// _ = Interrupt.New(5, func(interrupt.Interrupt) { +// ... +// }).Enable() func (i Interrupt) Enable() error { if i.num < 1 && i.num > 31 { return errors.New("interrupt for ESP32-C3 must be in range of 1 through 31") @@ -49,6 +49,7 @@ func (i Interrupt) Enable() error { // Adding pseudo function calls that is replaced by the compiler with the actual // functions registered through interrupt.New. +// //go:linkname callHandlers runtime/interrupt.callHandlers func callHandlers(num int) diff --git a/src/runtime/interrupt/interrupt_gameboyadvance.go b/src/runtime/interrupt/interrupt_gameboyadvance.go index 0437f9edb..f6dcc5e00 100644 --- a/src/runtime/interrupt/interrupt_gameboyadvance.go +++ b/src/runtime/interrupt/interrupt_gameboyadvance.go @@ -51,6 +51,7 @@ func handleInterrupt() { // Pseudo function call that is replaced by the compiler with the actual // functions registered through interrupt.New. If there are none, calls will be // replaced with 'unreachablecalls will be replaced with 'unreachable'. +// //go:linkname callHandlers runtime/interrupt.callHandlers func callHandlers(num int) @@ -93,9 +94,9 @@ type State uint8 // Disable disables all interrupts and returns the previous interrupt state. It // can be used in a critical section like this: // -// state := interrupt.Disable() -// // critical section -// interrupt.Restore(state) +// state := interrupt.Disable() +// // critical section +// interrupt.Restore(state) // // Critical sections can be nested. Make sure to call Restore in the same order // as you called Disable (this happens naturally with the pattern above). diff --git a/src/runtime/interrupt/interrupt_none.go b/src/runtime/interrupt/interrupt_none.go index 136d35709..1a1066524 100644 --- a/src/runtime/interrupt/interrupt_none.go +++ b/src/runtime/interrupt/interrupt_none.go @@ -9,9 +9,9 @@ type State uintptr // Disable disables all interrupts and returns the previous interrupt state. It // can be used in a critical section like this: // -// state := interrupt.Disable() -// // critical section -// interrupt.Restore(state) +// state := interrupt.Disable() +// // critical section +// interrupt.Restore(state) // // Critical sections can be nested. Make sure to call Restore in the same order // as you called Disable (this happens naturally with the pattern above). diff --git a/src/runtime/interrupt/interrupt_tinygoriscv.go b/src/runtime/interrupt/interrupt_tinygoriscv.go index da2964195..477227fe4 100644 --- a/src/runtime/interrupt/interrupt_tinygoriscv.go +++ b/src/runtime/interrupt/interrupt_tinygoriscv.go @@ -11,9 +11,9 @@ type State uintptr // Disable disables all interrupts and returns the previous interrupt state. It // can be used in a critical section like this: // -// state := interrupt.Disable() -// // critical section -// interrupt.Restore(state) +// state := interrupt.Disable() +// // critical section +// interrupt.Restore(state) // // Critical sections can be nested. Make sure to call Restore in the same order // as you called Disable (this happens naturally with the pattern above). diff --git a/src/runtime/interrupt/interrupt_xtensa.go b/src/runtime/interrupt/interrupt_xtensa.go index 67f4d812a..bbb9e84ea 100644 --- a/src/runtime/interrupt/interrupt_xtensa.go +++ b/src/runtime/interrupt/interrupt_xtensa.go @@ -11,9 +11,9 @@ type State uintptr // Disable disables all interrupts and returns the previous interrupt state. It // can be used in a critical section like this: // -// state := interrupt.Disable() -// // critical section -// interrupt.Restore(state) +// state := interrupt.Disable() +// // critical section +// interrupt.Restore(state) // // Critical sections can be nested. Make sure to call Restore in the same order // as you called Disable (this happens naturally with the pattern above). diff --git a/src/runtime/os_darwin.go b/src/runtime/os_darwin.go index 1d895722c..591c55823 100644 --- a/src/runtime/os_darwin.go +++ b/src/runtime/os_darwin.go @@ -49,6 +49,7 @@ type segmentLoadCommand struct { } // MachO header of the currently running process. +// //go:extern _mh_execute_header var libc_mh_execute_header machHeader diff --git a/src/runtime/panic.go b/src/runtime/panic.go index 622026ffd..d7ba9ded8 100644 --- a/src/runtime/panic.go +++ b/src/runtime/panic.go @@ -7,11 +7,13 @@ import ( // trap is a compiler hint that this function cannot be executed. It is // translated into either a trap instruction or a call to abort(). +// //export llvm.trap func trap() // Inline assembly stub. It is essentially C longjmp but modified a bit for the // purposes of TinyGo. It restores the stack pointer and jumps to the given pc. +// //export tinygo_longjmp func tinygo_longjmp(frame *deferFrame) @@ -61,6 +63,7 @@ func runtimePanic(msg string) { // It gets passed in the stack-allocated defer frame and configures it. // Note that the frame is not zeroed yet, so we need to initialize all values // that will be used. +// //go:inline //go:nobounds func setupDeferFrame(frame *deferFrame, jumpSP unsafe.Pointer) { @@ -74,6 +77,7 @@ func setupDeferFrame(frame *deferFrame, jumpSP unsafe.Pointer) { // Called right before the return instruction. It pops the defer frame from the // linked list of defer frames. It also re-raises a panic if the goroutine is // still panicking. +// //go:inline //go:nobounds func destroyDeferFrame(frame *deferFrame) { diff --git a/src/runtime/runtime.go b/src/runtime/runtime.go index d3db0e83d..cde8e2d9c 100644 --- a/src/runtime/runtime.go +++ b/src/runtime/runtime.go @@ -44,6 +44,7 @@ func memzero(ptr unsafe.Pointer, size uintptr) // This intrinsic returns the current stack pointer. // It is normally used together with llvm.stackrestore but also works to get the // current stack pointer in a platform-independent way. +// //export llvm.stacksave func stacksave() unsafe.Pointer @@ -70,6 +71,7 @@ func nanotime() int64 { } // Copied from the Go runtime source code. +// //go:linkname os_sigpipe os.sigpipe func os_sigpipe() { runtimePanic("too many writes on closed pipe") diff --git a/src/runtime/runtime_arm7tdmi.go b/src/runtime/runtime_arm7tdmi.go index 10baa6711..5c52e4a94 100644 --- a/src/runtime/runtime_arm7tdmi.go +++ b/src/runtime/runtime_arm7tdmi.go @@ -40,6 +40,7 @@ var _sidata [0]byte var _edata [0]byte // Entry point for Go. Initialize all packages and call main.main(). +// //export main func main() { // Initialize .data and .bss sections. diff --git a/src/runtime/runtime_cortexm_hardfault.go b/src/runtime/runtime_cortexm_hardfault.go index 8c56bbd9e..e7eb67a9b 100644 --- a/src/runtime/runtime_cortexm_hardfault.go +++ b/src/runtime/runtime_cortexm_hardfault.go @@ -17,6 +17,7 @@ import ( // For details, see: // https://community.arm.com/developer/ip-products/system/f/embedded-forum/3257/debugging-a-cortex-m0-hard-fault // https://blog.feabhas.com/2013/02/developing-a-generic-hard-fault-handler-for-arm-cortex-m3cortex-m4/ +// //export handleHardFault func handleHardFault(sp *interruptStack) { print("fatal error: ") diff --git a/src/runtime/runtime_cortexm_hardfault_debug.go b/src/runtime/runtime_cortexm_hardfault_debug.go index ee5e97eac..2ee7a4964 100644 --- a/src/runtime/runtime_cortexm_hardfault_debug.go +++ b/src/runtime/runtime_cortexm_hardfault_debug.go @@ -18,6 +18,7 @@ const ( ) // See runtime_cortexm_hardfault.go +// //go:export handleHardFault func handleHardFault(sp *interruptStack) { fault := GetFaultStatus() diff --git a/src/runtime/runtime_esp32.go b/src/runtime/runtime_esp32.go index 0543a4bd4..2b24d371b 100644 --- a/src/runtime/runtime_esp32.go +++ b/src/runtime/runtime_esp32.go @@ -11,6 +11,7 @@ import ( // This is the function called on startup right after the stack pointer has been // set. +// //export main func main() { // Disable the protection on the watchdog timer (needed when started from diff --git a/src/runtime/runtime_esp32c3.go b/src/runtime/runtime_esp32c3.go index fd0107c92..f5af66be3 100644 --- a/src/runtime/runtime_esp32c3.go +++ b/src/runtime/runtime_esp32c3.go @@ -12,6 +12,7 @@ import ( // This is the function called on startup after the flash (IROM/DROM) is // initialized and the stack pointer has been set. +// //export main func main() { // This initialization configures the following things: diff --git a/src/runtime/runtime_esp8266.go b/src/runtime/runtime_esp8266.go index cc047e062..d62b40fe0 100644 --- a/src/runtime/runtime_esp8266.go +++ b/src/runtime/runtime_esp8266.go @@ -33,6 +33,7 @@ func buffered() int { // Write to the internal control bus (using I2C?). // Signature found here: // https://github.com/espressif/ESP8266_RTOS_SDK/blob/14171de0/components/esp8266/include/esp8266/rom_functions.h#L54 +// //export rom_i2c_writeReg func rom_i2c_writeReg(block, host_id, reg_add, data uint8) diff --git a/src/runtime/runtime_nintendoswitch.go b/src/runtime/runtime_nintendoswitch.go index db4438cc1..c4116fce4 100644 --- a/src/runtime/runtime_nintendoswitch.go +++ b/src/runtime/runtime_nintendoswitch.go @@ -51,6 +51,7 @@ func preinit() { } // Entry point for Go. Initialize all packages and call main.main(). +// //export main func main() { preinit() @@ -274,31 +275,37 @@ func getMainThreadHandle() uintptr { func getArmSystemTick() int64 // nxExit exits the program to homebrew launcher +// //export __nx_exit func nxExit(code int, stackTop uintptr, exitFunction uintptr) // Horizon System Calls // svcSetHeapSize Set the process heap to a given size. It can both extend and shrink the heap. // svc 0x01 +// //export svcSetHeapSize func svcSetHeapSize(addr *uintptr, length uint64) uint64 // svcExitProcess Exits the current process. // svc 0x07 +// //export svcExitProcess func svcExitProcess(code int) // svcSleepThread Sleeps the current thread for the specified amount of time. // svc 0x0B +// //export svcSleepThread func svcSleepThread(nanos uint64) // svcOutputDebugString Outputs debug text, if used during debugging. // svc 0x27 +// //export svcOutputDebugString func svcOutputDebugString(str *uint8, size uint64) uint64 // svcGetInfo Retrieves information about the system, or a certain kernel object. // svc 0x29 +// //export svcGetInfo func svcGetInfo(output *uint64, id0 uint32, handle uint32, id1 uint64) uint64 diff --git a/src/runtime/runtime_stm32_timers.go b/src/runtime/runtime_stm32_timers.go index 81b728f77..ec2a2c563 100644 --- a/src/runtime/runtime_stm32_timers.go +++ b/src/runtime/runtime_stm32_timers.go @@ -62,6 +62,7 @@ func nanosecondsToTicks(ns int64) timeUnit { } // number of ticks since start. +// //go:linkname ticks runtime.ticks func ticks() timeUnit { // For some ways of capturing the time atomically, see this thread: diff --git a/src/runtime/runtime_stm32f407.go b/src/runtime/runtime_stm32f407.go index 643f67f82..0a269e273 100644 --- a/src/runtime/runtime_stm32f407.go +++ b/src/runtime/runtime_stm32f407.go @@ -6,14 +6,15 @@ package runtime import "device/stm32" /* - clock settings - +-------------+--------+ - | HSE | 8mhz | - | SYSCLK | 168mhz | - | HCLK | 168mhz | - | APB2(PCLK2) | 84mhz | - | APB1(PCLK1) | 42mhz | - +-------------+--------+ +clock settings + + +-------------+--------+ + | HSE | 8mhz | + | SYSCLK | 168mhz | + | HCLK | 168mhz | + | APB2(PCLK2) | 84mhz | + | APB1(PCLK1) | 42mhz | + +-------------+--------+ */ const ( HSE_STARTUP_TIMEOUT = 0x0500 diff --git a/src/runtime/runtime_stm32f469.go b/src/runtime/runtime_stm32f469.go index 56900e3b6..49e6657ac 100644 --- a/src/runtime/runtime_stm32f469.go +++ b/src/runtime/runtime_stm32f469.go @@ -6,14 +6,15 @@ package runtime import "device/stm32" /* - clock settings - +-------------+--------+ - | HSE | 8mhz | - | SYSCLK | 180mhz | - | HCLK | 180mhz | - | APB2(PCLK2) | 90mhz | - | APB1(PCLK1) | 45mhz | - +-------------+--------+ +clock settings + + +-------------+--------+ + | HSE | 8mhz | + | SYSCLK | 180mhz | + | HCLK | 180mhz | + | APB2(PCLK2) | 90mhz | + | APB1(PCLK1) | 45mhz | + +-------------+--------+ */ const ( HSE_STARTUP_TIMEOUT = 0x0500 diff --git a/src/runtime/runtime_stm32f7x2.go b/src/runtime/runtime_stm32f7x2.go index 5eddd1c79..1c7168d8e 100644 --- a/src/runtime/runtime_stm32f7x2.go +++ b/src/runtime/runtime_stm32f7x2.go @@ -9,14 +9,15 @@ import ( ) /* - clock settings - +-------------+--------+ - | HSE | 8mhz | - | SYSCLK | 216mhz | - | HCLK | 216mhz | - | APB1(PCLK1) | 27mhz | - | APB2(PCLK2) | 108mhz | - +-------------+--------+ +clock settings + + +-------------+--------+ + | HSE | 8mhz | + | SYSCLK | 216mhz | + | HCLK | 216mhz | + | APB1(PCLK1) | 27mhz | + | APB2(PCLK2) | 108mhz | + +-------------+--------+ */ const ( HSE_STARTUP_TIMEOUT = 0x0500 diff --git a/src/runtime/runtime_stm32l4x2.go b/src/runtime/runtime_stm32l4x2.go index 2e3cbbd07..2e571eaa3 100644 --- a/src/runtime/runtime_stm32l4x2.go +++ b/src/runtime/runtime_stm32l4x2.go @@ -8,14 +8,15 @@ import ( ) /* - clock settings - +-------------+-----------+ - | LSE | 32.768khz | - | SYSCLK | 80mhz | - | HCLK | 80mhz | - | APB1(PCLK1) | 80mhz | - | APB2(PCLK2) | 80mhz | - +-------------+-----------+ +clock settings + + +-------------+-----------+ + | LSE | 32.768khz | + | SYSCLK | 80mhz | + | HCLK | 80mhz | + | APB1(PCLK1) | 80mhz | + | APB2(PCLK2) | 80mhz | + +-------------+-----------+ */ const ( HSE_STARTUP_TIMEOUT = 0x0500 diff --git a/src/runtime/runtime_stm32l4x5.go b/src/runtime/runtime_stm32l4x5.go index 87837b97f..8a3439d1a 100644 --- a/src/runtime/runtime_stm32l4x5.go +++ b/src/runtime/runtime_stm32l4x5.go @@ -8,14 +8,15 @@ import ( ) /* - clock settings - +-------------+-----------+ - | LSE | 32.768khz | - | SYSCLK | 120mhz | - | HCLK | 120mhz | - | APB1(PCLK1) | 120mhz | - | APB2(PCLK2) | 120mhz | - +-------------+-----------+ +clock settings + + +-------------+-----------+ + | LSE | 32.768khz | + | SYSCLK | 120mhz | + | HCLK | 120mhz | + | APB1(PCLK1) | 120mhz | + | APB2(PCLK2) | 120mhz | + +-------------+-----------+ */ const ( HSE_STARTUP_TIMEOUT = 0x0500 diff --git a/src/runtime/runtime_stm32l5x2.go b/src/runtime/runtime_stm32l5x2.go index 89fba6c8e..b55bc1a97 100644 --- a/src/runtime/runtime_stm32l5x2.go +++ b/src/runtime/runtime_stm32l5x2.go @@ -9,14 +9,15 @@ import ( ) /* - clock settings - +-------------+-----------+ - | LSE | 32.768khz | - | SYSCLK | 110mhz | - | HCLK | 110mhz | - | APB1(PCLK1) | 110mhz | - | APB2(PCLK2) | 110mhz | - +-------------+-----------+ +clock settings + + +-------------+-----------+ + | LSE | 32.768khz | + | SYSCLK | 110mhz | + | HCLK | 110mhz | + | APB1(PCLK1) | 110mhz | + | APB2(PCLK2) | 110mhz | + +-------------+-----------+ */ const ( HSE_STARTUP_TIMEOUT = 0x0500 diff --git a/src/runtime/runtime_tinygowasm.go b/src/runtime/runtime_tinygowasm.go index 12b048100..73a9eddf9 100644 --- a/src/runtime/runtime_tinygowasm.go +++ b/src/runtime/runtime_tinygowasm.go @@ -19,6 +19,7 @@ func fd_write(id uint32, iovs *__wasi_iovec_t, iovs_len uint, nwritten *uint) (e // See: // https://github.com/WebAssembly/WASI/blob/main/phases/snapshot/docs.md#-proc_exitrval-exitcode +// //go:wasm-module wasi_snapshot_preview1 //export proc_exit func proc_exit(exitcode uint32) diff --git a/src/runtime/runtime_unix.go b/src/runtime/runtime_unix.go index fe8c0cac2..604f21c6d 100644 --- a/src/runtime/runtime_unix.go +++ b/src/runtime/runtime_unix.go @@ -18,6 +18,7 @@ func usleep(usec uint) int // Note: off_t is defined as int64 because: // - musl (used on Linux) always defines it as int64 // - darwin is practically always 64-bit anyway +// //export mmap func mmap(addr unsafe.Pointer, length uintptr, prot, flags, fd int, offset int64) unsafe.Pointer @@ -66,6 +67,7 @@ type timespec struct { var stackTop uintptr // Entry point for Go. Initialize all packages and call main.main(). +// //export main func main(argc int32, argv *unsafe.Pointer) int { preinit() @@ -113,6 +115,7 @@ func os_runtime_args() []string { } // Must be a separate function to get the correct stack pointer. +// //go:noinline func runMain() { run() diff --git a/src/runtime/runtime_wasm_js.go b/src/runtime/runtime_wasm_js.go index 60d8760d6..ecc9d73d3 100644 --- a/src/runtime/runtime_wasm_js.go +++ b/src/runtime/runtime_wasm_js.go @@ -44,6 +44,7 @@ func nanosecondsToTicks(ns int64) timeUnit { // This function is called by the scheduler. // Schedule a call to runtime.scheduler, do not actually sleep. +// //export runtime.sleepTicks func sleepTicks(d timeUnit) diff --git a/src/runtime/runtime_wasm_wasi.go b/src/runtime/runtime_wasm_wasi.go index 658278626..52fd79d61 100644 --- a/src/runtime/runtime_wasm_wasi.go +++ b/src/runtime/runtime_wasm_wasi.go @@ -10,6 +10,7 @@ import ( type timeUnit int64 // libc constructors +// //export __wasm_call_ctors func __wasm_call_ctors() @@ -24,7 +25,7 @@ func _start() { // Read the command line arguments from WASI. // For example, they can be passed to a program with wasmtime like this: // -// wasmtime ./program.wasm arg1 arg2 +// wasmtime ./program.wasm arg1 arg2 func init() { __wasm_call_ctors() } diff --git a/src/runtime/runtime_windows.go b/src/runtime/runtime_windows.go index 851f40f7a..6be6c32b5 100644 --- a/src/runtime/runtime_windows.go +++ b/src/runtime/runtime_windows.go @@ -18,6 +18,7 @@ func _VirtualAlloc(lpAddress unsafe.Pointer, dwSize uintptr, flAllocationType, f func _QueryUnbiasedInterruptTime(UnbiasedTime *uint64) bool // The parameter is really a LPFILETIME, but *uint64 should be compatible. +// //export GetSystemTimeAsFileTime func _GetSystemTimeAsFileTime(lpSystemTimeAsFileTime *uint64) @@ -56,6 +57,7 @@ func mainCRTStartup() int { } // Must be a separate function to get the correct stack pointer. +// //go:noinline func runMain() { run() diff --git a/src/runtime/scheduler.go b/src/runtime/scheduler.go index 196f6e3a7..383051aeb 100644 --- a/src/runtime/scheduler.go +++ b/src/runtime/scheduler.go @@ -54,7 +54,8 @@ func scheduleLogChan(msg string, ch *channel, t *task.Task) { // not exited (so deferred calls won't run). This can happen for example in code // like this, that blocks forever: // -// select{} +// select{} +// //go:noinline func deadlock() { // call yield without requesting a wakeup @@ -65,6 +66,7 @@ func deadlock() { // Goexit terminates the currently running goroutine. No other goroutines are affected. // // Unlike the main Go implementation, no deffered calls will be run. +// //go:inline func Goexit() { // its really just a deadlock diff --git a/src/runtime/scheduler_any.go b/src/runtime/scheduler_any.go index d80979151..39bbeb1e4 100644 --- a/src/runtime/scheduler_any.go +++ b/src/runtime/scheduler_any.go @@ -6,6 +6,7 @@ package runtime import "internal/task" // Pause the current task for a given time. +// //go:linkname sleep time.Sleep func sleep(duration int64) { if duration <= 0 { diff --git a/src/runtime/string.go b/src/runtime/string.go index a2b57fe16..206462918 100644 --- a/src/runtime/string.go +++ b/src/runtime/string.go @@ -18,6 +18,7 @@ type stringIterator struct { } // Return true iff the strings match. +// //go:nobounds func stringEqual(x, y string) bool { if len(x) != len(y) { @@ -32,6 +33,7 @@ func stringEqual(x, y string) bool { } // Return true iff x < y. +// //go:nobounds func stringLess(x, y string) bool { l := len(x) @@ -181,6 +183,7 @@ func encodeUTF8(x rune) ([4]byte, uintptr) { } // Decode a single UTF-8 character from a string. +// //go:nobounds func decodeUTF8(s string, index uintptr) (rune, uintptr) { remaining := uintptr(len(s)) - index // must be >= 1 before calling this function diff --git a/src/runtime/time_nxpmk66f18.go b/src/runtime/time_nxpmk66f18.go index c0b876ed1..fd6078dc5 100644 --- a/src/runtime/time_nxpmk66f18.go +++ b/src/runtime/time_nxpmk66f18.go @@ -50,10 +50,10 @@ func nanosecondsToTicks(ns int64) timeUnit { return timeUnit(ns / 1000) } -// cyclesPerMilli-1 is used for the systick reset value -// the systick current value will be decremented on every clock cycle -// an interrupt is generated when the current value reaches 0 -// a value of freq/1000 generates a tick (irq) every millisecond (1/1000 s) +// cyclesPerMilli-1 is used for the systick reset value. +// The systick current value will be decremented on every clock cycle. +// An interrupt is generated when the current value reaches 0. +// A value of freq/1000 generates a tick (irq) every millisecond (1/1000 s). var cyclesPerMilli = machine.CPUFrequency() / 1000 // number of systick irqs (milliseconds) since boot diff --git a/src/runtime/volatile/bitband_nxpmk66f18.go b/src/runtime/volatile/bitband_nxpmk66f18.go index b85a9495c..a6da2ec93 100644 --- a/src/runtime/volatile/bitband_nxpmk66f18.go +++ b/src/runtime/volatile/bitband_nxpmk66f18.go @@ -28,7 +28,7 @@ type BitRegister struct { // Get returns the of the mapped register bit. It is the volatile equivalent of: // -// *r.Reg +// *r.Reg // //go:inline func (r *BitRegister) Get() bool { @@ -37,7 +37,7 @@ func (r *BitRegister) Get() bool { // Set sets the mapped register bit. It is the volatile equivalent of: // -// *r.Reg = 1 +// *r.Reg = 1 // //go:inline func (r *BitRegister) Set(v bool) { diff --git a/src/runtime/volatile/register.go b/src/runtime/volatile/register.go index adfe372ee..62c5e63f9 100644 --- a/src/runtime/volatile/register.go +++ b/src/runtime/volatile/register.go @@ -11,7 +11,7 @@ type Register8 struct { // Get returns the value in the register. It is the volatile equivalent of: // -// *r.Reg +// *r.Reg // //go:inline func (r *Register8) Get() uint8 { @@ -20,7 +20,7 @@ func (r *Register8) Get() uint8 { // Set updates the register value. It is the volatile equivalent of: // -// *r.Reg = value +// *r.Reg = value // //go:inline func (r *Register8) Set(value uint8) { @@ -30,7 +30,7 @@ func (r *Register8) Set(value uint8) { // SetBits reads the register, sets the given bits, and writes it back. It is // the volatile equivalent of: // -// r.Reg |= value +// r.Reg |= value // //go:inline func (r *Register8) SetBits(value uint8) { @@ -40,7 +40,7 @@ func (r *Register8) SetBits(value uint8) { // ClearBits reads the register, clears the given bits, and writes it back. It // is the volatile equivalent of: // -// r.Reg &^= value +// r.Reg &^= value // //go:inline func (r *Register8) ClearBits(value uint8) { @@ -50,7 +50,7 @@ func (r *Register8) ClearBits(value uint8) { // HasBits reads the register and then checks to see if the passed bits are set. It // is the volatile equivalent of: // -// (*r.Reg & value) > 0 +// (*r.Reg & value) > 0 // //go:inline func (r *Register8) HasBits(value uint8) bool { @@ -60,7 +60,7 @@ func (r *Register8) HasBits(value uint8) bool { // ReplaceBits is a helper to simplify setting multiple bits high and/or low at // once. It is the volatile equivalent of: // -// r.Reg = (r.Reg & ^(mask << pos)) | value << pos +// r.Reg = (r.Reg & ^(mask << pos)) | value << pos // // go:inline func (r *Register8) ReplaceBits(value uint8, mask uint8, pos uint8) { @@ -73,7 +73,7 @@ type Register16 struct { // Get returns the value in the register. It is the volatile equivalent of: // -// *r.Reg +// *r.Reg // //go:inline func (r *Register16) Get() uint16 { @@ -82,7 +82,7 @@ func (r *Register16) Get() uint16 { // Set updates the register value. It is the volatile equivalent of: // -// *r.Reg = value +// *r.Reg = value // //go:inline func (r *Register16) Set(value uint16) { @@ -92,7 +92,7 @@ func (r *Register16) Set(value uint16) { // SetBits reads the register, sets the given bits, and writes it back. It is // the volatile equivalent of: // -// r.Reg |= value +// r.Reg |= value // //go:inline func (r *Register16) SetBits(value uint16) { @@ -102,7 +102,7 @@ func (r *Register16) SetBits(value uint16) { // ClearBits reads the register, clears the given bits, and writes it back. It // is the volatile equivalent of: // -// r.Reg &^= value +// r.Reg &^= value // //go:inline func (r *Register16) ClearBits(value uint16) { @@ -112,7 +112,7 @@ func (r *Register16) ClearBits(value uint16) { // HasBits reads the register and then checks to see if the passed bits are set. It // is the volatile equivalent of: // -// (*r.Reg & value) > 0 +// (*r.Reg & value) > 0 // //go:inline func (r *Register16) HasBits(value uint16) bool { @@ -122,7 +122,7 @@ func (r *Register16) HasBits(value uint16) bool { // ReplaceBits is a helper to simplify setting multiple bits high and/or low at // once. It is the volatile equivalent of: // -// r.Reg = (r.Reg & ^(mask << pos)) | value << pos +// r.Reg = (r.Reg & ^(mask << pos)) | value << pos // // go:inline func (r *Register16) ReplaceBits(value uint16, mask uint16, pos uint8) { @@ -135,7 +135,7 @@ type Register32 struct { // Get returns the value in the register. It is the volatile equivalent of: // -// *r.Reg +// *r.Reg // //go:inline func (r *Register32) Get() uint32 { @@ -144,7 +144,7 @@ func (r *Register32) Get() uint32 { // Set updates the register value. It is the volatile equivalent of: // -// *r.Reg = value +// *r.Reg = value // //go:inline func (r *Register32) Set(value uint32) { @@ -154,7 +154,7 @@ func (r *Register32) Set(value uint32) { // SetBits reads the register, sets the given bits, and writes it back. It is // the volatile equivalent of: // -// r.Reg |= value +// r.Reg |= value // //go:inline func (r *Register32) SetBits(value uint32) { @@ -164,7 +164,7 @@ func (r *Register32) SetBits(value uint32) { // ClearBits reads the register, clears the given bits, and writes it back. It // is the volatile equivalent of: // -// r.Reg &^= value +// r.Reg &^= value // //go:inline func (r *Register32) ClearBits(value uint32) { @@ -174,7 +174,7 @@ func (r *Register32) ClearBits(value uint32) { // HasBits reads the register and then checks to see if the passed bits are set. It // is the volatile equivalent of: // -// (*r.Reg & value) > 0 +// (*r.Reg & value) > 0 // //go:inline func (r *Register32) HasBits(value uint32) bool { @@ -184,7 +184,7 @@ func (r *Register32) HasBits(value uint32) bool { // ReplaceBits is a helper to simplify setting multiple bits high and/or low at // once. It is the volatile equivalent of: // -// r.Reg = (r.Reg & ^(mask << pos)) | value << pos +// r.Reg = (r.Reg & ^(mask << pos)) | value << pos // // go:inline func (r *Register32) ReplaceBits(value uint32, mask uint32, pos uint8) { @@ -197,7 +197,7 @@ type Register64 struct { // Get returns the value in the register. It is the volatile equivalent of: // -// *r.Reg +// *r.Reg // //go:inline func (r *Register64) Get() uint64 { @@ -206,7 +206,7 @@ func (r *Register64) Get() uint64 { // Set updates the register value. It is the volatile equivalent of: // -// *r.Reg = value +// *r.Reg = value // //go:inline func (r *Register64) Set(value uint64) { @@ -216,7 +216,7 @@ func (r *Register64) Set(value uint64) { // SetBits reads the register, sets the given bits, and writes it back. It is // the volatile equivalent of: // -// r.Reg |= value +// r.Reg |= value // //go:inline func (r *Register64) SetBits(value uint64) { @@ -226,7 +226,7 @@ func (r *Register64) SetBits(value uint64) { // ClearBits reads the register, clears the given bits, and writes it back. It // is the volatile equivalent of: // -// r.Reg &^= value +// r.Reg &^= value // //go:inline func (r *Register64) ClearBits(value uint64) { @@ -236,7 +236,7 @@ func (r *Register64) ClearBits(value uint64) { // HasBits reads the register and then checks to see if the passed bits are set. It // is the volatile equivalent of: // -// (*r.Reg & value) > 0 +// (*r.Reg & value) > 0 // //go:inline func (r *Register64) HasBits(value uint64) bool { @@ -246,7 +246,7 @@ func (r *Register64) HasBits(value uint64) bool { // ReplaceBits is a helper to simplify setting multiple bits high and/or low at // once. It is the volatile equivalent of: // -// r.Reg = (r.Reg & ^(mask << pos)) | value << pos +// r.Reg = (r.Reg & ^(mask << pos)) | value << pos // // go:inline func (r *Register64) ReplaceBits(value uint64, mask uint64, pos uint8) { diff --git a/src/syscall/errno.go b/src/syscall/errno.go index ec6cc1fb8..3670a2dc9 100644 --- a/src/syscall/errno.go +++ b/src/syscall/errno.go @@ -13,10 +13,11 @@ import "internal/itoa" // An Errno is an unsigned number describing an error condition. // It implements the error interface. The zero Errno is by convention // a non-error, so code to convert from Errno to error should use: -// err = nil -// if errno != 0 { -// err = errno -// } +// +// err = nil +// if errno != 0 { +// err = errno +// } type Errno uintptr func (e Errno) Error() string { diff --git a/src/syscall/file_hosted.go b/src/syscall/file_hosted.go index f11081c31..86fc62c40 100644 --- a/src/syscall/file_hosted.go +++ b/src/syscall/file_hosted.go @@ -22,5 +22,6 @@ func Getwd() (string, error) { } // char *getcwd(char *buf, size_t size) +// //export getcwd func libc_getcwd(buf *byte, size uint) *byte diff --git a/src/syscall/proc_hosted.go b/src/syscall/proc_hosted.go index 2ec99ac54..dd7c289ca 100644 --- a/src/syscall/proc_hosted.go +++ b/src/syscall/proc_hosted.go @@ -14,25 +14,31 @@ func Getpid() int { return int(libc_getpid()) } func Getppid() int { return int(libc_getppid()) } // uid_t getuid(void) +// //export getuid func libc_getuid() int32 // gid_t getgid(void) +// //export getgid func libc_getgid() int32 // uid_t geteuid(void) +// //export geteuid func libc_geteuid() int32 // gid_t getegid(void) +// //export getegid func libc_getegid() int32 // gid_t getpid(void) +// //export getpid func libc_getpid() int32 // gid_t getppid(void) +// //export getppid func libc_getppid() int32 diff --git a/src/syscall/syscall_libc.go b/src/syscall/syscall_libc.go index a02187b5f..0f10b7fbb 100644 --- a/src/syscall/syscall_libc.go +++ b/src/syscall/syscall_libc.go @@ -317,86 +317,107 @@ func splitSlice(p []byte) (buf *byte, len uintptr) { func libc_strlen(ptr unsafe.Pointer) uintptr // ssize_t write(int fd, const void *buf, size_t count) +// //export write func libc_write(fd int32, buf *byte, count uint) int // char *getenv(const char *name); +// //export getenv func libc_getenv(name *byte) *byte // int setenv(const char *name, const char *val, int replace); +// //export setenv func libc_setenv(name *byte, val *byte, replace int32) int32 // int unsetenv(const char *name); +// //export unsetenv func libc_unsetenv(name *byte) int32 // ssize_t read(int fd, void *buf, size_t count); +// //export read func libc_read(fd int32, buf *byte, count uint) int // ssize_t pread(int fd, void *buf, size_t count, off_t offset); +// //export pread func libc_pread(fd int32, buf *byte, count uint, offset int64) int // ssize_t lseek(int fd, off_t offset, int whence); +// //export lseek func libc_lseek(fd int32, offset int64, whence int) int64 // int open(const char *pathname, int flags, mode_t mode); +// //export open func libc_open(pathname *byte, flags int32, mode uint32) int32 // int close(int fd) +// //export close func libc_close(fd int32) int32 // int dup(int fd) +// //export dup func libc_dup(fd int32) int32 // void *mmap(void *addr, size_t length, int prot, int flags, int fd, off_t offset); +// //export mmap func libc_mmap(addr unsafe.Pointer, length uintptr, prot, flags, fd int32, offset uintptr) unsafe.Pointer // int munmap(void *addr, size_t length); +// //export munmap func libc_munmap(addr unsafe.Pointer, length uintptr) int32 // int mprotect(void *addr, size_t len, int prot); +// //export mprotect func libc_mprotect(addr unsafe.Pointer, len uintptr, prot int32) int32 // int chdir(const char *pathname, mode_t mode); +// //export chdir func libc_chdir(pathname *byte) int32 // int chmod(const char *pathname, mode_t mode); +// //export chmod func libc_chmod(pathname *byte, mode uint32) int32 // int mkdir(const char *pathname, mode_t mode); +// //export mkdir func libc_mkdir(pathname *byte, mode uint32) int32 // int rmdir(const char *pathname); +// //export rmdir func libc_rmdir(pathname *byte) int32 // int rename(const char *from, *to); +// //export rename func libc_rename(from, to *byte) int32 // int symlink(const char *from, *to); +// //export symlink func libc_symlink(from, to *byte) int32 // ssize_t readlink(const char *path, void *buf, size_t count); +// //export readlink func libc_readlink(path *byte, buf *byte, count uint) int // int unlink(const char *pathname); +// //export unlink func libc_unlink(pathname *byte) int32 diff --git a/src/syscall/syscall_libc_darwin.go b/src/syscall/syscall_libc_darwin.go index 4b1f1716d..0e1ea087e 100644 --- a/src/syscall/syscall_libc_darwin.go +++ b/src/syscall/syscall_libc_darwin.go @@ -14,10 +14,10 @@ import ( // This function returns the error location in the darwin ABI. // Discovered by compiling the following code using Clang: // -// #include <errno.h> -// int getErrno() { -// return errno; -// } +// #include <errno.h> +// int getErrno() { +// return errno; +// } // //export __error func libc___error() *int32 @@ -272,9 +272,11 @@ func Getpagesize() int { } // int pipe(int32 *fds); +// //export pipe func libc_pipe(fds *int32) int32 // int getpagesize(); +// //export getpagesize func libc_getpagesize() int32 diff --git a/src/syscall/syscall_libc_darwin_amd64.go b/src/syscall/syscall_libc_darwin_amd64.go index 81e06efdd..242aca3f2 100644 --- a/src/syscall/syscall_libc_darwin_amd64.go +++ b/src/syscall/syscall_libc_darwin_amd64.go @@ -14,21 +14,26 @@ import ( // It not needed on arm64. // struct DIR * buf fdopendir(int fd); +// //export fdopendir$INODE64 func libc_fdopendir(fd int32) unsafe.Pointer // int readdir_r(struct DIR * buf, struct dirent *entry, struct dirent **result); +// //export readdir_r$INODE64 func libc_readdir_r(unsafe.Pointer, unsafe.Pointer, unsafe.Pointer) int32 // int stat(const char *path, struct stat * buf); +// //export stat$INODE64 func libc_stat(pathname *byte, ptr unsafe.Pointer) int32 // int fstat(int fd, struct stat * buf); +// //export fstat$INODE64 func libc_fstat(fd int32, ptr unsafe.Pointer) int32 // int lstat(const char *path, struct stat * buf); +// //export lstat$INODE64 func libc_lstat(pathname *byte, ptr unsafe.Pointer) int32 diff --git a/src/syscall/syscall_libc_darwin_arm64.go b/src/syscall/syscall_libc_darwin_arm64.go index 74075000b..815d84f92 100644 --- a/src/syscall/syscall_libc_darwin_arm64.go +++ b/src/syscall/syscall_libc_darwin_arm64.go @@ -8,21 +8,26 @@ import ( ) // struct DIR * buf fdopendir(int fd); +// //export fdopendir func libc_fdopendir(fd int32) unsafe.Pointer // int readdir_r(struct DIR * buf, struct dirent *entry, struct dirent **result); +// //export readdir_r func libc_readdir_r(unsafe.Pointer, unsafe.Pointer, unsafe.Pointer) int32 // int stat(const char *path, struct stat * buf); +// //export stat func libc_stat(pathname *byte, ptr unsafe.Pointer) int32 // int fstat(int fd, struct stat * buf); +// //export fstat func libc_fstat(fd int32, ptr unsafe.Pointer) int32 // int lstat(const char *path, struct stat * buf); +// //export lstat func libc_lstat(pathname *byte, ptr unsafe.Pointer) int32 diff --git a/src/syscall/syscall_libc_wasi.go b/src/syscall/syscall_libc_wasi.go index ec9d2304e..65f11b709 100644 --- a/src/syscall/syscall_libc_wasi.go +++ b/src/syscall/syscall_libc_wasi.go @@ -302,13 +302,16 @@ func Getpagesize() int { } // int stat(const char *path, struct stat * buf); +// //export stat func libc_stat(pathname *byte, ptr unsafe.Pointer) int32 // int fstat(fd int, struct stat * buf); +// //export fstat func libc_fstat(fd int32, ptr unsafe.Pointer) int32 // int lstat(const char *path, struct stat * buf); +// //export lstat func libc_lstat(pathname *byte, ptr unsafe.Pointer) int32 diff --git a/src/testing/fuzz.go b/src/testing/fuzz.go index 76ad6d945..b6eaad409 100644 --- a/src/testing/fuzz.go +++ b/src/testing/fuzz.go @@ -100,7 +100,7 @@ var supportedTypes = map[reflect.Type]bool{ // whose remaining arguments are the types to be fuzzed. // For example: // -// f.Fuzz(func(t *testing.T, b []byte, i int) { ... }) +// f.Fuzz(func(t *testing.T, b []byte, i int) { ... }) // // The following types are allowed: []byte, string, bool, byte, rune, float32, // float64, int, int8, int16, int32, int64, uint, uint8, uint16, uint32, uint64. diff --git a/src/testing/testing.go b/src/testing/testing.go index 045ee5beb..018ededa0 100644 --- a/src/testing/testing.go +++ b/src/testing/testing.go @@ -127,7 +127,6 @@ var _ TB = (*B)(nil) // T is a type passed to Test functions to manage test state and support formatted test logs. // Logs are accumulated during execution and dumped to standard output when done. -// type T struct { common context *testContext // For running tests and subtests. diff --git a/transform/interrupt.go b/transform/interrupt.go index 49ee6ee6d..3ffe7048c 100644 --- a/transform/interrupt.go +++ b/transform/interrupt.go @@ -12,9 +12,9 @@ import ( // // The operation is as follows. The compiler creates the following during IR // generation: -// * calls to runtime/interrupt.callHandlers with an interrupt number. -// * runtime/interrupt.handle objects that store the (constant) interrupt ID and -// interrupt handler func value. +// - calls to runtime/interrupt.callHandlers with an interrupt number. +// - runtime/interrupt.handle objects that store the (constant) interrupt ID and +// interrupt handler func value. // // This pass then replaces those callHandlers calls with calls to the actual // interrupt handlers. If there are no interrupt handlers for the given call, diff --git a/transform/reflect.go b/transform/reflect.go index 49bd449ac..fd70ccb7d 100644 --- a/transform/reflect.go +++ b/transform/reflect.go @@ -366,10 +366,13 @@ func (state *typeCodeAssignmentState) getNonBasicTypeCode(class string, typecode // getClassAndValueFromTypeCode takes a typecode (a llvm.Value of type // runtime.typecodeID), looks at the name, and extracts the typecode class and // value from it. For example, for a typecode with the following name: -// reflect/types.type:pointer:named:reflect.ValueError +// +// reflect/types.type:pointer:named:reflect.ValueError +// // It extracts: -// class = "pointer" -// value = "named:reflect.ValueError" +// +// class = "pointer" +// value = "named:reflect.ValueError" func getClassAndValueFromTypeCode(typecode llvm.Value) (class, value string) { typecodeName := typecode.Name() const prefix = "reflect/types.type:" diff --git a/transform/reflect_test.go b/transform/reflect_test.go index 06c304067..242337024 100644 --- a/transform/reflect_test.go +++ b/transform/reflect_test.go @@ -15,13 +15,13 @@ type reflectAssert struct { // Test reflect lowering. This code looks at IR like this: // -// call void @main.assertType(i32 ptrtoint (%runtime.typecodeID* @"reflect/types.type:basic:int" to i32), i8* inttoptr (i32 3 to i8*), i32 4, i8* undef, i8* undef) +// call void @main.assertType(i32 ptrtoint (%runtime.typecodeID* @"reflect/types.type:basic:int" to i32), i8* inttoptr (i32 3 to i8*), i32 4, i8* undef, i8* undef) // // and verifies that the ptrtoint constant (the first parameter of // @main.assertType) is replaced with the correct type code. The expected // output is this: // -// call void @main.assertType(i32 4, i8* inttoptr (i32 3 to i8*), i32 4, i8* undef, i8* undef) +// call void @main.assertType(i32 4, i8* inttoptr (i32 3 to i8*), i32 4, i8* undef, i8* undef) // // The first and third parameter are compared and must match, the second // parameter is ignored. diff --git a/transform/rtcalls.go b/transform/rtcalls.go index 6cd5cc4c9..2edfd6554 100644 --- a/transform/rtcalls.go +++ b/transform/rtcalls.go @@ -12,7 +12,7 @@ import ( // OptimizeStringToBytes transforms runtime.stringToBytes(...) calls into const // []byte slices whenever possible. This optimizes the following pattern: // -// w.Write([]byte("foo")) +// w.Write([]byte("foo")) // // where Write does not store to the slice. func OptimizeStringToBytes(mod llvm.Module) { @@ -91,12 +91,12 @@ func OptimizeStringEqual(mod llvm.Module) { // OptimizeReflectImplements optimizes the following code: // -// implements := someType.Implements(someInterfaceType) +// implements := someType.Implements(someInterfaceType) // // where someType is an arbitrary reflect.Type and someInterfaceType is a // reflect.Type of interface kind, to the following code: // -// _, implements := someType.(interfaceType) +// _, implements := someType.(interfaceType) // // if the interface type is known at compile time (that is, someInterfaceType is // a LLVM constant aggregate). This optimization is especially important for the |