diff options
| author | Damian Gryski <[email protected]> | 2023-03-22 09:33:57 -0700 |
|---|---|---|
| committer | Ayke <[email protected]> | 2023-03-27 18:53:37 +0200 |
| commit | 6b73b5e4860a060e5196080c6485fa6b6c2b8fe5 (patch) | |
| tree | 9a84c4bf806d339bb64ae1b783a76a573f1d652e | |
| parent | 855e12df51906acefd49ebc44587926e4cae25ec (diff) | |
| download | tinygo-6b73b5e4860a060e5196080c6485fa6b6c2b8fe5.tar.gz tinygo-6b73b5e4860a060e5196080c6485fa6b6c2b8fe5.zip | |
reflect: document which Convert() cases are still unimplemented
| -rw-r--r-- | src/reflect/value.go | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/reflect/value.go b/src/reflect/value.go index 2c238efd5..2cbd4a7cf 100644 --- a/src/reflect/value.go +++ b/src/reflect/value.go @@ -1154,8 +1154,6 @@ func convertOp(src Value, typ Type) (Value, bool) { } } - // TODO(dgryski): Implement other cases - case String: rtype := typ.(*rawType) if typ.Kind() == Slice && !rtype.elem().isNamed() { @@ -1166,9 +1164,14 @@ func convertOp(src Value, typ Type) (Value, bool) { return cvtStringRunes(src, rtype), true } } - } + // TODO(dgryski): Unimplemented: + // Chan + // Identical underlying types + // Non-defined pointers types with same underlying base type + // Interface <-> Type conversions + return Value{}, false } |