summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorYen Chi Hsuan <[email protected]>2016-05-03 15:37:30 +0800
committerYen Chi Hsuan <[email protected]>2016-05-10 14:51:38 +0800
commitd5ae6bb50124f8320f2b492380480038c487a6d2 (patch)
tree16eed011590d513033b0033e39b689f89cd1ea06
parent51fb4995a5242c0edca09167cf8c4b050cf5a186 (diff)
downloadyoutube-dl-d5ae6bb50124f8320f2b492380480038c487a6d2.tar.gz
youtube-dl-d5ae6bb50124f8320f2b492380480038c487a6d2.zip
[utils] Add rationale for register_socks_protocols
-rw-r--r--youtube_dl/utils.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py
index c9702fd93..dc73f3407 100644
--- a/youtube_dl/utils.py
+++ b/youtube_dl/utils.py
@@ -63,6 +63,8 @@ from .socks import (
def register_socks_protocols():
# "Register" SOCKS protocols
+ # In Python < 2.6.5, urlsplit() suffers from bug https://bugs.python.org/issue7904
+ # URLs with protocols not in urlparse.uses_netloc are not handled correctly
for scheme in ('socks', 'socks4', 'socks4a', 'socks5'):
if scheme not in compat_urlparse.uses_netloc:
compat_urlparse.uses_netloc.append(scheme)