diff options
| author | WeidiDeng <[email protected]> | 2023-10-16 23:28:15 +0800 |
|---|---|---|
| committer | GitHub <[email protected]> | 2023-10-16 09:28:15 -0600 |
| commit | 7c82e265da8f90c1a1fee52c57af94587276ac56 (patch) | |
| tree | 948b6067d7b909367048629f7a8bfa2ba9a7e2ed /modules/caddyhttp/app.go | |
| parent | 0900844c813b8d02023c514085d84e5a52df49d7 (diff) | |
| download | caddy-7c82e265da8f90c1a1fee52c57af94587276ac56.tar.gz caddy-7c82e265da8f90c1a1fee52c57af94587276ac56.zip | |
core: quic listener will manage the underlying socket by itself (#5749)
* core: quic listener will manage the underlying socket by itself.
* format code
* rename sharedQUICTLSConfig to sharedQUICState, and it will now manage the number of active requests
* add comment
* strict unwrap type
* fix unwrap
* remove comment
Diffstat (limited to 'modules/caddyhttp/app.go')
| -rw-r--r-- | modules/caddyhttp/app.go | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/modules/caddyhttp/app.go b/modules/caddyhttp/app.go index 457a5f4d3..69cd73b96 100644 --- a/modules/caddyhttp/app.go +++ b/modules/caddyhttp/app.go @@ -617,17 +617,6 @@ func (app *App) Stop() error { zap.Error(err), zap.Strings("addresses", server.Listen)) } - - // TODO: we have to manually close our listeners because quic-go won't - // close listeners it didn't create along with the server itself... - // see https://github.com/quic-go/quic-go/issues/3560 - for _, el := range server.h3listeners { - if err := el.Close(); err != nil { - app.logger.Error("HTTP/3 listener close", - zap.Error(err), - zap.String("address", el.LocalAddr().String())) - } - } } stopH2Listener := func(server *Server) { defer finishedShutdown.Done() |