aboutsummaryrefslogtreecommitdiffhomepage
path: root/modules/caddyhttp/matchers.go
diff options
context:
space:
mode:
authorMatthew Holt <[email protected]>2022-11-30 16:03:31 -0700
committerMatthew Holt <[email protected]>2022-11-30 16:03:31 -0700
commitae77a56ac8761bfe064904bd7098a952d3221034 (patch)
tree2eca39fbe79662626825adac761b45d37027779b /modules/caddyhttp/matchers.go
parent762b02789ac0ef79e92de7c58dac19d24a104587 (diff)
downloadcaddy-ae77a56ac8761bfe064904bd7098a952d3221034.tar.gz
caddy-ae77a56ac8761bfe064904bd7098a952d3221034.zip
Clarify some docs
Diffstat (limited to 'modules/caddyhttp/matchers.go')
-rw-r--r--modules/caddyhttp/matchers.go15
1 files changed, 15 insertions, 0 deletions
diff --git a/modules/caddyhttp/matchers.go b/modules/caddyhttp/matchers.go
index e39ba3fc0..93c7e691f 100644
--- a/modules/caddyhttp/matchers.go
+++ b/modules/caddyhttp/matchers.go
@@ -123,6 +123,7 @@ type (
// keyed by the query keys, with an array of string values to match for that key.
// Query key matches are exact, but wildcards may be used for value matches. Both
// keys and values may be placeholders.
+ //
// An example of the structure to match `?key=value&topic=api&query=something` is:
//
// ```json
@@ -135,6 +136,13 @@ type (
//
// Invalid query strings, including those with bad escapings or illegal characters
// like semicolons, will fail to parse and thus fail to match.
+ //
+ // **NOTE:** Notice that query string values are arrays, not singular values. This is
+ // because repeated keys are valid in query strings, and each one may have a
+ // different value. This matcher will match for a key if any one of its configured
+ // values is assigned in the query string. Backend applications relyon on query
+ // strings MUST take into consideration that query string values are arrays and can
+ // have multiple values.
MatchQuery url.Values
// MatchHeader matches requests by header fields. The key is the field
@@ -144,6 +152,13 @@ type (
// surrounding the value with the wildcard `*` character, respectively.
// If a list is null, the header must not exist. If the list is empty,
// the field must simply exist, regardless of its value.
+ //
+ // **NOTE:** Notice that header values are arrays, not singular values. This is
+ // because repeated fields are valid in headers, and each one may have a
+ // different value. This matcher will match for a field if any one of its configured
+ // values matches in the header. Backend applications relying on headers MUST take
+ // into consideration that header field values are arrays and can have multiple
+ // values.
MatchHeader http.Header
// MatchHeaderRE matches requests by a regular expression on header fields.