aboutsummaryrefslogtreecommitdiffhomepage
path: root/modules/caddyhttp/reverseproxy/fastcgi/client.go
diff options
context:
space:
mode:
authorWeidiDeng <[email protected]>2024-12-18 08:22:12 +0800
committerGitHub <[email protected]>2024-12-18 00:22:12 +0000
commit6790c0e38abcc534c4b3365b6e438148001fd6df (patch)
tree169c10c564ad5ae470b05eff41f224a937c98e4e /modules/caddyhttp/reverseproxy/fastcgi/client.go
parentc864b82ae13f9dc920ebd8782fe7c5b7007a3e1b (diff)
downloadcaddy-6790c0e38abcc534c4b3365b6e438148001fd6df.tar.gz
caddy-6790c0e38abcc534c4b3365b6e438148001fd6df.zip
fastcgi: check for CONTENT_LENGTH when sending requests (#6661)
* fastcgi: check for CONTENT_LENGTH when sending requests * order imports * use strconv.ParseUint instead of strconv.ParseInt Co-authored-by: Kévin Dunglas <[email protected]> --------- Co-authored-by: Kévin Dunglas <[email protected]>
Diffstat (limited to 'modules/caddyhttp/reverseproxy/fastcgi/client.go')
-rw-r--r--modules/caddyhttp/reverseproxy/fastcgi/client.go11
1 files changed, 11 insertions, 0 deletions
diff --git a/modules/caddyhttp/reverseproxy/fastcgi/client.go b/modules/caddyhttp/reverseproxy/fastcgi/client.go
index 7284fe672..684394f53 100644
--- a/modules/caddyhttp/reverseproxy/fastcgi/client.go
+++ b/modules/caddyhttp/reverseproxy/fastcgi/client.go
@@ -41,6 +41,8 @@ import (
"go.uber.org/zap"
"go.uber.org/zap/zapcore"
+
+ "github.com/caddyserver/caddy/v2/modules/caddyhttp"
)
// FCGIListenSockFileno describes listen socket file number.
@@ -136,6 +138,15 @@ type client struct {
// Do made the request and returns a io.Reader that translates the data read
// from fcgi responder out of fcgi packet before returning it.
func (c *client) Do(p map[string]string, req io.Reader) (r io.Reader, err error) {
+ // check for CONTENT_LENGTH, since the lack of it or wrong value will cause the backend to hang
+ if clStr, ok := p["CONTENT_LENGTH"]; !ok {
+ return nil, caddyhttp.Error(http.StatusLengthRequired, nil)
+ } else if _, err := strconv.ParseUint(clStr, 10, 64); err != nil {
+ // stdlib won't return a negative Content-Length, but we check just in case,
+ // the most likely cause is from a missing content length, which is -1
+ return nil, caddyhttp.Error(http.StatusLengthRequired, err)
+ }
+
writer := &streamWriter{c: c}
writer.buf = bufPool.Get().(*bytes.Buffer)
writer.buf.Reset()