diff options
| author | sanni <[email protected]> | 2024-09-16 09:07:28 +0200 |
|---|---|---|
| committer | GitHub <[email protected]> | 2024-09-16 09:07:28 +0200 |
| commit | 7ad07067c906fe99bfaa96d0ee8309bca131b241 (patch) | |
| tree | c51248562c1922cca3bb5b894b0083325fdd6e33 | |
| parent | a19a10b16b2aad8ee9e0761fb832f969ff2cfee3 (diff) | |
| parent | dcf4aa85a31b47a2380d4e29964ce413d12ccd40 (diff) | |
| download | cartreader-7ad07067c906fe99bfaa96d0ee8309bca131b241.tar.gz cartreader-7ad07067c906fe99bfaa96d0ee8309bca131b241.zip | |
Merge pull request #1027 from partlyhuman/lynx-fix-electrocop
Fix for overdumping Electrocop/Lynx
| -rw-r--r-- | Cart_Reader/LYNX.ino | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/Cart_Reader/LYNX.ino b/Cart_Reader/LYNX.ino index 29010ca..001ed27 100644 --- a/Cart_Reader/LYNX.ino +++ b/Cart_Reader/LYNX.ino @@ -40,7 +40,7 @@ // | 34 |- SWVCC // +----+ // -// Version 1.1 +// Version 1.2 // By @partlyhuman // This implementation would not be possible without the invaluable // documentation on @@ -125,9 +125,11 @@ static bool waitPressButton_LYNX(bool ret = false) { static void compareStride_LYNX(uint8_t b, int i, int stride) { uint8_t other = readByte_LYNX(i + stride); - if (other == 0xff) { - // If this is a flash cart, these in-between spaces should be formatted to all 1's + if (other == 0xff || other == 0x00) { + // If this is NOR flash, these in-between spaces should be formatted to all 1's // in which case, we DON'T report this as an unmirrored area + // Additionally, we have encountered commercial carts where the maskrom is larger than it needs to be + // and in this case, the maskrom will be initialized to 0s, not 1s. return; } if (b != other) { |